fix: format python

Author: Zach Barnett

sdk/python/feast/expediagroup/search.py

@@ -7,11 +7,20 @@
 from feast.project import Project
 from feast.protos.feast.registry.RegistryServer_pb2 import (
     ExpediaProjectAndRelatedFeatureViews as ExpediaProjectAndRelatedFeatureViewsProto,
+)
+from feast.protos.feast.registry.RegistryServer_pb2 import (
     ExpediaSearchFeatureViewsRequest as ExpediaSearchFeatureViewsRequestProto,
+)
+from feast.protos.feast.registry.RegistryServer_pb2 import (
     ExpediaSearchFeatureViewsResponse as ExpediaSearchFeatureViewsResponseProto,
+)
+from feast.protos.feast.registry.RegistryServer_pb2 import (
     ExpediaSearchProjectsRequest as ExpediaSearchProjectsRequestProto,
-    ExpediaSearchProjectsResponse as ExpediaSearchProjectsResponseProto
 )
+from feast.protos.feast.registry.RegistryServer_pb2 import (
+    ExpediaSearchProjectsResponse as ExpediaSearchProjectsResponseProto,
+)
+
 
 class ExpediaProjectAndRelatedFeatureViews:
     """

sdk/python/feast/infra/registry/sql.py

@@ -1571,7 +1571,7 @@ def expedia_search_feature_views(
         with self.read_engine.begin() as conn:
             if not in_memory_filtering_required:
                 stmt = select(feature_views).order_by(feature_views.c.feature_view_name)
-                
+
                 if search_text:  # Only add search filter if search_text is not empty
                     stmt = stmt.where(
                         feature_views.c.feature_view_name.like(
@@ -1582,7 +1582,9 @@ def expedia_search_feature_views(
                 stmt = stmt.limit(page_size).offset(offset)
 
                 if search_text:
-                    rows = conn.execute(stmt, {"search_pattern": f"%{search_text}%"}).all()
+                    rows = conn.execute(
+                        stmt, {"search_pattern": f"%{search_text}%"}
+                    ).all()
                 else:
                     rows = conn.execute(stmt).all()
 

sdk/python/feast/registry_server.py

@@ -7,6 +7,8 @@
 from google.protobuf.empty_pb2 import Empty
 from grpc_health.v1 import health, health_pb2, health_pb2_grpc
 from grpc_reflection.v1alpha import reflection
+from sdk.python.feast.infra.registry.sql import SqlRegistry
+from sdk.python.feast.infra.registry.sql_fallback import SqlFallbackRegistry
 
 from feast import FeatureService, FeatureStore
 from feast.base_feature_view import BaseFeatureView
@@ -44,9 +46,6 @@
 from feast.sorted_feature_view import SortedFeatureView
 from feast.stream_feature_view import StreamFeatureView
 
-from sdk.python.feast.infra.registry.sql import SqlRegistry
-from sdk.python.feast.infra.registry.sql_fallback import SqlFallbackRegistry
-
 _logger = logging.getLogger(__name__)
 _logger.setLevel(logging.INFO)
 
@@ -811,7 +810,10 @@ def Proto(self, request, context):
     def ExpediaSearchProjects(
         self, request: RegistryServer_pb2.ExpediaSearchProjectsRequest, context
     ):
-        if not (isinstance(self.proxied_registry, SqlRegistry) or isinstance(self.proxied_registry, SqlFallbackRegistry)):
+        if not (
+            isinstance(self.proxied_registry, SqlRegistry)
+            or isinstance(self.proxied_registry, SqlFallbackRegistry)
+        ):
             raise TypeError("Registry must be SqlRegistry or SqlFallbackRegistry")
 
         # Using `type: ignore[attr-defined]` because this should only be implemented in sql registry.

sdk/python/tests/integration/registration/test_universal_registry.py

@@ -2037,22 +2037,22 @@ def test_registry_cache_expiration(test_registry):
 )
 def test_expedia_search_projects_success(test_registry):
     from feast.expediagroup.search import ExpediaSearchProjectsRequest
-    
+
     # Create projects with different attributes
     project1 = Project(
         name="test_project_1",
         description="Test project 1",
         tags={"team": "team1", "application": "app1"},
         owner="owner1@example.com",
     )
-    
+
     project2 = Project(
-        name="search_project_2", 
+        name="search_project_2",
         description="Search project 2",
         tags={"team": "team2", "application": "app2"},
         owner="owner2@example.com",
     )
-    
+
     project3 = Project(
         name="another_project",
         description="Another project",
@@ -2062,9 +2062,9 @@ def test_expedia_search_projects_success(test_registry):
 
     # Apply projects
     test_registry.apply_project(project1)
-    test_registry.apply_project(project2) 
+    test_registry.apply_project(project2)
     test_registry.apply_project(project3)
-    
+
     # Create feature views for projects
     batch_source = FileSource(
         name="test_source",
@@ -2073,25 +2073,25 @@ def test_expedia_search_projects_success(test_registry):
         timestamp_field="ts_col",
         created_timestamp_column="timestamp",
     )
-    
+
     entity = Entity(name="test_entity", join_keys=["test"])
-    
+
     fv1 = FeatureView(
         name="feature_view_1",
         schema=[Field(name="test", dtype=Int64), Field(name="feature1", dtype=String)],
         entities=[entity],
         source=batch_source,
         ttl=timedelta(minutes=5),
     )
-    
+
     fv2 = FeatureView(
-        name="feature_view_2", 
+        name="feature_view_2",
         schema=[Field(name="test", dtype=Int64), Field(name="feature2", dtype=String)],
         entities=[entity],
         source=batch_source,
         ttl=timedelta(minutes=5),
     )
-    
+
     test_registry.apply_feature_view(fv1, project1.name)
     test_registry.apply_feature_view(fv2, project2.name)
 
@@ -2103,29 +2103,33 @@ def test_expedia_search_projects_success(test_registry):
         page_index=0,
     )
     response = test_registry.expedia_search_projects(request)
-    
+
     assert response.total_projects >= 3
     assert len(response.projects_and_related_feature_views) >= 3
-    
+
     # Find our projects in the response
-    project_names = [p.project.name for p in response.projects_and_related_feature_views]
+    project_names = [
+        p.project.name for p in response.projects_and_related_feature_views
+    ]
     assert project1.name in project_names
     assert project2.name in project_names
     assert project3.name in project_names
-    
+
     # Test search with text filter
     request = ExpediaSearchProjectsRequest(
         search_text="test",
-        updated_at=None, 
+        updated_at=None,
         page_size=10,
         page_index=0,
     )
     response = test_registry.expedia_search_projects(request)
-    
-    project_names = [p.project.name for p in response.projects_and_related_feature_views]
+
+    project_names = [
+        p.project.name for p in response.projects_and_related_feature_views
+    ]
     assert project1.name in project_names
     # Note: project2 and project3 may not contain "test" in their project_id
-    
+
     # Test pagination
     request = ExpediaSearchProjectsRequest(
         search_text="",
@@ -2134,10 +2138,10 @@ def test_expedia_search_projects_success(test_registry):
         page_index=0,
     )
     response = test_registry.expedia_search_projects(request)
-    
+
     assert len(response.projects_and_related_feature_views) == 1
     assert response.total_page_indices >= 3
-    
+
     # Test that feature views are included
     for project_and_fvs in response.projects_and_related_feature_views:
         if project_and_fvs.project.name == project1.name:
@@ -2159,11 +2163,11 @@ def test_expedia_search_projects_success(test_registry):
 )
 def test_expedia_search_feature_views_success(test_registry):
     from feast.expediagroup.search import ExpediaSearchFeatureViewsRequest
-    
+
     # Create project
     project = Project(name="test_project", description="Test project")
     test_registry.apply_project(project)
-    
+
     # Create data sources
     batch_source1 = FileSource(
         name="source1",
@@ -2172,17 +2176,17 @@ def test_expedia_search_feature_views_success(test_registry):
         timestamp_field="ts_col",
         created_timestamp_column="timestamp",
     )
-    
+
     batch_source2 = FileSource(
-        name="source2", 
+        name="source2",
         file_format=ParquetFormat(),
         path="file://feast/source2/*",
         timestamp_field="ts_col",
         created_timestamp_column="timestamp",
     )
-    
+
     entity = Entity(name="test_entity", join_keys=["test"])
-    
+
     # Create feature views with different attributes
     fv1 = FeatureView(
         name="search_feature_view_1",
@@ -2193,17 +2197,17 @@ def test_expedia_search_feature_views_success(test_registry):
         online=True,
         tags={"team": "team1", "application": "app1"},
     )
-    
+
     fv2 = FeatureView(
         name="test_feature_view_2",
         schema=[Field(name="test", dtype=Int64), Field(name="feature2", dtype=String)],
-        entities=[entity], 
+        entities=[entity],
         source=batch_source2,
         ttl=timedelta(minutes=5),
         online=False,
         tags={"team": "team2", "application": "app2"},
     )
-    
+
     fv3 = FeatureView(
         name="another_view",
         schema=[Field(name="test", dtype=Int64), Field(name="feature3", dtype=String)],
@@ -2213,11 +2217,11 @@ def test_expedia_search_feature_views_success(test_registry):
         online=True,
         tags={"team": "team1", "application": "app3"},
     )
-    
+
     test_registry.apply_feature_view(fv1, project.name)
     test_registry.apply_feature_view(fv2, project.name)
     test_registry.apply_feature_view(fv3, project.name)
-    
+
     # Test search without filters
     request = ExpediaSearchFeatureViewsRequest(
         search_text="",
@@ -2230,15 +2234,15 @@ def test_expedia_search_feature_views_success(test_registry):
         page_index=0,
     )
     response = test_registry.expedia_search_feature_views(request)
-    
+
     assert response.total_feature_views >= 3
     assert len(response.feature_views) >= 3
-    
+
     fv_names = [fv.name for fv in response.feature_views]
     assert fv1.name in fv_names
     assert fv2.name in fv_names
     assert fv3.name in fv_names
-    
+
     # Test search with text filter
     request = ExpediaSearchFeatureViewsRequest(
         search_text="search",
@@ -2251,11 +2255,11 @@ def test_expedia_search_feature_views_success(test_registry):
         page_index=0,
     )
     response = test_registry.expedia_search_feature_views(request)
-    
+
     fv_names = [fv.name for fv in response.feature_views]
     assert fv1.name in fv_names  # contains "search"
     # Note: fv2 and fv3 may not contain "search" based on search implementation
-    
+
     # Test filter by online status
     request = ExpediaSearchFeatureViewsRequest(
         search_text="",
@@ -2268,12 +2272,12 @@ def test_expedia_search_feature_views_success(test_registry):
         page_index=0,
     )
     response = test_registry.expedia_search_feature_views(request)
-    
+
     fv_names = [fv.name for fv in response.feature_views]
     assert fv1.name in fv_names  # online=True
     assert fv2.name not in fv_names  # online=False
     assert fv3.name in fv_names  # online=True
-    
+
     # Test filter by team
     request = ExpediaSearchFeatureViewsRequest(
         search_text="",
@@ -2286,12 +2290,12 @@ def test_expedia_search_feature_views_success(test_registry):
         page_index=0,
     )
     response = test_registry.expedia_search_feature_views(request)
-    
+
     fv_names = [fv.name for fv in response.feature_views]
     assert fv1.name in fv_names  # team=team1
     assert fv2.name not in fv_names  # team=team2
     assert fv3.name in fv_names  # team=team1
-    
+
     # Test filter by application
     request = ExpediaSearchFeatureViewsRequest(
         search_text="",
@@ -2304,12 +2308,12 @@ def test_expedia_search_feature_views_success(test_registry):
         page_index=0,
     )
     response = test_registry.expedia_search_feature_views(request)
-    
+
     fv_names = [fv.name for fv in response.feature_views]
     assert fv1.name in fv_names  # application=app1
     assert fv2.name not in fv_names  # application=app2
     assert fv3.name not in fv_names  # application=app3
-    
+
     # Test pagination
     request = ExpediaSearchFeatureViewsRequest(
         search_text="",
@@ -2322,10 +2326,10 @@ def test_expedia_search_feature_views_success(test_registry):
         page_index=0,
     )
     response = test_registry.expedia_search_feature_views(request)
-    
+
     assert len(response.feature_views) == 1
     assert response.total_page_indices >= 3
-    
+
     # Test combined filters
     request = ExpediaSearchFeatureViewsRequest(
         search_text="",
@@ -2338,7 +2342,7 @@ def test_expedia_search_feature_views_success(test_registry):
         page_index=0,
     )
     response = test_registry.expedia_search_feature_views(request)
-    
+
     fv_names = [fv.name for fv in response.feature_views]
     assert fv1.name in fv_names  # online=True and team=team1
     assert fv2.name not in fv_names  # online=False