Skip to content

fix: Pass cache refresh error handling function to CachingRegistry #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zabarn wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix: Pass cache refresh error handling function to CachingRegistry #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a1445a
fix: Pass cache refresh error handling function to CachingRegistry
zabarn Mar 5, 2025
38fb85e
fix: run linter
zabarn Mar 5, 2025
66faeae
throw error in refresh loop 10% of time for testing
zabarn Mar 5, 2025
6a11cfc
fix: random
zabarn Mar 5, 2025
66314f7
remove random failures
zabarn Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions sdk/python/feast/infra/registry/caching_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
from abc import abstractmethod
from datetime import timedelta
from threading import Lock
from typing import List, Optional
from typing import Callable, List, Optional

from feast.base_feature_view import BaseFeatureView
from feast.data_source import DataSource
Expand All @@ -29,8 +29,15 @@


class CachingRegistry(BaseRegistry):
def __init__(self, project: str, cache_ttl_seconds: int, cache_mode: str):
def __init__(
self,
project: str,
cache_ttl_seconds: int,
cache_mode: str,
on_cache_refresh_failure: Optional[Callable[[Exception], None]] = None,
):
self.cache_mode = cache_mode
self._on_cache_refresh_failure = on_cache_refresh_failure
self.cached_registry_proto = RegistryProto()
self._refresh_lock = Lock()
self.cached_registry_proto_ttl = timedelta(
Expand Down Expand Up @@ -471,7 +478,8 @@ def refresh_loop():
if not self._stop_event.is_set():
self.refresh()
except Exception as e:
logger.exception("Exception in refresh_loop: %s", e)
if self._on_cache_refresh_failure:
self._on_cache_refresh_failure(e)

try:
self.registry_refresh_thread = threading.Thread(
Expand All @@ -483,6 +491,7 @@ def refresh_loop():
)
except Exception as e:
logger.exception("Failed to start registry refresh thread: %s", e)
raise e

def _exit_handler(self):
logger.info("Exiting, setting stop event for registry cache refresh thread")
Expand Down
2 changes: 2 additions & 0 deletions sdk/python/feast/infra/registry/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ def __init__(
registry_config,
project: str,
repo_path: Optional[Path],
on_cache_refresh_failure: Optional[Callable[[Exception], None]] = None,
):
assert registry_config is not None and isinstance(
registry_config, SqlRegistryConfig
Expand Down Expand Up @@ -296,6 +297,7 @@ def __init__(
project=project,
cache_ttl_seconds=registry_config.cache_ttl_seconds,
cache_mode=registry_config.cache_mode,
on_cache_refresh_failure=on_cache_refresh_failure,
)

def _sync_feast_metadata_to_projects_table(self):
Expand Down