Commit f9e0ea4
authored
feat(ktor-server): skip internal ContentNegotiation install when already configured (#2174)
### 📝 Description
`Route.graphQLGetRoute()` and `Route.graphQLPostRoute()` unconditionally
install `ContentNegotiation` on the route scope. When the host
application has already installed `ContentNegotiation` at the
application level — a common pattern when the app serves other JSON
endpoints or uses `StatusPages` with JSON error responses — Ktor throws
`DuplicatePluginException`:
```
Installing RouteScopedPlugin to application and route is not supported.
Consider moving application level install to routing root.
```
This PR makes the internal install conditional on
`application.pluginOrNull(ContentNegotiation)`:
- If `ContentNegotiation` is already installed at the application level,
the route-scoped install is skipped and the existing global
configuration is reused.
- If no global install is present, behaviour is unchanged: the
route-scoped install proceeds exactly as today, honouring
`streamingResponse` and `jacksonConfiguration`.
When the global install wins, `streamingResponse` and
`jacksonConfiguration` are not applied, since the application-level
configuration takes precedence; this trade-off is documented in the KDoc
for both routes.
No API change; fully backward compatible.
Added two regression tests in `GraphQLPluginTest` covering the
globally-installed case for both the GET and POST routes.
### 🔗 Related Issues
Fixes #20251 parent d5c4458 commit f9e0ea4
2 files changed
Lines changed: 98 additions & 12 deletions
File tree
- servers/graphql-kotlin-ktor-server/src
- main/kotlin/com/expediagroup/graphql/server/ktor
- test/kotlin/com/expediagroup/graphql/server/ktor
Lines changed: 38 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
| |||
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
36 | | - | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
37 | 45 | | |
38 | 46 | | |
39 | | - | |
40 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
41 | 52 | | |
42 | 53 | | |
43 | 54 | | |
44 | 55 | | |
45 | 56 | | |
46 | 57 | | |
47 | | - | |
48 | | - | |
49 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
50 | 63 | | |
51 | 64 | | |
52 | 65 | | |
53 | 66 | | |
54 | 67 | | |
55 | 68 | | |
56 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
57 | 78 | | |
58 | 79 | | |
59 | | - | |
60 | | - | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
61 | 85 | | |
62 | 86 | | |
63 | 87 | | |
64 | 88 | | |
65 | 89 | | |
66 | 90 | | |
67 | | - | |
68 | | - | |
69 | | - | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
70 | 96 | | |
71 | 97 | | |
72 | 98 | | |
| |||
Lines changed: 60 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
256 | 256 | | |
257 | 257 | | |
258 | 258 | | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
259 | 319 | | |
260 | 320 | | |
261 | 321 | | |
| |||
0 commit comments