Merge pull request #89412 from Expensify/fix/esmodule-naming-convention-exception

Author: mjasikowski

config/eslint/eslint.config.mjs

@@ -269,6 +269,16 @@ const config = defineConfig([
             '@typescript-eslint/max-params': ['error', {max: 10}],
             '@typescript-eslint/naming-convention': [
                 'error',
+                {
+                    selector: ['variable', 'property'],
+                    format: null,
+                    // Allow __esModule because it is a well-known interop property injected by bundlers
+                    // (e.g. Babel/Webpack) and sometimes required by library internals (e.g. react-native-skia).
+                    filter: {
+                        regex: '^__esModule$',
+                        match: true,
+                    },
+                },
                 {
                     selector: ['variable', 'property'],
                     format: ['camelCase', 'UPPER_CASE', 'PascalCase'],

jest/setup.ts

@@ -76,7 +76,6 @@ jest.mock('expo-location', () => ({
 
 // Needed for: https://stackoverflow.com/questions/76903168/mocking-libraries-in-jest
 jest.mock('react-native/Libraries/LogBox/LogBox', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: {
         ignoreLogs: jest.fn(),
@@ -149,7 +148,6 @@ jest.mock('@libs/scheduleOnLiveMarkdownRuntime', () => {
 });
 
 jest.mock('@src/setup/telemetry', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(),
     navigationIntegration: {
@@ -280,7 +278,6 @@ jest.mock(
 );
 
 jest.mock('@libs/prepareRequestPayload/index.native.ts', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn((command: string, data: Record<string, unknown>) => {
         const formData = new FormData();
@@ -303,7 +300,6 @@ jest.mock('@libs/prepareRequestPayload/index.native.ts', () => ({
 jest.mock('@components/ConfirmedRoute.tsx');
 
 jest.mock('@src/hooks/useWorkletStateMachine/runOnUISync', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(() => jest.fn()), // Return a function that returns a function
 }));
@@ -367,17 +363,14 @@ jest.mock('@src/components/KeyboardDismissibleFlatList/KeyboardDismissibleFlatLi
 // in triggerUnreadUpdate (also timer-based), this creates excessive timer churn that causes
 // heavy integration tests like SessionTest to exceed their timeout.
 jest.mock('@src/hooks/useDocumentTitle', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(),
 }));
 jest.mock('@src/hooks/useWorkspaceDocumentTitle', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(),
 }));
 jest.mock('@src/hooks/useDomainDocumentTitle', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(),
 }));

src/components/Charts/hooks/useChartFontManager/useChartFontManager.ts

@@ -6,7 +6,6 @@ function webFont(url: string): DataModule {
     // a DataModule (i.e. the result of a dynamic `require()` call), which always has the shape
     // `{ __esModule: true, default: <url> }`. The `__esModule` property uses a double-underscore prefix
     // that violates the naming-convention rule, but it is mandated by the library's internal contract.
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     return {__esModule: true, default: url} as unknown as DataModule;
 }
 

src/components/ReimbursementAccountLoadingIndicator.tsx

@@ -21,7 +21,7 @@ function ReimbursementAccountLoadingIndicator({onBackButtonPress}: Reimbursement
     return (
         <ScreenWrapper
             shouldShowOfflineIndicator={false}
-            style={[StyleSheet.absoluteFillObject, styles.reimbursementAccountFullScreenLoading]}
+            style={[StyleSheet.absoluteFill, styles.reimbursementAccountFullScreenLoading]}
             testID="ReimbursementAccountLoadingIndicator"
         >
             <HeaderWithBackButton

tests/actions/IOUTest.ts

@@ -6764,7 +6764,6 @@ describe('actions/IOU', () => {
     describe('setMoneyRequestOdometerImage and removeMoneyRequestOdometerImage', () => {
         beforeEach(() => {
             jest.mock('@libs/OdometerImageUtils', () => ({
-                // eslint-disable-next-line @typescript-eslint/naming-convention
                 __esModule: true,
                 default: jest.fn(),
             }));

tests/navigation/LinkedActionNotFoundGuardTest.tsx

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/naming-convention, @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-assignment */
+/* eslint-disable @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-assignment */
 import {act, render} from '@testing-library/react-native';
 import React from 'react';
 import {View} from 'react-native';

tests/navigation/cleanStaleReportActionBackToParamTest.ts

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/naming-convention, @typescript-eslint/no-unsafe-return */
+/* eslint-disable @typescript-eslint/no-unsafe-return */
 import type {NavigationState} from '@react-navigation/native';
 import cleanStaleReportActionBackToParam from '@src/pages/inbox/cleanStaleReportActionBackToParam';
 

tests/navigation/isActiveRouteTests.tsx

@@ -12,7 +12,6 @@ jest.mock('@libs/Navigation/navigationRef', () => {
     };
 
     return {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
         __esModule: true,
         default: navigationRefMock,
     };

tests/perf-test/SearchRouter.perf-test.tsx

@@ -46,13 +46,11 @@ jest.mock('@src/libs/Navigation/Navigation', () => ({
 }));
 
 jest.mock('@src/hooks/useRootNavigationState', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => ({contextualReportID: undefined, isSearchRouterScreen: false}),
 }));
 
 jest.mock('@hooks/useExportedToFilterOptions', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: () => ({
         exportedToFilterOptions: [],

tests/perf-test/SelectionList.perf-test.tsx

@@ -68,7 +68,6 @@ jest.mock('@react-navigation/native', () => ({
 }));
 
 jest.mock('../../src/hooks/useKeyboardState', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(() => ({
         isKeyboardShown: false,
@@ -77,7 +76,6 @@ jest.mock('../../src/hooks/useKeyboardState', () => ({
 }));
 
 jest.mock('../../src/hooks/useScreenWrapperTransitionStatus', () => ({
-    // eslint-disable-next-line @typescript-eslint/naming-convention
     __esModule: true,
     default: jest.fn(() => ({
         didScreenTransitionEnd: true,