Skip to content

Commit 0def6fe

Browse files
authored
Merge pull request #66869 from software-mansion-labs/war-in/remove-line-height-patch
Delete `restore-old-line-height-algorithm` React Native patch
2 parents b04e219 + fd1f4e9 commit 0def6fe

File tree

4 files changed

+2
-87
lines changed

4 files changed

+2
-87
lines changed

patches/react-native/details.md

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -170,16 +170,9 @@
170170
- E/App issue: 🛑
171171
- PR Introducing Patch: https://github.com/Expensify/App/pull/59738
172172

173-
### [react-native+0.79.2+024+restore-old-line-height-algorithm.patch](react-native+0.79.2+024+restore-old-line-height-algorithm.patch)
174-
175-
- Reason: This patch fixes line height calculation issues in Android text rendering by replacing the web-based CSS implementation with a priority-based approach that properly handles cases where font metrics exceed the specified line height, ensuring better text display consistency and preventing text clipping
176-
- Upstream PR/issue: 🛑
177-
- E/App issue: 🛑
178-
- PR Introducing Patch: https://github.com/Expensify/App/pull/60421
179-
180-
### [react-native+0.79.2+025+fix-display-contents-not-updating-nodes.patch](react-native+0.79.2+025+fix-display-contents-not-updating-nodes.patch)
173+
### [react-native+0.79.2+024+fix-display-contents-not-updating-nodes.patch](react-native+0.79.2+024+fix-display-contents-not-updating-nodes.patch)
181174

182175
- Reason: This patch updates Yoga to correctly update the subtrees of `display: contents` nodes so that they are in sync with their React Native counterparts.
183176
- Upstream PR/issue: https://github.com/facebook/react-native/pull/52530
184177
- E/App issue: https://github.com/Expensify/App/issues/65268
185-
- PR introducing patch: [#65925](https://github.com/Expensify/App/pull/65925)
178+
- PR introducing patch: [#65925](https://github.com/Expensify/App/pull/65925)

patches/react-native/react-native+0.79.2+025+fix-display-contents-not-updating-nodes.patch renamed to patches/react-native/react-native+0.79.2+024+fix-display-contents-not-updating-nodes.patch

File renamed without changes.

patches/react-native/react-native+0.79.2+024+restore-old-line-height-algorithm.patch

Lines changed: 0 additions & 77 deletions
This file was deleted.

src/styles/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3209,7 +3209,6 @@ const styles = (theme: ThemeColors) =>
32093209
...headlineFont,
32103210
fontSize: variables.iouAmountTextSize,
32113211
color: theme.heading,
3212-
lineHeight: variables.inputHeight,
32133212
},
32143213

32153214
iouAmountTextInput: addOutlineWidth(

0 commit comments

Comments
 (0)