Skip to content

Commit 20434e3

Browse files
author
Nabi
committed
Merge remote-tracking branch 'origin/main' into fix/prevent-auto-approval-held-expense-multi-violations
2 parents 002f534 + aae3230 commit 20434e3

723 files changed

Lines changed: 13779 additions & 2732 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

Mobile-Expensify

__mocks__/expo-video.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,6 @@ const VideoView = forwardRef((props: VideoViewProps, ref: ForwardedRef<View>) =>
101101
<View
102102
ref={ref}
103103
accessibilityLabel="MockVideoView"
104-
// eslint-disable-next-line react/jsx-props-no-spreading
105104
{...props}
106105
/>
107106
));

__mocks__/react-native-safe-area-context.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ function withSafeAreaInsets(WrappedComponent: React.ComponentType<WithSafeAreaIn
2323
function WithSafeAreaInsets(props: WithSafeAreaInsetsProps & {ref: React.ForwardedRef<unknown>}) {
2424
return (
2525
<WrappedComponent
26-
// eslint-disable-next-line react/jsx-props-no-spreading
2726
{...props}
2827
ref={props.ref}
2928
insets={insets}
@@ -34,7 +33,6 @@ function withSafeAreaInsets(WrappedComponent: React.ComponentType<WithSafeAreaIn
3433
function WithSafeAreaInsetsWithRef(props: WithSafeAreaInsetsProps & {ref: ForwardedRef<unknown>}) {
3534
return (
3635
<WithSafeAreaInsets
37-
// eslint-disable-next-line react/jsx-props-no-spreading
3836
{...props}
3937
ref={props.ref}
4038
/>

android/app/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ android {
111111
minSdkVersion rootProject.ext.minSdkVersion
112112
targetSdkVersion rootProject.ext.targetSdkVersion
113113
multiDexEnabled rootProject.ext.multiDexEnabled
114-
versionCode 1009037400
115-
versionName "9.3.74-0"
114+
versionCode 1009037404
115+
versionName "9.3.74-4"
116116
// Supported language variants must be declared here to avoid from being removed during the compilation.
117117
// This also helps us to not include unnecessary language variants in the APK.
118118
resConfigs "en", "es"
Lines changed: 1 addition & 0 deletions
Loading

config/eslint/eslint.config.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -766,6 +766,7 @@ const config = defineConfig([
766766
'web/snippets/gib.js',
767767
// Generated language files - excluded from ESLint but still type-checked
768768
'src/languages/de.ts',
769+
'src/languages/es.ts',
769770
'src/languages/fr.ts',
770771
'src/languages/it.ts',
771772
'src/languages/ja.ts',

config/eslint/eslint.seatbelt.tsv

Lines changed: 29 additions & 34 deletions
Large diffs are not rendered by default.

config/webpack/webpack.common.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -396,10 +396,9 @@ const getCommonConfiguration = ({file = '.env', platform = 'web'}: Environment):
396396
'@selectors': path.resolve(dirname, '../../src/selectors/'),
397397
},
398398

399-
// React Native libraries may have web-specific module implementations that appear with the extension `.web.js`
400-
// without this, web will try to use native implementations and break in not very obvious ways.
401-
// This is also why we have to use .website.js for our own web-specific files...
402-
extensions: ['.web.js', '.website.js', '.js', '.jsx', '.web.ts', '.website.ts', '.website.tsx', '.ts', '.web.tsx', '.tsx'],
399+
// Resolve web-specific implementations (`.web.*`) before bare files so React Native
400+
// libraries and our own app-level overrides both pick up their browser variants.
401+
extensions: ['.web.js', '.js', '.jsx', '.web.ts', '.web.tsx', '.ts', '.tsx'],
403402
fallback: {
404403
'process/browser': require.resolve('process/browser'),
405404
crypto: false,

contributingGuides/philosophies/CROSS-PLATFORM.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@ Put all platform specific code in dedicated files and folders (see below) and re
2828
In most cases, the code written for this repo should be platform-independent. In such cases, each module should have a single file, `index.js`, which defines the module's exports. There are, however, some cases in which a feature is intrinsically tied to the underlying platform. In such cases, the following file extensions can be used to export platform-specific code from a module:
2929
- Mobile => `index.native.js`
3030
- iOS Native App/Android Native App => `index.ios.js`/`index.android.js`
31-
- Web => `index.website.js`
31+
- Web => `index.web.js`
3232

3333
**Note:** `index.js` should be the default and only platform-specific implementations should be done in their respective files. i.e: If you have mobile-specific implementation in `index.native.js`, then the web implementation can be contained in a shared `index.js`.
3434

35-
`index.ios.js` and `index.android.js` are used when the app is running natively on respective platforms. These files are not used when users access the app through mobile browsers, but `index.website.js` is used instead. `index.native.js` are for both iOS and Android native apps. `index.native.js` should not be included in the same module as `index.ios.js` or `index.android.js`.
35+
`index.ios.js` and `index.android.js` are used when the app is running natively on respective platforms. These files are not used when users access the app through mobile browsers, but `index.web.js` is used instead. `index.native.js` are for both iOS and Android native apps. `index.native.js` should not be included in the same module as `index.ios.js` or `index.android.js`.
3636

3737
### Supporting Mobile Web
3838
The above platform-specific files only work because they are compiled when the app is built for the different platforms. This means that a different mechanism needs to be used for Mobile Web (since "mobile web" and "web" are the same at build time).

cspell.json

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,7 @@
268268
"favicons",
269269
"Ferroalloy",
270270
"FinancialForce",
271+
"feedcountry",
271272
"firebaselogging",
272273
"fireroom",
273274
"firstname",
@@ -278,6 +279,7 @@
278279
"FLJZ",
279280
"fname",
280281
"fnames",
282+
"focusability",
281283
"focusvisible",
282284
"fontawesome",
283285
"foreignamount",
@@ -325,6 +327,7 @@
325327
"Highlightable",
326328
"HKBCCATT",
327329
"Hoverable",
330+
"hrefs",
328331
"HRMS",
329332
"HSBCSGS",
330333
"Humpty",
@@ -333,6 +336,7 @@
333336
"iaco",
334337
"IBTA",
335338
"IDEIN",
339+
"idempotently",
336340
"idfa",
337341
"Idology",
338342
"ifdef",
@@ -923,7 +927,10 @@
923927
"CARDFROZEN",
924928
"CARDUNFROZEN",
925929
"backgrounded",
926-
"Kolkata"
930+
"Kolkata",
931+
"lintrk",
932+
"Fbclid",
933+
"Gclid"
927934
],
928935
"ignorePaths": [
929936
".gitignore",

0 commit comments

Comments
 (0)