Skip to content

Commit 2515dd8

Browse files
authored
Merge pull request #85244 from TaduJR/fix-Screen-Reader-Many-Pages-The-embedded-links-cannot-be-focused-and-activated
fix(a11y): update picker-select fork, remove Android TalkBack workaround
2 parents 57c1582 + 901f5c4 commit 2515dd8

3 files changed

Lines changed: 14 additions & 19 deletions

File tree

package-lock.json

Lines changed: 12 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@
182182
"react-native-pager-view": "8.0.0",
183183
"react-native-pdf": "7.0.2",
184184
"react-native-permissions": "^5.4.0",
185-
"react-native-picker-select": "git+https://github.com/Expensify/react-native-picker-select.git#07d60d78d4772d47afd7a744940fc6b6d1881806",
185+
"react-native-picker-select": "github:Expensify/react-native-picker-select#3e090db",
186186
"react-native-plaid-link-sdk": "12.5.3",
187187
"react-native-qrcode-svg": "6.3.21",
188188
"react-native-reanimated": "4.2.1",

src/components/Picker/BasePicker.tsx

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -227,19 +227,8 @@ function BasePicker<TPickerValue>({
227227
onClose={disableHighlight}
228228
textInputProps={{
229229
allowFontScaling: false,
230-
accessibilityRole: CONST.ROLE.COMBOBOX,
231-
accessibilityLabel: actualAccessibilityLabel,
232-
importantForAccessibility: 'no-hide-descendants',
233-
}}
234-
touchableDoneProps={{
235-
accessibilityRole: CONST.ROLE.BUTTON,
236-
accessibilityLabel: translate('common.dismiss'),
237-
}}
238-
touchableWrapperProps={{
239-
accessible: true,
240-
accessibilityRole: CONST.ROLE.COMBOBOX,
241-
accessibilityLabel: actualAccessibilityLabel,
242230
}}
231+
doneText={translate('common.done')}
243232
pickerProps={{
244233
ref: picker,
245234
tabIndex: pickerTabIndex,

0 commit comments

Comments
 (0)