Skip to content

Commit 27242b9

Browse files
committed
disable isCompactMode in split bill confirmation page in landscape mode
1 parent 399750a commit 27242b9

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

src/components/MoneyRequestConfirmationList.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import type {OnyxEntry} from 'react-native-onyx';
55
import {useCurrencyListActions} from '@hooks/useCurrencyList';
66
import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails';
77
import useDebouncedState from '@hooks/useDebouncedState';
8+
import useIsInLandscapeMode from '@hooks/useIsInLandscapeMode';
89
import useLocalize from '@hooks/useLocalize';
910
import {MouseProvider} from '@hooks/useMouseContext';
1011
import useOnyx from '@hooks/useOnyx';
@@ -251,6 +252,7 @@ function MoneyRequestConfirmationList({
251252
const isNewManualExpenseFlowEnabled = isBetaEnabled(CONST.BETAS.NEW_MANUAL_EXPENSE_FLOW);
252253
const {isDelegateAccessRestricted} = useDelegateNoAccessState();
253254
const {showDelegateNoAccessModal} = useDelegateNoAccessActions();
255+
const isInLandscapeMode = useIsInLandscapeMode();
254256

255257
const isTestReceipt = useMemo(() => {
256258
return transaction?.receipt?.isTestReceipt ?? false;
@@ -1060,7 +1062,7 @@ function MoneyRequestConfirmationList({
10601062
isLoadingReceipt,
10611063
]);
10621064

1063-
const isCompactMode = useMemo(() => !showMoreFields && isScanRequest, [isScanRequest, showMoreFields]);
1065+
const isCompactMode = useMemo(() => !showMoreFields && isScanRequest && !isInLandscapeMode, [isScanRequest, showMoreFields, isInLandscapeMode]);
10641066
const selectionListStyle = useMemo(
10651067
() => ({
10661068
containerStyle: [styles.flexBasisAuto],

src/components/MoneyRequestConfirmationListFooter.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import type {LayoutChangeEvent} from 'react-native';
77
import type {OnyxEntry} from 'react-native-onyx';
88
import type {ValueOf} from 'type-fest';
99
import {useCurrencyListActions} from '@hooks/useCurrencyList';
10+
import useIsInLandscapeMode from '@hooks/useIsInLandscapeMode';
1011
import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset';
1112
import useLocalize from '@hooks/useLocalize';
1213
import useLocalReceiptThumbnail from '@hooks/useLocalReceiptThumbnail';
@@ -345,6 +346,7 @@ function MoneyRequestConfirmationListFooter({
345346
const {translate, toLocaleDigit, localeCompare, preferredLocale} = useLocalize();
346347
const {getCurrencySymbol, getCurrencyDecimals} = useCurrencyListActions();
347348
const {isOffline} = useNetwork();
349+
const isInLandscapeMode = useIsInLandscapeMode();
348350
const {windowWidth} = useWindowDimensions();
349351

350352
const {isBetaEnabled} = usePermissions();
@@ -1319,7 +1321,7 @@ function MoneyRequestConfirmationListFooter({
13191321
return badges;
13201322
}, [firstDay, lastDay, translate, tripDays, icons]);
13211323

1322-
const isCompactMode = useMemo(() => !showMoreFields && isScan, [isScan, showMoreFields]);
1324+
const isCompactMode = useMemo(() => !showMoreFields && isScan && !isInLandscapeMode, [isScan, showMoreFields, isInLandscapeMode]);
13231325
const [receiptAspectRatio, setReceiptAspectRatio] = useState<number | null>(null);
13241326
const [compactReceiptContainerWidth, setCompactReceiptContainerWidth] = useState(0);
13251327
const hasEndedReceiptLoadSpan = useRef(false);

0 commit comments

Comments
 (0)