Skip to content

Commit 2c3e18f

Browse files
marcaaronOSBotify
authored andcommitted
Merge pull request #60462 from Expensify/revert-60078-pac-guerreiro/feature/test-drive-admin-modal
Revert "[Test Drive][Phase 1][FE] Implement the Test Drive modal" (cherry picked from commit 9b4d99d) (CP triggered by roryabraham)
1 parent 0106f10 commit 2c3e18f

15 files changed

Lines changed: 9 additions & 147 deletions

File tree

assets/images/fast-track-cover.jpg

-157 KB
Binary file not shown.

src/CONST.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5160,7 +5160,6 @@ const CONST = {
51605160
VIDEO_URL: `${CLOUDFRONT_URL}/videos/guided-setup-track-business-v2.mp4`,
51615161
LEARN_MORE_LINK: `${USE_EXPENSIFY_URL}/track-expenses`,
51625162
},
5163-
TEST_DRIVE_COVER_ASPECT_RATIO: 500 / 300,
51645163
},
51655164

51665165
/**

src/NAVIGATORS.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ export default {
1111
WELCOME_VIDEO_MODAL_NAVIGATOR: 'WelcomeVideoModalNavigator',
1212
EXPLANATION_MODAL_NAVIGATOR: 'ExplanationModalNavigator',
1313
MIGRATED_USER_MODAL_NAVIGATOR: 'MigratedUserModalNavigator',
14-
TEST_DRIVE_MODAL_NAVIGATOR: 'TestDriveModalNavigator',
1514
REPORTS_SPLIT_NAVIGATOR: 'ReportsSplitNavigator',
1615
SETTINGS_SPLIT_NAVIGATOR: 'SettingsSplitNavigator',
1716
WORKSPACE_SPLIT_NAVIGATOR: 'WorkspaceSplitNavigator',

src/ROUTES.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1893,7 +1893,6 @@ const ROUTES = {
18931893
},
18941894
WELCOME_VIDEO_ROOT: 'onboarding/welcome-video',
18951895
EXPLANATION_MODAL_ROOT: 'onboarding/explanation',
1896-
TEST_DRIVE_MODAL_ROOT: 'onboarding/test-drive',
18971896
WORKSPACE_CONFIRMATION: {
18981897
route: 'workspace/confirmation',
18991898
getRoute: (backTo?: string) => getUrlWithBackToParam(`workspace/confirmation`, backTo),

src/SCREENS.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -658,10 +658,6 @@ const SCREENS = {
658658
ROOT: 'MigratedUserWelcomeModal_Root',
659659
},
660660

661-
TEST_DRIVE_MODAL: {
662-
ROOT: 'TestDrive_Modal_Root',
663-
},
664-
665661
I_KNOW_A_TEACHER: 'I_Know_A_Teacher',
666662
INTRO_SCHOOL_PRINCIPAL: 'Intro_School_Principal',
667663
I_AM_A_TEACHER: 'I_Am_A_Teacher',

src/components/FeatureTrainingModal.tsx

Lines changed: 9 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import type {VideoReadyForDisplayEvent} from 'expo-av';
22
import type {ImageContentFit} from 'expo-image';
33
import React, {useCallback, useEffect, useLayoutEffect, useState} from 'react';
4-
import {Image, InteractionManager, View} from 'react-native';
5-
import type {ImageResizeMode, ImageSourcePropType, StyleProp, ViewStyle} from 'react-native';
4+
import {InteractionManager, View} from 'react-native';
5+
import type {StyleProp, ViewStyle} from 'react-native';
66
import {GestureHandlerRootView} from 'react-native-gesture-handler';
77
import type {MergeExclusive} from 'type-fest';
88
import useLocalize from '@hooks/useLocalize';
@@ -96,9 +96,6 @@ type BaseFeatureTrainingModalProps = {
9696

9797
/** Whether to disable the modal */
9898
isModalDisabled?: boolean;
99-
100-
/** Whether the modal image is a SVG */
101-
shouldRenderSVG?: boolean;
10299
};
103100

104101
type FeatureTrainingModalVideoProps = {
@@ -155,7 +152,6 @@ function FeatureTrainingModal({
155152
imageWidth,
156153
imageHeight,
157154
isModalDisabled = true,
158-
shouldRenderSVG = true,
159155
}: FeatureTrainingModalProps) {
160156
const styles = useThemeStyles();
161157
const StyleUtils = useStyleUtils();
@@ -219,19 +215,13 @@ function FeatureTrainingModal({
219215
(!!videoURL || !!image) && {aspectRatio},
220216
]}
221217
>
222-
{!!image && shouldRenderSVG ? (
218+
{!!image && (
223219
<ImageSVG
224220
src={image}
225221
contentFit={contentFitImage}
226222
width={imageWidth}
227223
height={imageHeight}
228224
/>
229-
) : (
230-
<Image
231-
source={image as ImageSourcePropType}
232-
resizeMode={contentFitImage as ImageResizeMode}
233-
style={styles.featureTrainingModalImage}
234-
/>
235225
)}
236226
{!!videoURL && videoStatus === 'video' && (
237227
<GestureHandlerRootView>
@@ -260,25 +250,23 @@ function FeatureTrainingModal({
260250
</View>
261251
);
262252
}, [
253+
image,
254+
imageHeight,
255+
imageWidth,
256+
contentFitImage,
263257
illustrationAspectRatio,
264258
styles.w100,
265-
styles.featureTrainingModalImage,
266259
styles.onboardingVideoPlayer,
267260
styles.flex1,
268261
styles.alignItemsCenter,
269262
styles.justifyContentCenter,
270263
styles.h100,
271-
illustrationInnerContainerStyle,
272-
videoURL,
273-
image,
274-
shouldRenderSVG,
275-
contentFitImage,
276-
imageWidth,
277-
imageHeight,
278264
videoStatus,
265+
videoURL,
279266
animationStyle,
280267
animation,
281268
shouldUseNarrowLayout,
269+
illustrationInnerContainerStyle,
282270
]);
283271

284272
const toggleWillShowAgain = useCallback(() => setWillShowAgain((prevWillShowAgain) => !prevWillShowAgain), []);

src/components/TestDriveModal.tsx

Lines changed: 0 additions & 38 deletions
This file was deleted.

src/languages/en.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6227,14 +6227,6 @@ const translations = {
62276227
talkToConcierge: 'Talk to Concierge',
62286228
hangUp: 'Hang up',
62296229
},
6230-
testDrive: {
6231-
modal: {
6232-
title: 'Take us for a test drive',
6233-
description: 'Take a quick product tour to get up to speed fast. No pit stops required!',
6234-
confirmText: 'Start test drive',
6235-
helpText: 'Skip',
6236-
},
6237-
},
62386230
};
62396231

62406232
export default translations satisfies TranslationDeepObject<typeof translations>;

src/languages/es.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6749,14 +6749,6 @@ const translations = {
67496749
talkToConcierge: 'Habla con Concierge',
67506750
hangUp: 'Colgar',
67516751
},
6752-
testDrive: {
6753-
modal: {
6754-
title: 'Haz una prueba con nosotros',
6755-
description: 'Haz un recorrido rápido por el producto para ponerte al día rápidamente. ¡No se requieren paradas!',
6756-
confirmText: 'Iniciar prueba',
6757-
helpText: 'Omitir',
6758-
},
6759-
},
67606752
};
67616753

67626754
export default translations satisfies TranslationDeepObject<typeof en>;

src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ import LeftModalNavigator from './Navigators/LeftModalNavigator';
6969
import MigratedUserWelcomeModalNavigator from './Navigators/MigratedUserWelcomeModalNavigator';
7070
import OnboardingModalNavigator from './Navigators/OnboardingModalNavigator';
7171
import RightModalNavigator from './Navigators/RightModalNavigator';
72-
import TestDriveModalNavigator from './Navigators/TestDriveModalNavigator';
7372
import WelcomeVideoModalNavigator from './Navigators/WelcomeVideoModalNavigator';
7473
import useRootNavigatorScreenOptions from './useRootNavigatorScreenOptions';
7574

@@ -631,11 +630,6 @@ function AuthScreens({session, lastOpenedPublicRoomID, initialLastUpdateIDApplie
631630
options={rootNavigatorScreenOptions.basicModalNavigator}
632631
component={MigratedUserWelcomeModalNavigator}
633632
/>
634-
<RootStack.Screen
635-
name={NAVIGATORS.TEST_DRIVE_MODAL_NAVIGATOR}
636-
options={rootNavigatorScreenOptions.basicModalNavigator}
637-
component={TestDriveModalNavigator}
638-
/>
639633
<RootStack.Screen
640634
name={NAVIGATORS.FEATURE_TRANING_MODAL_NAVIGATOR}
641635
options={rootNavigatorScreenOptions.basicModalNavigator}

0 commit comments

Comments
 (0)