Skip to content

Commit 2cc00de

Browse files
authored
Merge pull request #89477 from callstack-internal/perf/workflow-utils-native-map-keys
[No QA] perf: replace lodashMapKeys with native loop in WorkflowUtils
2 parents 6ebec11 + 04932ce commit 2cc00de

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

src/libs/WorkflowUtils.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import {Str} from 'expensify-common';
2-
import lodashMapKeys from 'lodash/mapKeys';
32
import type {OnyxEntry} from 'react-native-onyx';
43
import type {ValueOf} from 'type-fest';
54
import type {LocaleContextProps} from '@components/LocaleContextProvider';
@@ -148,7 +147,10 @@ function convertPolicyEmployeesToApprovalWorkflows({policy, personalDetails, fir
148147

149148
// Keep track of used approver emails to display hints in the UI
150149
const usedApproverEmails = new Set<string>();
151-
const personalDetailsByEmail = lodashMapKeys(personalDetails, (value, key) => value?.login ?? key);
150+
const personalDetailsByEmail: PersonalDetailsList = {};
151+
for (const [key, value] of Object.entries(personalDetails)) {
152+
personalDetailsByEmail[value?.login ?? key] = value;
153+
}
152154
const availableMembers: Member[] = [];
153155

154156
for (const employee of Object.values(employees)) {

0 commit comments

Comments
 (0)