Skip to content

Commit 55d54ff

Browse files
committed
fix: change guard to block when group itself is missing, add nullish fallback on failuredata rollback updatedomainsecuritygroup
1 parent 67f3e9d commit 55d54ff

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/libs/actions/Domain.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1878,7 +1878,7 @@ function updateDomainSecurityGroup(
18781878
key: `${ONYXKEYS.COLLECTION.DOMAIN}${domainAccountID}`,
18791879
value: {
18801880
[SECURITY_GROUP_KEY]: {
1881-
[settingsName]: currentSecurityGroup[settingsName],
1881+
[settingsName]: currentSecurityGroup[settingsName] ?? null,
18821882
},
18831883
} as PrefixedRecord<typeof CONST.DOMAIN.DOMAIN_SECURITY_GROUP_PREFIX, Partial<DomainSecurityGroup>>,
18841884
},

src/pages/domain/Groups/RestrictExpenseWorkspaceCreationToggle.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ function RestrictExpenseWorkspaceCreationToggle({domainAccountID, groupID}: Rest
3939
shouldPlaceSubtitleBelowSwitch
4040
isActive={isEnabled}
4141
onToggle={(enabled) => {
42-
if (!group?.name) {
42+
if (!group) {
4343
return;
4444
}
4545
updateDomainSecurityGroup(domainAccountID, groupID, group, {enableRestrictedPolicyCreation: enabled}, 'enableRestrictedPolicyCreation');

0 commit comments

Comments
 (0)