Skip to content

Commit 650d46c

Browse files
authored
Merge pull request #91865 from Expensify/beaman-91235-trim-vendor-violation-comment
[No QA] Trim verbose inactive-vendor violation comment (R1 App follow-up)
2 parents 6f59731 + 99d00e3 commit 650d46c

1 file changed

Lines changed: 2 additions & 12 deletions

File tree

src/libs/Violations/ViolationsUtils.ts

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -441,18 +441,8 @@ const ViolationsUtils = {
441441
: getTagViolationsForMultiLevelTags(updatedTransaction, newTransactionViolations, policyTagList, hasDependentTags);
442442
}
443443

444-
// Inactive vendor violation. Mirrors `categoryOutOfPolicy` / `tagOutOfPolicy` — computed
445-
// entirely client-side from the policy's imported vendor list. The vendor object on the
446-
// transaction is left as-is when the violation fires (or when the feature is disabled) —
447-
// we never clear the user's selection just because the vendor list changed; the admin
448-
// needs to see what was previously set so they can re-pick. Gated behind the
449-
// `vendorMatching` beta so Web-Expensify can ship the auto-match write path
450-
// independently — no production workspace sees the violation until the beta is enabled.
451-
//
452-
// Skip the reconcile entirely while `allBetas` is still loading (the module-level Onyx
453-
// subscription populates it asynchronously). Treating undefined as "no betas" would surface
454-
// as "feature off" here and silently strip a valid server-set `inactiveVendor` violation
455-
// during the startup window. The next recompute settles the state once betas land.
444+
// Inactive vendor violation, gated behind the `vendorMatching` beta. The transaction's
445+
// vendor is never cleared here — admins need to see what was set so they can re-pick.
456446
if (allBetas !== undefined) {
457447
const isVendorMatchingBetaEnabled = Permissions.isBetaEnabled(CONST.BETAS.VENDOR_MATCHING, allBetas);
458448
const hasInactiveVendorViolation = newTransactionViolations.some((violation) => violation.name === CONST.VIOLATIONS.INACTIVE_VENDOR);

0 commit comments

Comments
 (0)