Fix Your Spend section disappearing after deleting a split expense offline

Author: adamgrzybowski

src/libs/actions/IOU/SplitTransactionUpdate.ts

@@ -1792,10 +1792,23 @@ function updateSplitTransactions({
     // (e.g. split to a lower amount). Home reads that total from the cached snapshot, which is only refreshed
     // online, so patch the same-currency delta optimistically. `changesInReportTotal` is the signed report-total
     // delta (new split total minus the pre-split total) in the transaction currency.
+    // The split also changes how many reimbursable transactions the report holds (e.g. one expense becomes several).
+    // `count` drives the Home "Awaiting approval" row visibility, so it must move in lockstep with the membership
+    // change — otherwise a later deletion of one split child decrements a stale `count` to 0 and hides the row even
+    // though split children remain. The replaced set is the original transaction (creation of splits) or the existing
+    // split children (re-splitting); the new set is `splits`. A `reimbursable !== false` transaction counts (matching
+    // the snapshot query convention).
+    const reimbursableSplitsCount = splits.filter((split) => split.reimbursable !== false).length;
+    const previousReimbursableCount = isCreationOfSplits
+        ? Number(originalTransaction?.reimbursable !== false)
+        : originalChildTransactions.filter((childTransaction) => childTransaction?.reimbursable !== false).length;
+    const reimbursableCountDiff = reimbursableSplitsCount - previousReimbursableCount;
+
     const yourSpendSplitUpdates = getYourSpendSnapshotSplitUpdates({
         iouReport: expenseReport,
         originalTransaction,
         reimbursableDiff: changesInReportTotal,
+        reimbursableCountDiff,
         currentUserAccountID: currentUserPersonalDetails.accountID,
     });
     onyxData.optimisticData?.push(...yourSpendSplitUpdates.optimisticData);

src/libs/actions/IOU/YourSpendSnapshotUpdate.ts

@@ -468,19 +468,31 @@ type GetYourSpendSnapshotSplitUpdatesParams = {
     // Signed change to the report's reimbursable total, in the transaction/report currency
     // (new split total minus the pre-split total). Negative when the expense is split to a lower amount.
     reimbursableDiff: number;
+    // Signed change to the number of reimbursable transactions in the report caused by the split
+    // (e.g. splitting one expense into two reimbursable children is +1). `count` drives the Home row's
+    // visibility, so it must move in lockstep with the membership change even when `reimbursableDiff` is 0
+    // (an equal-amount split leaves the total unchanged but still adds transactions).
+    reimbursableCountDiff: number;
     currentUserAccountID: number;
 };
 
 /**
- * Optimistically patches the "Awaiting approval" snapshot total when a SUBMITTED expense is split and the resulting
- * reimbursable total changes (e.g. split to a lower amount). The report stays in the awaiting-approval section, so this
- * is a same-section amount delta rather than a state move. Home reads totals from `snapshot.search.total`, which is only
- * refreshed online. Mirrors the amount-edit path: same-currency only (the currency guard in
- * `buildSnapshotTotalUpdatesForHash` skips a mismatch, since FX conversion isn't available offline).
+ * Optimistically patches the "Awaiting approval" snapshot when a SUBMITTED expense is split. A split keeps the report
+ * in the awaiting-approval section but changes both its reimbursable total (e.g. split to a lower amount) and the number
+ * of reimbursable transactions it contains (one expense becomes several). Home reads `snapshot.search.total`/`count`,
+ * which are only refreshed online, and `count` drives the row's visibility — so both must be patched, even when the
+ * total is unchanged (an equal-amount split still changes `count`). Mirrors the amount-edit path: same-currency only
+ * (the currency guard in `buildSnapshotTotalUpdatesForHash` skips a mismatch, since FX conversion isn't available offline).
  */
-function getYourSpendSnapshotSplitUpdates({iouReport, originalTransaction, reimbursableDiff, currentUserAccountID}: GetYourSpendSnapshotSplitUpdatesParams): YourSpendSnapshotOnyxData {
+function getYourSpendSnapshotSplitUpdates({
+    iouReport,
+    originalTransaction,
+    reimbursableDiff,
+    reimbursableCountDiff,
+    currentUserAccountID,
+}: GetYourSpendSnapshotSplitUpdatesParams): YourSpendSnapshotOnyxData {
     const result: YourSpendSnapshotOnyxData = {optimisticData: [], successData: [], failureData: []};
-    if (!iouReport || !originalTransaction || reimbursableDiff === 0) {
+    if (!iouReport || !originalTransaction || (reimbursableDiff === 0 && reimbursableCountDiff === 0)) {
         return result;
     }
 
@@ -491,7 +503,7 @@ function getYourSpendSnapshotSplitUpdates({iouReport, originalTransaction, reimb
 
     const currency = getCurrency(originalTransaction);
     const approvalQueryJSON = buildSearchQueryJSON(buildAwaitingApprovalQuery(currentUserAccountID, paidGroupPolicyIDs));
-    mergeYourSpendSnapshotOnyxData(result, buildSnapshotTotalUpdatesForHash(approvalQueryJSON?.hash, reimbursableDiff, currency));
+    mergeYourSpendSnapshotOnyxData(result, buildSnapshotTotalUpdatesForHash(approvalQueryJSON?.hash, reimbursableDiff, currency, reimbursableCountDiff));
     return result;
 }