Skip to content

Commit 73725df

Browse files
committed
Merge branch 'main' into fix/88051-popover-height-in-landscape-mode
2 parents 992d4fa + e427128 commit 73725df

657 files changed

Lines changed: 19447 additions & 11552 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.claude/agents/deploy-blocker-investigator.md

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
name: deploy-blocker-investigator
33
description: Investigates deploy blockers to find the causing PR and recommend resolution.
4-
tools: Glob, Grep, Read, Bash, BashOutput
4+
tools: Glob, Grep, Read, Write, Bash, BashOutput
55
model: inherit
66
---
77

@@ -114,11 +114,9 @@ See Decision Tree below for label actions.
114114

115115
### Step 7: Post comment and update labels
116116

117-
Post your findings (use single quotes for the body to handle special characters):
117+
Write the comment body to a temp file using the Write tool, then post it:
118118
```bash
119-
gh issue comment "$ISSUE_URL" --body '## 🔍 Investigation Summary
120-
...your comment here...
121-
'
119+
gh issue comment "$ISSUE_URL" --body-file /tmp/investigation-summary.md
122120
```
123121

124122
Remove label only if the decision tree warrants it:
@@ -131,7 +129,12 @@ Call scripts by name only (e.g., `removeDeployBlockerLabel.sh`), not with full p
131129

132130
### Step 8: Assign contributors
133131

134-
When a causing PR is identified with medium or high confidence, assign the PR author and all approving reviewers to the deploy blocker issue using `gh issue edit "$ISSUE_URL" --add-assignee`. Extract approving reviewers from `gh pr view <PR_NUMBER> --json reviews`.
132+
If the primary causing PR has at least medium confidence, assign its author and approving reviewers to the deploy blocker issue. Only assign contributors from this single PR.
133+
134+
```bash
135+
gh pr view <PR_NUMBER> --json reviews
136+
gh issue edit "$ISSUE_URL" --add-assignee <logins>
137+
```
135138

136139
---
137140

@@ -172,7 +175,7 @@ Choose ONE:
172175

173176
## Comment Format
174177

175-
Post ONE comment using this exact format:
178+
Use the Write tool to create `/tmp/investigation-summary.md` with the following markdown structure. Every field and heading must be present.
176179

177180
```markdown
178181
## 🔍 Investigation Summary
@@ -186,7 +189,7 @@ Post ONE comment using this exact format:
186189
Brief explanation of why this recommendation (1-2 sentences).
187190

188191

189-
**Assigned**: @author (PR author), @reviewer (approving reviewer) — or omit if no causing PR identified
192+
**Assigned**: @author (PR author), @reviewer (approving reviewer) from highest-confidence causing PR only — omit if no causing PR identified
190193
**Labels**: [Describe any label changes made]
191194

192195
<details>
@@ -206,6 +209,8 @@ Technical explanation of what went wrong in the code.
206209

207210
</details>
208211
```
212+
213+
Then post with: `gh issue comment "$ISSUE_URL" --body-file /tmp/investigation-summary.md`
209214
---
210215

211216
## Constraints
@@ -218,7 +223,7 @@ Technical explanation of what went wrong in the code.
218223
- Make assumptions about code you haven't read
219224
- Recommend DEMOTE for bugs affecting core functionality (auth, payments, data loss)
220225
- Close the issue—only update labels and comment
221-
- Use heredocs, temp files, or shell redirects for comments
226+
- Use heredocs or shell redirects for comments
222227

223228
**DO:**
224229
- Always verify the causing PR touches the affected code before concluding

.claude/commands/investigate-deploy-blocker.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
allowed-tools: Bash(gh issue view:*),Bash(gh issue comment:*),Bash(gh issue edit:*),Bash(gh issue list:*),Bash(gh pr view:*),Bash(gh pr list:*),Bash(gh pr diff:*),Bash(gh api:*),Bash(git log:*),Bash(git show:*),Bash(git blame:*),Bash(removeDeployBlockerLabel.sh:*),Glob,Grep,Read
2+
allowed-tools: Bash(gh issue view:*),Bash(gh issue comment:*),Bash(gh issue edit:*),Bash(gh issue list:*),Bash(gh pr view:*),Bash(gh pr list:*),Bash(gh pr diff:*),Bash(gh api:*),Bash(git log:*),Bash(git show:*),Bash(git blame:*),Bash(removeDeployBlockerLabel.sh:*),Glob,Grep,Read,Write
33
description: Investigate a deploy blocker issue to find the causing PR and recommend resolution
44
---
55

.github/actions/javascript/authorChecklist/categories/newComponentCategory.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,7 @@ function detectReactComponent(code: string, filename: string): boolean | undefin
6565
// eslint-disable-next-line @typescript-eslint/naming-convention
6666
ClassDeclaration(path) {
6767
const {superClass} = path.node as unknown as SuperClassType;
68-
if (
69-
superClass &&
70-
((superClass.object && superClass.object.name === 'React' && isComponentOrPureComponent(superClass.property.name)) || isComponentOrPureComponent(superClass.name))
71-
) {
68+
if (superClass && ((superClass.object?.name === 'React' && isComponentOrPureComponent(superClass.property.name)) || isComponentOrPureComponent(superClass.name))) {
7269
isReactComponent = true;
7370
path.stop();
7471
}

.github/actions/javascript/getGraphiteString/action.yml

Lines changed: 0 additions & 13 deletions
This file was deleted.

.github/actions/javascript/getGraphiteString/getGraphiteString.ts

Lines changed: 0 additions & 68 deletions
This file was deleted.

0 commit comments

Comments
 (0)