Skip to content

Commit 7428c53

Browse files
iwizniaiwiznia
authored
Merge pull request #84399 from software-mansion-labs/feature/jakubstec/remove-unnecessary-types-from-translations-batch4
2 parents e6e5bfd + 608596f commit 7428c53

21 files changed

Lines changed: 72 additions & 148 deletions

‎src/languages/de.ts‎

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import type {
2424
ChangeFieldParams,
2525
ConciergeBrokenCardConnectionParams,
2626
ConnectionNameParams,
27-
CreatedReportForUnapprovedTransactionsParams,
2827
DelegateRoleParams,
2928
DeleteActionParams,
3029
DeleteConfirmationParams,
@@ -53,12 +52,8 @@ import type {
5352
SyncStageNameConnectionsParams,
5453
UnshareParams,
5554
UnsupportedFormulaValueErrorParams,
56-
UpdatedTheDistanceMerchantParams,
57-
UpdatedTheRequestParams,
5855
UpdateRoleParams,
59-
UserIsAlreadyMemberParams,
6056
ViolationsIncreasedDistanceParams,
61-
ViolationsMissingTagParams,
6257
ViolationsModifiedAmountParams,
6358
WorkspaceLockedPlanTypeParams,
6459
YourPlanPriceParams,
@@ -873,7 +868,7 @@ const translations: TranslationDeepObject<typeof en> = {
873868
humanSupportAgent: 'einem menschlichen Support-Mitarbeiter',
874869
harvestCreatedExpenseReport: (reportUrl: string, reportName: string) =>
875870
`hat diesen Bericht erstellt, um alle Ausgaben aus <a href="${reportUrl}">${reportName}</a> aufzunehmen, die nicht mit der von dir gewählten Häufigkeit eingereicht werden konnten`,
876-
createdReportForUnapprovedTransactions: ({reportUrl, reportName, reportID, isReportDeleted}: CreatedReportForUnapprovedTransactionsParams) =>
871+
createdReportForUnapprovedTransactions: (reportUrl: string, reportName: string, reportID: string, isReportDeleted: boolean) =>
877872
isReportDeleted
878873
? `hat diesen Bericht für alle zurückgehaltenen Ausgaben aus dem gelöschten Bericht #${reportID} erstellt`
879874
: `hat diesen Bericht für alle zurückgehaltenen Ausgaben aus <a href="${reportUrl}">${reportName}</a> erstellt`,
@@ -1414,8 +1409,8 @@ const translations: TranslationDeepObject<typeof en> = {
14141409
setTheDistanceMerchant: (translatedChangedField: string, newMerchant: string, newAmountToDisplay: string) =>
14151410
`lege ${translatedChangedField} auf ${newMerchant} fest, wodurch der Betrag auf ${newAmountToDisplay} gesetzt wurde`,
14161411
removedTheRequest: (valueName: string, oldValueToDisplay: string) => `der/die/das ${valueName} (zuvor ${oldValueToDisplay})`,
1417-
updatedTheRequest: ({valueName, newValueToDisplay, oldValueToDisplay}: UpdatedTheRequestParams) => `die/den/das ${valueName} auf ${newValueToDisplay} (zuvor ${oldValueToDisplay})`,
1418-
updatedTheDistanceMerchant: ({translatedChangedField, newMerchant, oldMerchant, newAmountToDisplay, oldAmountToDisplay}: UpdatedTheDistanceMerchantParams) =>
1412+
updatedTheRequest: (valueName: string, newValueToDisplay: string, oldValueToDisplay: string) => `die/den/das ${valueName} auf ${newValueToDisplay} (zuvor ${oldValueToDisplay})`,
1413+
updatedTheDistanceMerchant: (translatedChangedField: string, newMerchant: string, oldMerchant: string, newAmountToDisplay: string, oldAmountToDisplay: string) =>
14191414
`hat ${translatedChangedField} in ${newMerchant} geändert (vorher ${oldMerchant}), wodurch der Betrag auf ${newAmountToDisplay} aktualisiert wurde (vorher ${oldAmountToDisplay})`,
14201415
basedOnAI: 'basierend auf bisherigen Aktivitäten',
14211416
basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `basierend auf den <a href="${rulesLink}">Workspace-Regeln</a>` : 'basierend auf dem Workspace-Regelwerk'),
@@ -3537,8 +3532,8 @@ ${amount} für ${merchant} – ${date}`,
35373532
messages: {
35383533
errorMessageInvalidPhone: `Bitte gib eine gültige Telefonnummer ohne Klammern oder Bindestriche ein. Wenn du außerhalb der USA bist, füge bitte deine Ländervorwahl hinzu (z. B. ${CONST.EXAMPLE_PHONE_NUMBER}).`,
35393534
errorMessageInvalidEmail: 'Ungültige E-Mail',
3540-
userIsAlreadyMember: ({login, name}: UserIsAlreadyMemberParams) => `${login} ist bereits Mitglied von ${name}`,
3541-
userIsAlreadyAnAdmin: ({login, name}: UserIsAlreadyMemberParams) => `${login} ist bereits Administrator*in von ${name}`,
3535+
userIsAlreadyMember: (login: string, name: string) => `${login} ist bereits Mitglied von ${name}`,
3536+
userIsAlreadyAnAdmin: (login: string, name: string) => `${login} ist bereits Administrator*in von ${name}`,
35423537
},
35433538
onfidoStep: {
35443539
acceptTerms: 'Indem Sie mit der Anfrage zur Aktivierung Ihres Expensify Wallets fortfahren, bestätigen Sie, dass Sie dies gelesen haben, verstehen und akzeptieren',
@@ -8361,7 +8356,7 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
83618356
missingCategory: 'Fehlende Kategorie',
83628357
missingComment: 'Beschreibung für die ausgewählte Kategorie erforderlich',
83638358
missingAttendees: 'Für diese Kategorie sind mehrere Teilnehmende erforderlich',
8364-
missingTag: ({tagName}: ViolationsMissingTagParams = {}) => `Fehlend ${tagName ?? 'Tag'}`,
8359+
missingTag: (tagName?: string) => `Fehlend ${tagName ?? 'Tag'}`,
83658360
modifiedAmount: ({type, displayPercentVariance}: ViolationsModifiedAmountParams) => {
83668361
switch (type) {
83678362
case 'distance':

‎src/languages/en.ts‎

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import type {
1212
ChangeFieldParams,
1313
ConciergeBrokenCardConnectionParams,
1414
ConnectionNameParams,
15-
CreatedReportForUnapprovedTransactionsParams,
1615
DelegateRoleParams,
1716
DeleteActionParams,
1817
DeleteConfirmationParams,
@@ -41,12 +40,8 @@ import type {
4140
SyncStageNameConnectionsParams,
4241
UnshareParams,
4342
UnsupportedFormulaValueErrorParams,
44-
UpdatedTheDistanceMerchantParams,
45-
UpdatedTheRequestParams,
4643
UpdateRoleParams,
47-
UserIsAlreadyMemberParams,
4844
ViolationsIncreasedDistanceParams,
49-
ViolationsMissingTagParams,
5045
ViolationsModifiedAmountParams,
5146
WorkspaceLockedPlanTypeParams,
5247
YourPlanPriceParams,
@@ -901,7 +896,7 @@ const translations = {
901896
humanSupportAgent: 'a human support agent',
902897
harvestCreatedExpenseReport: (reportUrl: string, reportName: string) =>
903898
`created this report to hold all expenses from <a href="${reportUrl}">${reportName}</a> that couldn't be submitted on your chosen frequency`,
904-
createdReportForUnapprovedTransactions: ({reportUrl, reportName, reportID, isReportDeleted}: CreatedReportForUnapprovedTransactionsParams) =>
899+
createdReportForUnapprovedTransactions: (reportUrl: string, reportName: string, reportID: string, isReportDeleted: boolean) =>
905900
isReportDeleted
906901
? `created this report for any held expenses from deleted report #${reportID}`
907902
: `created this report for any held expenses from <a href="${reportUrl}">${reportName}</a>`,
@@ -1467,8 +1462,8 @@ const translations = {
14671462
setTheDistanceMerchant: (translatedChangedField: string, newMerchant: string, newAmountToDisplay: string) =>
14681463
`set the ${translatedChangedField} to ${newMerchant}, which set the amount to ${newAmountToDisplay}`,
14691464
removedTheRequest: (valueName: string, oldValueToDisplay: string) => `the ${valueName} (previously ${oldValueToDisplay})`,
1470-
updatedTheRequest: ({valueName, newValueToDisplay, oldValueToDisplay}: UpdatedTheRequestParams) => `the ${valueName} to ${newValueToDisplay} (previously ${oldValueToDisplay})`,
1471-
updatedTheDistanceMerchant: ({translatedChangedField, newMerchant, oldMerchant, newAmountToDisplay, oldAmountToDisplay}: UpdatedTheDistanceMerchantParams) =>
1465+
updatedTheRequest: (valueName: string, newValueToDisplay: string, oldValueToDisplay: string) => `the ${valueName} to ${newValueToDisplay} (previously ${oldValueToDisplay})`,
1466+
updatedTheDistanceMerchant: (translatedChangedField: string, newMerchant: string, oldMerchant: string, newAmountToDisplay: string, oldAmountToDisplay: string) =>
14721467
`changed the ${translatedChangedField} to ${newMerchant} (previously ${oldMerchant}), which updated the amount to ${newAmountToDisplay} (previously ${oldAmountToDisplay})`,
14731468
basedOnAI: 'based on past activity',
14741469
basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `based on <a href="${rulesLink}">workspace rules</a>` : 'based on workspace rule'),
@@ -3605,8 +3600,8 @@ const translations = {
36053600
messages: {
36063601
errorMessageInvalidPhone: `Please enter a valid phone number without brackets or dashes. If you're outside the US, please include your country code (e.g. ${CONST.EXAMPLE_PHONE_NUMBER}).`,
36073602
errorMessageInvalidEmail: 'Invalid email',
3608-
userIsAlreadyMember: ({login, name}: UserIsAlreadyMemberParams) => `${login} is already a member of ${name}`,
3609-
userIsAlreadyAnAdmin: ({login, name}: UserIsAlreadyMemberParams) => `${login} is already an admin of ${name}`,
3603+
userIsAlreadyMember: (login: string, name: string) => `${login} is already a member of ${name}`,
3604+
userIsAlreadyAnAdmin: (login: string, name: string) => `${login} is already an admin of ${name}`,
36103605
},
36113606
onfidoStep: {
36123607
acceptTerms: 'By continuing with the request to activate your Expensify Wallet, you confirm that you have read, understand, and accept',
@@ -8348,7 +8343,7 @@ const translations = {
83488343
missingCategory: 'Missing category',
83498344
missingComment: 'Description required for selected category',
83508345
missingAttendees: 'Multiple attendees required for this category',
8351-
missingTag: ({tagName}: ViolationsMissingTagParams = {}) => `Missing ${tagName ?? 'tag'}`,
8346+
missingTag: (tagName?: string) => `Missing ${tagName ?? 'tag'}`,
83528347
modifiedAmount: ({type, displayPercentVariance}: ViolationsModifiedAmountParams) => {
83538348
switch (type) {
83548349
case 'distance':

‎src/languages/es.ts‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import dedent from '@libs/StringUtils/dedent';
33
import CONST from '@src/CONST';
44
import type {OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
55
import type en from './en';
6-
import type {ConciergeBrokenCardConnectionParams, CreatedReportForUnapprovedTransactionsParams, PaidElsewhereParams, UnsupportedFormulaValueErrorParams} from './params';
6+
import type {ConciergeBrokenCardConnectionParams, PaidElsewhereParams, UnsupportedFormulaValueErrorParams} from './params';
77
import type {TranslationDeepObject} from './types';
88

99
const translations: TranslationDeepObject<typeof en> = {
@@ -802,7 +802,7 @@ const translations: TranslationDeepObject<typeof en> = {
802802
humanSupportAgent: 'un agente de soporte humano',
803803
harvestCreatedExpenseReport: (reportUrl, reportName) =>
804804
`creó este informe para contener todos los gastos de <a href="${reportUrl}">${reportName}</a> que no se pudieron enviar con la frecuencia que elegiste`,
805-
createdReportForUnapprovedTransactions: ({reportUrl, reportName, reportID, isReportDeleted}: CreatedReportForUnapprovedTransactionsParams) =>
805+
createdReportForUnapprovedTransactions: (reportUrl, reportName, reportID, isReportDeleted) =>
806806
isReportDeleted
807807
? `creó este informe para cualquier gasto retenido del informe eliminado #${reportID}`
808808
: `creó este informe para cualquier gasto retenido de <a href="${reportUrl}">${reportName}</a>`,
@@ -1364,9 +1364,9 @@ const translations: TranslationDeepObject<typeof en> = {
13641364
`estableció la ${translatedChangedField} a ${newMerchant}, lo que estableció el importe a ${newAmountToDisplay}`,
13651365
removedTheRequest: (valueName, oldValueToDisplay) =>
13661366
`${valueName === 'comerciante' || valueName === 'importe' || valueName === 'gasto' ? 'el' : 'la'} ${valueName} (previamente ${oldValueToDisplay})`,
1367-
updatedTheRequest: ({valueName, newValueToDisplay, oldValueToDisplay}) =>
1367+
updatedTheRequest: (valueName, newValueToDisplay, oldValueToDisplay) =>
13681368
`${valueName === 'comerciante' || valueName === 'importe' || valueName === 'gasto' ? 'el' : 'la'} ${valueName} a ${newValueToDisplay} (previamente ${oldValueToDisplay})`,
1369-
updatedTheDistanceMerchant: ({translatedChangedField, newMerchant, oldMerchant, newAmountToDisplay, oldAmountToDisplay}) =>
1369+
updatedTheDistanceMerchant: (translatedChangedField, newMerchant, oldMerchant, newAmountToDisplay, oldAmountToDisplay) =>
13701370
`cambió la ${translatedChangedField} a ${newMerchant} (previamente ${oldMerchant}), lo que cambió el importe a ${newAmountToDisplay} (previamente ${oldAmountToDisplay})`,
13711371
basedOnAI: 'basado en actividad pasada',
13721372
basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `basado en <a href="${rulesLink}">reglas del espacio de trabajo</a>` : 'basado en regla del espacio de trabajo'),
@@ -3443,8 +3443,8 @@ ${amount} para ${merchant} - ${date}`,
34433443
messages: {
34443444
errorMessageInvalidPhone: `Por favor, introduce un número de teléfono válido sin paréntesis o guiones. Si reside fuera de Estados Unidos, por favor incluye el prefijo internacional (p. ej. ${CONST.EXAMPLE_PHONE_NUMBER}).`,
34453445
errorMessageInvalidEmail: 'Correo electrónico inválido',
3446-
userIsAlreadyMember: ({login, name}) => `${login} ya es miembro de ${name}`,
3447-
userIsAlreadyAnAdmin: ({login, name}) => `${login} ya es administrador de ${name}`,
3446+
userIsAlreadyMember: (login, name) => `${login} ya es miembro de ${name}`,
3447+
userIsAlreadyAnAdmin: (login, name) => `${login} ya es administrador de ${name}`,
34483448
},
34493449
onfidoStep: {
34503450
acceptTerms: 'Al continuar con la solicitud para activar tu Billetera Expensify, confirma que ha leído, comprende y acepta ',
@@ -8578,7 +8578,7 @@ ${amount} para ${merchant} - ${date}`,
85788578
missingCategory: 'Falta categoría',
85798579
missingComment: 'Descripción obligatoria para la categoría seleccionada',
85808580
missingAttendees: 'Se requieren múltiples asistentes para esta categoría',
8581-
missingTag: ({tagName} = {}) => `Falta ${tagName ?? 'etiqueta'}`,
8581+
missingTag: (tagName) => `Falta ${tagName ?? 'etiqueta'}`,
85828582
modifiedAmount: ({type, displayPercentVariance}) => {
85838583
switch (type) {
85848584
case 'distance':

‎src/languages/fr.ts‎

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import type {
2424
ChangeFieldParams,
2525
ConciergeBrokenCardConnectionParams,
2626
ConnectionNameParams,
27-
CreatedReportForUnapprovedTransactionsParams,
2827
DelegateRoleParams,
2928
DeleteActionParams,
3029
DeleteConfirmationParams,
@@ -53,12 +52,8 @@ import type {
5352
SyncStageNameConnectionsParams,
5453
UnshareParams,
5554
UnsupportedFormulaValueErrorParams,
56-
UpdatedTheDistanceMerchantParams,
57-
UpdatedTheRequestParams,
5855
UpdateRoleParams,
59-
UserIsAlreadyMemberParams,
6056
ViolationsIncreasedDistanceParams,
61-
ViolationsMissingTagParams,
6257
ViolationsModifiedAmountParams,
6358
WorkspaceLockedPlanTypeParams,
6459
YourPlanPriceParams,
@@ -876,7 +871,7 @@ const translations: TranslationDeepObject<typeof en> = {
876871
humanSupportAgent: 'un agent humain',
877872
harvestCreatedExpenseReport: (reportUrl: string, reportName: string) =>
878873
`a créé cette note de frais pour regrouper toutes les dépenses de <a href="${reportUrl}">${reportName}</a> qui n'ont pas pu être soumises à la fréquence que vous avez choisie`,
879-
createdReportForUnapprovedTransactions: ({reportUrl, reportName, reportID, isReportDeleted}: CreatedReportForUnapprovedTransactionsParams) =>
874+
createdReportForUnapprovedTransactions: (reportUrl: string, reportName: string, reportID: string, isReportDeleted: boolean) =>
880875
isReportDeleted
881876
? `a créé cette note de frais pour toutes les dépenses retenues de la note de frais supprimée n°${reportID}`
882877
: `a créé cette note de frais pour toutes les dépenses retenues provenant de <a href="${reportUrl}">${reportName}</a>`,
@@ -1416,8 +1411,8 @@ const translations: TranslationDeepObject<typeof en> = {
14161411
setTheDistanceMerchant: (translatedChangedField: string, newMerchant: string, newAmountToDisplay: string) =>
14171412
`défini le ${translatedChangedField} sur ${newMerchant}, ce qui a défini le montant sur ${newAmountToDisplay}`,
14181413
removedTheRequest: (valueName: string, oldValueToDisplay: string) => `le ${valueName} (anciennement ${oldValueToDisplay})`,
1419-
updatedTheRequest: ({valueName, newValueToDisplay, oldValueToDisplay}: UpdatedTheRequestParams) => `le ${valueName} sur ${newValueToDisplay} (précédemment ${oldValueToDisplay})`,
1420-
updatedTheDistanceMerchant: ({translatedChangedField, newMerchant, oldMerchant, newAmountToDisplay, oldAmountToDisplay}: UpdatedTheDistanceMerchantParams) =>
1414+
updatedTheRequest: (valueName: string, newValueToDisplay: string, oldValueToDisplay: string) => `le ${valueName} sur ${newValueToDisplay} (précédemment ${oldValueToDisplay})`,
1415+
updatedTheDistanceMerchant: (translatedChangedField: string, newMerchant: string, oldMerchant: string, newAmountToDisplay: string, oldAmountToDisplay: string) =>
14211416
`a modifié ${translatedChangedField} en ${newMerchant} (auparavant ${oldMerchant}), ce qui a mis à jour le montant à ${newAmountToDisplay} (auparavant ${oldAmountToDisplay})`,
14221417
basedOnAI: 'd’après l’activité précédente',
14231418
basedOnMCC: ({rulesLink}: {rulesLink: string}) =>
@@ -3546,8 +3541,8 @@ ${amount} pour ${merchant} - ${date}`,
35463541
messages: {
35473542
errorMessageInvalidPhone: `Veuillez saisir un numéro de téléphone valide sans parenthèses ni tirets. Si vous êtes en dehors des États-Unis, veuillez inclure votre indicatif de pays (p. ex. ${CONST.EXAMPLE_PHONE_NUMBER}).`,
35483543
errorMessageInvalidEmail: 'E-mail invalide',
3549-
userIsAlreadyMember: ({login, name}: UserIsAlreadyMemberParams) => `${login} est déjà membre de ${name}`,
3550-
userIsAlreadyAnAdmin: ({login, name}: UserIsAlreadyMemberParams) => `${login} est déjà administrateur de ${name}`,
3544+
userIsAlreadyMember: (login: string, name: string) => `${login} est déjà membre de ${name}`,
3545+
userIsAlreadyAnAdmin: (login: string, name: string) => `${login} est déjà administrateur de ${name}`,
35513546
},
35523547
onfidoStep: {
35533548
acceptTerms: 'En poursuivant la demande d’activation de votre Portefeuille Expensify, vous confirmez que vous avez lu, compris et accepté',
@@ -8384,7 +8379,7 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
83848379
missingCategory: 'Catégorie manquante',
83858380
missingComment: 'Description requise pour la catégorie sélectionnée',
83868381
missingAttendees: 'Plusieurs participants sont requis pour cette catégorie',
8387-
missingTag: ({tagName}: ViolationsMissingTagParams = {}) => `${tagName ?? 'tag'} manquant`,
8382+
missingTag: (tagName?: string) => `${tagName ?? 'tag'} manquant`,
83888383
modifiedAmount: ({type, displayPercentVariance}: ViolationsModifiedAmountParams) => {
83898384
switch (type) {
83908385
case 'distance':

0 commit comments

Comments
 (0)