Skip to content

Commit 75fe887

Browse files
MelvinBotsituchan
andcommitted
Make splitExpensesTotal required with number | undefined type
Change splitExpensesTotal from optional (?) to required (number | undefined) in UpdateSplitTransactionsParams to ensure callers always explicitly handle it. Update test call sites to pass splitExpensesTotal: undefined. Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
1 parent 5967cec commit 75fe887

2 files changed

Lines changed: 13 additions & 1 deletion

File tree

src/libs/actions/IOU/Split.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ type UpdateSplitTransactionsParams = {
216216
reportID: string;
217217
originalTransactionID: string;
218218
splitExpenses: SplitExpense[];
219-
splitExpensesTotal?: number;
219+
splitExpensesTotal: number | undefined;
220220
};
221221
searchContext?: (Partial<SearchStateContextValue & SearchActionsContextValue> & {activeGroupSearchHashes?: number[]}) | undefined;
222222
policyCategories: OnyxTypes.PolicyCategories | undefined;

tests/actions/IOUTest/SplitTest.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2198,6 +2198,7 @@ describe('updateSplitTransactionsFromSplitExpensesFlow', () => {
21982198
{transactionID: splitTransactionID1, amount: amount / 2, created: DateUtils.getDBTime()},
21992199
{transactionID: splitTransactionID2, amount: amount / 2, created: DateUtils.getDBTime()},
22002200
],
2201+
splitExpensesTotal: undefined,
22012202
},
22022203
policyCategories: undefined,
22032204
policy: undefined,
@@ -2258,6 +2259,7 @@ describe('updateSplitTransactionsFromSplitExpensesFlow', () => {
22582259
reportID,
22592260
originalTransactionID: originalTransactionID ?? String(CONST.DEFAULT_NUMBER_ID),
22602261
splitExpenses: [{transactionID: splitTransactionID1, amount, created: DateUtils.getDBTime(), reportID: differentReportID}],
2262+
splitExpensesTotal: undefined,
22612263
},
22622264
policyCategories: undefined,
22632265
policy: undefined,
@@ -2421,6 +2423,7 @@ describe('updateSplitTransactionsFromSplitExpensesFlow', () => {
24212423
{transactionID: splitTransactionID1, amount: amount / 2, created: DateUtils.getDBTime()},
24222424
{transactionID: splitTransactionID2, amount: amount / 2, created: DateUtils.getDBTime()},
24232425
],
2426+
splitExpensesTotal: undefined,
24242427
},
24252428
policyCategories: undefined,
24262429
policy: undefined,
@@ -2528,6 +2531,7 @@ describe('updateSplitTransactionsFromSplitExpensesFlow', () => {
25282531
reportID,
25292532
originalTransactionID: originalTransactionID ?? String(CONST.DEFAULT_NUMBER_ID),
25302533
splitExpenses: [{transactionID: splitTransactionID1, amount, created: DateUtils.getDBTime()}],
2534+
splitExpensesTotal: undefined,
25312535
},
25322536
policyCategories: undefined,
25332537
policy: undefined,
@@ -2701,6 +2705,7 @@ describe('updateSplitTransactionsFromSplitExpensesFlow', () => {
27012705
reportID: reportID1,
27022706
originalTransactionID: originalTransaction.transactionID,
27032707
splitExpenses: [{transactionID: childTransaction.transactionID, amount: 10000, created: DateUtils.getDBTime()}],
2708+
splitExpensesTotal: undefined,
27042709
},
27052710
searchContext: {
27062711
currentSearchHash: -2,
@@ -2835,6 +2840,7 @@ describe('updateSplitTransactionsFromSplitExpensesFlow', () => {
28352840
reportID: reportID2,
28362841
originalTransactionID: originalTransaction.transactionID,
28372842
splitExpenses: [{transactionID: childTransaction.transactionID, amount: 10000, created: DateUtils.getDBTime()}],
2843+
splitExpensesTotal: undefined,
28382844
},
28392845
searchContext: {
28402846
currentSearchHash: -2,
@@ -3785,6 +3791,7 @@ describe('updateSplitTransactions', () => {
37853791
{transactionID: 'split-1', amount: amount / 2, description: 'Split 1', created: DateUtils.getDBTime()},
37863792
{transactionID: 'split-2', amount: amount / 2, description: 'Split 2', created: DateUtils.getDBTime()},
37873793
],
3794+
splitExpensesTotal: undefined,
37883795
},
37893796
searchContext: {currentSearchHash: -2},
37903797
policyCategories: undefined,
@@ -3915,6 +3922,7 @@ describe('updateSplitTransactions', () => {
39153922
{transactionID: 'offline-split-1', amount: amount / 2, description: 'Offline Split 1', created: DateUtils.getDBTime()},
39163923
{transactionID: 'offline-split-2', amount: amount / 2, description: 'Offline Split 2', created: DateUtils.getDBTime()},
39173924
],
3925+
splitExpensesTotal: undefined,
39183926
},
39193927
searchContext: {currentSearchHash: -2},
39203928
policyCategories: undefined,
@@ -4044,6 +4052,7 @@ describe('updateSplitTransactions', () => {
40444052
{transactionID: 'cat-tag-1', amount: amount / 2, description: 'Split 1', created: DateUtils.getDBTime(), category: testCategory, tags: [testTag]},
40454053
{transactionID: 'cat-tag-2', amount: amount / 2, description: 'Split 2', created: DateUtils.getDBTime(), category: testCategory, tags: [testTag]},
40464054
],
4055+
splitExpensesTotal: undefined,
40474056
},
40484057
searchContext: {currentSearchHash: -2},
40494058
policyCategories: undefined,
@@ -4220,6 +4229,7 @@ describe('updateSplitTransactions', () => {
42204229
description: `Split ${index + 1}`,
42214230
created: DateUtils.getDBTime(),
42224231
})),
4232+
splitExpensesTotal: undefined,
42234233
},
42244234
searchContext: {currentSearchHash: -2},
42254235
policyCategories: undefined,
@@ -4455,6 +4465,7 @@ describe('updateSplitTransactions', () => {
44554465
reportID: expenseReport.reportID,
44564466
originalTransactionID,
44574467
splitExpenses: [{transactionID: splitTransactionID1, reportID: remainingSplitTransaction?.reportID, amount, created: DateUtils.getDBTime()}],
4468+
splitExpensesTotal: undefined,
44584469
},
44594470
searchContext: {currentSearchHash: -2},
44604471
policyCategories: undefined,
@@ -4534,6 +4545,7 @@ describe('updateSplitTransactions', () => {
45344545
{transactionID: splitTransactionID1, amount: amount / 2, created: DateUtils.getDBTime()},
45354546
{transactionID: splitTransactionID2, amount: amount / 2, created: DateUtils.getDBTime()},
45364547
],
4548+
splitExpensesTotal: undefined,
45374549
},
45384550
searchContext: {currentSearchHash: -2},
45394551
policyCategories: undefined,

0 commit comments

Comments
 (0)