Skip to content

Commit 782a4db

Browse files
authored
Merge pull request #82391 from callstack-internal/fix/adhoc-naming
[NoQA] Fix adhoc builds names with new fingerprint
2 parents 317057c + a62f7f0 commit 782a4db

1 file changed

Lines changed: 18 additions & 4 deletions

File tree

.github/workflows/buildAdHoc.yml

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,13 @@ jobs:
137137
git checkout ${{ inputs.MOBILE_EXPENSIFY_REF }}
138138
echo "Building from https://github.com/Expensify/Mobile-Expensify/pull/${{ inputs.MOBILE_EXPENSIFY_PR }}"
139139
140+
- name: Compute custom build identifier
141+
id: computeIdentifier
142+
run: |
143+
APP_SHORT_SHA=$(git rev-parse --short HEAD)
144+
MOBILE_EXPENSIFY_SHORT_SHA=$(cd Mobile-Expensify && git rev-parse --short HEAD)
145+
echo "IDENTIFIER=${APP_SHORT_SHA}-${MOBILE_EXPENSIFY_SHORT_SHA}" >> "$GITHUB_OUTPUT"
146+
140147
- name: Configure MapBox SDK
141148
run: ./scripts/setup-mapbox-sdk.sh ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
142149

@@ -197,7 +204,7 @@ jobs:
197204

198205
- name: Rock Remote Build - Android
199206
id: rock-remote-build-android
200-
uses: callstackincubator/android@2177ac62cabe662aa49a2bc6f3154070705dd8f5
207+
uses: callstackincubator/android@561f4aa994a35aa9a2d7d913b562da65e5f02029
201208
env:
202209
GITHUB_TOKEN: ${{ github.token }}
203210
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
@@ -216,7 +223,7 @@ jobs:
216223
keystore-path: '../tools/buildtools/upload-key.keystore'
217224
comment-bot: false
218225
rock-build-extra-params: '--extra-params "-PreactNativeArchitectures=arm64-v8a,x86_64 --profile"'
219-
custom-ref: ${{ inputs.APP_REF }}
226+
custom-identifier: ${{ steps.computeIdentifier.outputs.IDENTIFIER }}
220227

221228
- name: Upload Gradle profile report
222229
if: always()
@@ -257,6 +264,13 @@ jobs:
257264
git checkout ${{ inputs.MOBILE_EXPENSIFY_REF }}
258265
echo "Building from https://github.com/Expensify/Mobile-Expensify/pull/${{ inputs.MOBILE_EXPENSIFY_PR }}"
259266
267+
- name: Compute custom build identifier
268+
id: computeIdentifier
269+
run: |
270+
APP_SHORT_SHA=$(git rev-parse --short HEAD)
271+
MOBILE_EXPENSIFY_SHORT_SHA=$(cd Mobile-Expensify && git rev-parse --short HEAD)
272+
echo "IDENTIFIER=${APP_SHORT_SHA}-${MOBILE_EXPENSIFY_SHORT_SHA}" >> "$GITHUB_OUTPUT"
273+
260274
- name: Configure MapBox SDK
261275
run: ./scripts/setup-mapbox-sdk.sh ${{ secrets.MAPBOX_SDK_DOWNLOAD_TOKEN }}
262276

@@ -321,7 +335,7 @@ jobs:
321335

322336
- name: Rock Remote Build - iOS
323337
id: rock-remote-build-ios
324-
uses: callstackincubator/ios@d638bd25c764655baeeced3232c692f1698cf72b
338+
uses: callstackincubator/ios@dd30f7e53eee2ea6a59509793d0a30fbb5c91216
325339
env:
326340
GITHUB_TOKEN: ${{ github.token }}
327341
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
@@ -349,7 +363,7 @@ jobs:
349363
}
350364
]
351365
comment-bot: false
352-
custom-ref: ${{ inputs.APP_REF }}
366+
custom-identifier: ${{ steps.computeIdentifier.outputs.IDENTIFIER }}
353367

354368
- name: Set artifact URL output
355369
id: set-artifact-url

0 commit comments

Comments
 (0)