Merge pull request #89141 from Expensify/rory-lint-quiet-default

[No QA] Default lint output to errors only via --quiet

Author: deetergp

contributingGuides/LINTING.md

@@ -14,12 +14,17 @@ npm run lint-changed
 # Lint specific files or directories:
 npm run lint -- src/components/Foo/index.tsx src/libs/bar.ts
 
+# Include grandfathered seatbelt warnings in the output:
+npm run lint -- --show-warnings
+
 # Continuously re-lint changed files as you edit:
 npm run lint-watch
 ```
 
 Prefer `npm run lint` (or `lint-changed` / `lint -- <files>`) over raw `npx eslint` invocations. Those wrappers increase the memory allocation to prevent OOM errors, and also include caching and concurrency flags for faster linting.
 
+By default the wrapper passes `--quiet` to ESLint so only blocking errors are printed — seatbelt-grandfathered violations (which CI does not fail on) are suppressed from the output but still evaluated against the baseline. Pass `--show-warnings` when you want to see them too, e.g. when paying down baselined errors.
+
 ## eslint-seatbelt
 We use [eslint-seatbelt](https://github.com/justjake/eslint-seatbelt) to manage known lint errors.
 

scripts/lint.sh

@@ -3,23 +3,38 @@
 # Run ESLint with the repo's standard flags (memory ceiling, shared content
 # cache, auto concurrency). Delegate target selection to the caller:
 #
-#   ./scripts/lint.sh                 -> lint the whole repo
-#   ./scripts/lint.sh src/foo.ts ...  -> lint just the given paths
+#   ./scripts/lint.sh                      -> lint the whole repo
+#   ./scripts/lint.sh src/foo.ts ...       -> lint just the given paths
+#   ./scripts/lint.sh --show-warnings ...  -> include grandfathered seatbelt warnings in the output
+#
+# By default we pass `--quiet` to ESLint so only blocking errors are printed.
+# eslint-seatbelt reclassifies grandfathered violations as warnings, so the
+# default output mirrors what CI cares about. Pass `--show-warnings` to
+# restore the full output (errors + warnings).
 
 set -euo pipefail
 
 # parse args
 USE_CACHE=true
+SHOW_WARNINGS=false
+PASSTHROUGH_ARGS=()
 for ARG in "$@"; do
-    if [[ "$ARG" == "--no-cache" ]]; then
-        USE_CACHE=false
-        break
-    fi
+    case "$ARG" in
+        --no-cache)
+            USE_CACHE=false
+            ;;
+        --show-warnings)
+            SHOW_WARNINGS=true
+            ;;
+        *)
+            PASSTHROUGH_ARGS+=("$ARG")
+            ;;
+    esac
 done
 
 # Preserve default behavior of linting the whole repo when no target is passed.
-if [[ "$#" -eq 0 ]]; then
-    set -- .
+if [[ "${#PASSTHROUGH_ARGS[@]}" -eq 0 ]]; then
+    PASSTHROUGH_ARGS=(.)
 fi
 
 # Build ESLint args
@@ -31,10 +46,13 @@ if [[ "$USE_CACHE" == "true" ]]; then
         --cache-strategy content
     )
 fi
+if [[ "$SHOW_WARNINGS" == "false" ]]; then
+    ESLINT_ARGS+=(--quiet)
+fi
 ESLINT_ARGS+=(
     --concurrency=auto
     --no-warn-ignored
-    "$@"
+    "${PASSTHROUGH_ARGS[@]}"
 )
 
 # Run ESLint with the repo's default memory ceiling and seatbelt behavior.