Merge pull request #88422 from callstack-internal/bulk-edit-tag-wrong-avaialble

fix: bulk edit, disable tags edit for non WS expenses

Author: marcaaron

src/pages/Search/SearchEditMultiple/SearchEditMultiplePage.tsx

@@ -25,7 +25,14 @@ import ONYXKEYS from '@src/ONYXKEYS';
 import ROUTES from '@src/ROUTES';
 import type {Route} from '@src/ROUTES';
 import type {TransactionChanges} from '@src/types/onyx/Transaction';
-import {getTransactionEditContext, isBulkEditTaxTrackingEnabled, withSnapshotReportActions, withSnapshotReports, withSnapshotTransactions} from './SearchEditMultipleUtils';
+import {
+    areAllTransactionsExpenseCompatible,
+    getTransactionEditContext,
+    isBulkEditTaxTrackingEnabled,
+    withSnapshotReportActions,
+    withSnapshotReports,
+    withSnapshotTransactions,
+} from './SearchEditMultipleUtils';
 
 function SearchEditMultiplePage() {
     const {translate} = useLocalize();
@@ -102,14 +109,9 @@ function SearchEditMultiplePage() {
     const policyTagLists = getTagLists(policyTags);
 
     const isTaxTrackingEnabled = isBulkEditTaxTrackingEnabled(selectedTransactionContexts, policy, hasPerDiemOrTimeTransaction);
-    const areSelectedTransactionsExpenses = selectedTransactionContexts.every(({transaction, report}) => {
-        if (!transaction.reportID || transaction.reportID === CONST.REPORT.UNREPORTED_REPORT_ID) {
-            return true;
-        }
-        return !isIOUReport(report);
-    });
+    const areSelectedTransactionsExpenses = areAllTransactionsExpenseCompatible(selectedTransactionContexts);
     const areCategoriesEnabled = areSelectedTransactionsExpenses && !!policy?.areCategoriesEnabled && hasEnabledOptions(policyCategories ?? {});
-    const areTagsEnabled = !!policy?.areTagsEnabled && hasEnabledTags(policyTagLists);
+    const areTagsEnabled = areSelectedTransactionsExpenses && !!policy?.areTagsEnabled && hasEnabledTags(policyTagLists);
 
     useEffect(() => {
         return () => {

src/pages/Search/SearchEditMultiple/SearchEditMultipleUtils.ts

@@ -1,5 +1,6 @@
 import type {OnyxCollection, OnyxEntry} from 'react-native-onyx';
 import {getIOUActionForTransactionID} from '@libs/ReportActionsUtils';
+import {isIOUReport} from '@libs/ReportUtils';
 import {getTagArrayFromName} from '@libs/TransactionUtils';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
@@ -61,6 +62,19 @@ function getTransactionEditContext(
     return {transaction, report, reportAction, transactionPolicy};
 }
 
+/**
+ * Category/Tag/Tax only apply to expense/invoice reports and unreported (track) expenses.
+ * Returns true only when every selected transaction is eligible.
+ */
+function areAllTransactionsExpenseCompatible(selectedTransactionContexts: Array<{transaction: Transaction; report: OnyxEntry<Report>}>): boolean {
+    return selectedTransactionContexts.every(({transaction, report}) => {
+        if (!transaction.reportID || transaction.reportID === CONST.REPORT.UNREPORTED_REPORT_ID) {
+            return true;
+        }
+        return !isIOUReport(report);
+    });
+}
+
 /**
  * Reported expenses check their own workspace policy; unreported (track) expenses fall back to
  * the bulk-edit workspace policy because they have no report to resolve a per-transaction policy from.
@@ -134,4 +148,12 @@ function withSnapshotReports(onyxReports: OnyxCollection<Report> | undefined, sn
     return merged;
 }
 
-export {getCommonDependentTag, getTransactionEditContext, isBulkEditTaxTrackingEnabled, withSnapshotTransactions, withSnapshotReportActions, withSnapshotReports};
+export {
+    areAllTransactionsExpenseCompatible,
+    getCommonDependentTag,
+    getTransactionEditContext,
+    isBulkEditTaxTrackingEnabled,
+    withSnapshotTransactions,
+    withSnapshotReportActions,
+    withSnapshotReports,
+};

tests/unit/SearchEditMultipleUtilsTest.ts

@@ -2,7 +2,12 @@ import {getSearchBulkEditPolicyID} from '@libs/SearchUIUtils';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 import type {Policy, Report, SearchResults, Transaction} from '@src/types/onyx';
-import {isBulkEditTaxTrackingEnabled, withSnapshotReports, withSnapshotTransactions} from '../../src/pages/Search/SearchEditMultiple/SearchEditMultipleUtils';
+import {
+    areAllTransactionsExpenseCompatible,
+    isBulkEditTaxTrackingEnabled,
+    withSnapshotReports,
+    withSnapshotTransactions,
+} from '../../src/pages/Search/SearchEditMultiple/SearchEditMultipleUtils';
 
 const POLICY_A = 'policyA';
 const POLICY_B = 'policyB';
@@ -133,6 +138,50 @@ describe('SearchEditMultipleUtils', () => {
         });
     });
 
+    describe('areAllTransactionsExpenseCompatible', () => {
+        const expenseReport = {reportID: 'expenseReport1', type: CONST.REPORT.TYPE.EXPENSE} as Report;
+        const iouReport = {reportID: 'iouReport1', type: CONST.REPORT.TYPE.IOU} as Report;
+        const invoiceReport = {reportID: 'invoiceReport1', type: CONST.REPORT.TYPE.INVOICE} as Report;
+
+        it('returns true when every reported transaction is on an expense report', () => {
+            const contexts = [
+                {transaction: makeTransaction(TRANSACTION_ID_1, 'expenseReport1'), report: expenseReport},
+                {transaction: makeTransaction(TRANSACTION_ID_2, 'expenseReport1'), report: expenseReport},
+            ];
+            expect(areAllTransactionsExpenseCompatible(contexts)).toBe(true);
+        });
+
+        it('returns true for unreported (track) transactions', () => {
+            const contexts = [{transaction: makeTransaction(TRANSACTION_ID_1, CONST.REPORT.UNREPORTED_REPORT_ID), report: undefined}];
+            expect(areAllTransactionsExpenseCompatible(contexts)).toBe(true);
+        });
+
+        it('returns false when any reported transaction is on an IOU report', () => {
+            const contexts = [
+                {transaction: makeTransaction(TRANSACTION_ID_1, 'expenseReport1'), report: expenseReport},
+                {transaction: makeTransaction(TRANSACTION_ID_2, 'iouReport1'), report: iouReport},
+            ];
+            expect(areAllTransactionsExpenseCompatible(contexts)).toBe(false);
+        });
+
+        it('returns false when a mix of unreported and IOU transactions is selected', () => {
+            const contexts = [
+                {transaction: makeTransaction(TRANSACTION_ID_1, CONST.REPORT.UNREPORTED_REPORT_ID), report: undefined},
+                {transaction: makeTransaction(TRANSACTION_ID_2, 'iouReport1'), report: iouReport},
+            ];
+            expect(areAllTransactionsExpenseCompatible(contexts)).toBe(false);
+        });
+
+        it('returns true for invoice reports (not IOU)', () => {
+            const contexts = [{transaction: makeTransaction(TRANSACTION_ID_1, 'invoiceReport1'), report: invoiceReport}];
+            expect(areAllTransactionsExpenseCompatible(contexts)).toBe(true);
+        });
+
+        it('returns true for an empty selection', () => {
+            expect(areAllTransactionsExpenseCompatible([])).toBe(true);
+        });
+    });
+
     describe('isBulkEditTaxTrackingEnabled', () => {
         const taxEnabledPolicy = {id: POLICY_A, tax: {trackingEnabled: true}} as unknown as Policy;
         const taxDisabledPolicy = {id: POLICY_B, tax: {trackingEnabled: false}} as unknown as Policy;