You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Use exact combined feed key in linkedPolicyIDs predicate tests
Addresses Copilot review comment on PR #88359
(#88359 (comment)):
the four new tests previously matched feeds via key.includes(oauthFeed)
and gated on result.current[1].status === 'loaded' (an Onyx implementation
detail). Now compute the exact combined feed key with
getCardFeedWithDomainID and put toHaveProperty([combinedFeedKey]) inside
waitFor for the three positive cases, so the wait resolves on the actual
expectation. The negative case keeps the loaded-status gate before
asserting absence to avoid a vacuous pass while Onyx is still hydrating.
Verified locally:
- All 7 tests pass on main.
- Reverting the predicate to its pre-#88136 form still fails the two
linkedPolicyIDs: [''] / [] regression tests.
Made-with: Cursor
0 commit comments