Skip to content

Commit ae2de90

Browse files
committed
fix:74750: Added copyable props to all places where copyValue was passed without it
1 parent f05bf58 commit ae2de90

4 files changed

Lines changed: 15 additions & 2 deletions

File tree

src/pages/Travel/CarTripDetails.tsx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ function CarTripDetails({reservation, personalDetails}: CarTripDetailsProps) {
3434

3535
const displayName = personalDetails?.displayName ?? reservation.travelerPersonalInfo?.name;
3636

37+
const reservationConfirmation = reservation.confirmations?.at(0)?.value ?? reservation?.reservationID;
38+
3739
return (
3840
<>
3941
<Text style={[styles.textHeadlineH1, styles.mh5, styles.mv3]}>{reservation.vendor}</Text>
@@ -77,8 +79,10 @@ function CarTripDetails({reservation, personalDetails}: CarTripDetailsProps) {
7779
{!!reservation.reservationID && (
7880
<MenuItemWithTopDescription
7981
description={translate('travel.carDetails.confirmation')}
80-
title={reservation.confirmations?.at(0)?.value ?? reservation.reservationID}
81-
copyValue={reservation.confirmations?.at(0)?.value ?? reservation.reservationID}
82+
title={reservationConfirmation}
83+
interactive={false}
84+
copyValue={reservationConfirmation}
85+
copyable={!!reservationConfirmation?.length}
8286
/>
8387
)}
8488
{!!displayName && (

src/pages/Travel/HotelTripDetails.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ function HotelTripDetails({reservation, personalDetails}: HotelTripDetailsProps)
4646
numberOfLinesTitle={2}
4747
pressableTestID={CONST.RESERVATION_ADDRESS_TEST_ID}
4848
copyValue={reservation.start.address}
49+
copyable={!!reservation.start.address?.length}
50+
interactive={false}
4951
/>
5052
<MenuItemWithTopDescription
5153
description={translate('travel.hotelDetails.checkIn')}
@@ -78,6 +80,8 @@ function HotelTripDetails({reservation, personalDetails}: HotelTripDetailsProps)
7880
description={translate('travel.hotelDetails.confirmation')}
7981
title={reservation.confirmations?.at(0)?.value}
8082
copyValue={reservation.confirmations?.at(0)?.value}
83+
copyable={!!reservation.confirmations?.at(0)?.value?.length}
84+
interactive={false}
8185
/>
8286
)}
8387
{!!displayName && (

src/pages/Travel/TrainTripDetails.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ function TrainTripDetails({reservation, personalDetails}: TrainTripDetailsProps)
3838
description={`${translate('travel.train')} ${trainDuration ? `${CONST.DOT_SEPARATOR} ${trainDuration}` : ''}`}
3939
title={reservation.route?.name}
4040
copyValue={reservation.route?.name}
41+
copyable={!!reservation.route?.name?.length}
42+
interactive={false}
4143
/>
4244
<MenuItemWithTopDescription
4345
description={translate('common.date')}
@@ -87,6 +89,8 @@ function TrainTripDetails({reservation, personalDetails}: TrainTripDetailsProps)
8789
description={translate('travel.trainDetails.confirmation')}
8890
title={reservation.confirmations?.at(0)?.value}
8991
copyValue={reservation.confirmations?.at(0)?.value}
92+
interactive={false}
93+
copyable={!!reservation.confirmations?.at(0)?.value?.length}
9094
/>
9195
)}
9296

src/pages/settings/Wallet/WalletPage/WalletPage.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -475,6 +475,7 @@ function WalletPage({shouldListenForResize = false}: WalletPageProps) {
475475
interactive={false}
476476
wrapperStyle={styles.sectionMenuItemTopDescription}
477477
copyValue={convertToDisplayString(userWallet?.currentBalance ?? 0)}
478+
copyable
478479
/>
479480
</OfflineWithFeedback>
480481
)}

0 commit comments

Comments
 (0)