Skip to content

Commit b1f17b8

Browse files
MelvinBot{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"}
andcommitted
Fix splitExpensesTotal to use all children before filtering deleted ones
splitExpensesTotal was computed from remainingSplitExpenses (already filtered to exclude deleted transactions), making changesInReportTotal = sum(remaining) - sum(remaining) = 0, so the report total never updated. Now compute it from allChildTransactions (before filtering) so the delta correctly reflects the removed amounts. Co-authored-by: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"} <{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"}@users.noreply.github.com>
1 parent f162925 commit b1f17b8

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

src/hooks/useDeleteTransactions.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,9 +111,8 @@ function useDeleteTransactions({report, reportActions, policy}: UseDeleteTransac
111111

112112
for (const transactionID of Object.keys(splitTransactionsByOriginalTransactionID)) {
113113
const splitIDs = new Set((splitTransactionsByOriginalTransactionID[transactionID] ?? []).map((transaction) => transaction.transactionID));
114-
const childTransactions = getChildTransactions(allTransactions, allReports, transactionID).filter(
115-
(transaction) => !splitIDs.has(transaction?.transactionID ?? String(CONST.DEFAULT_NUMBER_ID)),
116-
);
114+
const allChildTransactions = getChildTransactions(allTransactions, allReports, transactionID);
115+
const childTransactions = allChildTransactions.filter((transaction) => !splitIDs.has(transaction?.transactionID ?? String(CONST.DEFAULT_NUMBER_ID)));
117116

118117
if (childTransactions.length === 0) {
119118
nonSplitTransactions.push(...splitTransactionsByOriginalTransactionID[transactionID]);
@@ -158,7 +157,10 @@ function useDeleteTransactions({report, reportActions, policy}: UseDeleteTransac
158157
reportID: report?.reportID ?? String(CONST.DEFAULT_NUMBER_ID),
159158
originalTransactionID: transactionID,
160159
splitExpenses: remainingSplitExpenses,
161-
splitExpensesTotal: remainingSplitExpenses.reduce((total, item) => total + item.amount, 0),
160+
splitExpensesTotal: allChildTransactions.reduce((total, childTransaction) => {
161+
const transactionReport = allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${childTransaction?.reportID}`];
162+
return total + initSplitExpenseItemData(childTransaction, transactionReport).amount;
163+
}, 0),
162164
},
163165
searchContext: {
164166
currentSearchHash,

0 commit comments

Comments
 (0)