Update TransitionTracker to handle callback errors and adjust keyboard dismiss logic to start transition before subscribing to listeners

Author: collectioneur

src/libs/Navigation/TransitionTracker.ts

@@ -1,3 +1,4 @@
+import Log from '@libs/Log';
 import CONST from '@src/CONST';
 
 type CancelHandle = {cancel: () => void};
@@ -28,12 +29,17 @@ let promiseForNextTransitionStart = new Promise<void>((resolve) => {
 
 /**
  * Invokes and removes all pending callbacks.
+ * Each callback is isolated so that one exception does not prevent the rest from running.
  */
 function flushCallbacks(): void {
     const callbacks = pendingCallbacks;
     pendingCallbacks = [];
     for (const callback of callbacks) {
-        callback();
+        try {
+            callback();
+        } catch (error) {
+            Log.warn('[TransitionTracker] A pending callback threw an error', {error});
+        }
     }
 }
 

src/utils/keyboard/index.android.ts

@@ -32,13 +32,12 @@ const dismiss = (options?: DismissKeyboardOptions): Promise<void> => {
             return;
         }
 
+        TransitionTracker.startTransition();
         const subscription = Keyboard.addListener('keyboardDidHide', () => {
             resolve();
             TransitionTracker.endTransition();
             subscription.remove();
         });
-
-        TransitionTracker.startTransition();
         Keyboard.dismiss();
 
         if (options?.afterTransition) {

src/utils/keyboard/index.ts

@@ -31,13 +31,12 @@ const dismiss = (options?: DismissKeyboardOptions): Promise<void> => {
             return;
         }
 
+        TransitionTracker.startTransition();
         const subscription = Keyboard.addListener('keyboardDidHide', () => {
             resolve();
             TransitionTracker.endTransition();
             subscription.remove();
         });
-
-        TransitionTracker.startTransition();
         Keyboard.dismiss();
 
         if (options?.afterTransition) {

src/utils/keyboard/index.website.ts

@@ -64,9 +64,8 @@ const dismiss = (options?: DismissKeyboardOptions): Promise<void> => {
             return resolve();
         };
 
-        window.visualViewport?.addEventListener('resize', handleDismissResize);
-
         TransitionTracker.startTransition();
+        window.visualViewport?.addEventListener('resize', handleDismissResize);
         Keyboard.dismiss();
 
         if (options?.afterTransition) {