Merge pull request #91155 from software-mansion-labs/@GCyganek/gps/fix-android-gps-crashes-in-bg

aldo-expensify · web-flow · commit d6dcf42d0f78 · 2026-05-27T13:39:26.000-07:00
Fix GPS crashes in the background on Android
diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/main/AndroidManifest.xml
@@ -9,6 +9,7 @@
     <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
     <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
     <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
+    <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
     <uses-permission android:name="android.permission.FOREGROUND_SERVICE_LOCATION" />
     <uses-permission android:name="android.permission.HIGH_SAMPLING_RATE_SENSORS"/>
     <uses-permission android:name="android.permission.ACCESS_BACKGROUND_LOCATION"/>
@@ -31,7 +32,8 @@
             android:exported="false" />
 
         <service
-            android:name=".customairshipextender.GpsTripService"
+            android:name=".GpsTripService"
+            android:foregroundServiceType="location"
             android:stopWithTask="false"
             android:exported="false" />
 
diff --git a/android/app/src/main/java/com/expensify/chat/ExpensifyAppPackage.java b/android/app/src/main/java/com/expensify/chat/ExpensifyAppPackage.java
@@ -23,6 +23,7 @@ public List<NativeModule> createNativeModules(
 
         modules.add(new ShareActionHandlerModule(reactContext));
         modules.add(new AppStateTrackerModule(reactContext));
+        modules.add(new GpsTripServiceModule(reactContext));
 
         return modules;
     }
diff --git a/android/app/src/main/java/com/expensify/chat/GpsTripService.kt b/android/app/src/main/java/com/expensify/chat/GpsTripService.kt
@@ -0,0 +1,100 @@
+package com.expensify.chat
+
+import android.app.NotificationChannel
+import android.app.NotificationManager
+import android.app.PendingIntent
+import android.app.Service
+import android.content.Intent
+import android.content.pm.ServiceInfo
+import android.net.Uri
+import android.os.Build
+import android.os.IBinder
+import android.util.Log
+import androidx.core.app.NotificationCompat
+import com.expensify.chat.R
+
+class GpsTripService : Service() {
+
+    override fun onBind(intent: Intent?): IBinder? = null
+
+    override fun onStartCommand(intent: Intent?, flags: Int, startId: Int): Int {
+        val title = intent?.getStringExtra(EXTRA_TITLE) ?: "GPS tracking in progress"
+        val body = intent?.getStringExtra(EXTRA_BODY) ?: "Go to the app to finish"
+        val deepLink = intent?.getStringExtra(EXTRA_DEEP_LINK)
+
+        ensureNotificationChannel()
+
+        val builder = NotificationCompat.Builder(this, CHANNEL_ID)
+            .setSmallIcon(R.drawable.ic_notification)
+            .setContentTitle(title)
+            .setContentText(body)
+            .setOngoing(true)
+            .setPriority(NotificationCompat.PRIORITY_HIGH)
+            .setCategory(NotificationCompat.CATEGORY_SERVICE)
+            .setAutoCancel(false)
+
+        if (!deepLink.isNullOrEmpty()) {
+            // deepLink example: 'create/create/start/1/102024159558962/distance-new/distance-gps'
+            // we need to add the prefix to make sure it opens correctly 
+            val tapIntent = Intent(Intent.ACTION_VIEW, Uri.parse("new-expensify://$deepLink")).apply {
+                this.flags = Intent.FLAG_ACTIVITY_NEW_TASK or Intent.FLAG_ACTIVITY_SINGLE_TOP
+            }
+            val pendingIntent = PendingIntent.getActivity(
+                this,
+                0,
+                tapIntent,
+                PendingIntent.FLAG_UPDATE_CURRENT or PendingIntent.FLAG_IMMUTABLE
+            )
+            builder.setContentIntent(pendingIntent)
+        }
+
+        try {
+            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
+                startForeground(NOTIFICATION_ID, builder.build(), ServiceInfo.FOREGROUND_SERVICE_TYPE_LOCATION)
+            } else {
+                startForeground(NOTIFICATION_ID, builder.build())
+            }
+        } catch (e: Exception) {
+            Log.e(TAG, "Failed to start foreground", e)
+            stopSelf()
+            return START_NOT_STICKY
+        }
+
+        return START_STICKY
+    }
+
+    override fun onTaskRemoved(rootIntent: Intent?) {
+        try {
+            stopForeground(STOP_FOREGROUND_REMOVE)
+        } catch (_: Exception) {}
+        stopSelf()
+        super.onTaskRemoved(rootIntent)
+    }
+
+    private fun ensureNotificationChannel() {
+        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.O) return
+
+        val manager = getSystemService(NotificationManager::class.java)
+        if (manager.getNotificationChannel(CHANNEL_ID) != null) return
+
+        val channel = NotificationChannel(
+            CHANNEL_ID,
+            CHANNEL_NAME,
+            NotificationManager.IMPORTANCE_HIGH
+        ).apply {
+            description = CHANNEL_DESCRIPTION
+        }
+        manager.createNotificationChannel(channel)
+    }
+
+    companion object {
+        private const val TAG = "GpsTripService"
+        const val CHANNEL_ID = "gps_foreground_service_channel"
+        const val CHANNEL_NAME = "GPS Trip Tracking"
+        const val CHANNEL_DESCRIPTION = "Shows when a GPS distance trip is being tracked"
+        const val NOTIFICATION_ID = 90001
+        const val EXTRA_TITLE = "gps_title"
+        const val EXTRA_BODY = "gps_body"
+        const val EXTRA_DEEP_LINK = "gps_deep_link"
+    }
+}
diff --git a/android/app/src/main/java/com/expensify/chat/GpsTripServiceModule.kt b/android/app/src/main/java/com/expensify/chat/GpsTripServiceModule.kt
@@ -0,0 +1,44 @@
+package com.expensify.chat
+
+import android.content.Intent
+import android.os.Build
+import android.util.Log
+import com.facebook.react.bridge.ReactApplicationContext
+import com.facebook.react.bridge.ReactContextBaseJavaModule
+import com.facebook.react.bridge.ReactMethod
+
+class GpsTripServiceModule(reactContext: ReactApplicationContext) :
+    ReactContextBaseJavaModule(reactContext) {
+
+    override fun getName(): String = "GpsTripServiceModule"
+
+    @ReactMethod
+    fun startService(title: String, body: String, deepLink: String) {
+        val context = reactApplicationContext
+        val intent = Intent(context, GpsTripService::class.java).apply {
+            putExtra(GpsTripService.EXTRA_TITLE, title)
+            putExtra(GpsTripService.EXTRA_BODY, body)
+            putExtra(GpsTripService.EXTRA_DEEP_LINK, deepLink)
+        }
+
+        try {
+            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
+                context.startForegroundService(intent)
+            } else {
+                context.startService(intent)
+            }
+        } catch (e: Exception) {
+            Log.e(TAG, "Failed to start GPS trip service", e)
+        }
+    }
+
+    @ReactMethod
+    fun stopService() {
+        val context = reactApplicationContext
+        context.stopService(Intent(context, GpsTripService::class.java))
+    }
+
+    companion object {
+        private const val TAG = "GpsTripServiceModule"
+    }
+}
diff --git a/android/app/src/main/java/com/expensify/chat/customairshipextender/CustomAirshipExtender.java b/android/app/src/main/java/com/expensify/chat/customairshipextender/CustomAirshipExtender.java
@@ -5,7 +5,6 @@
 import com.urbanairship.UAirship;
 import com.urbanairship.push.NotificationListener;
 import com.urbanairship.push.PushManager;
-import com.urbanairship.liveupdate.LiveUpdateManager;
 import com.urbanairship.reactnative.AirshipExtender;
 
 public class CustomAirshipExtender implements AirshipExtender {
@@ -15,7 +14,5 @@ public void onAirshipReady(@NonNull Context context, @NonNull UAirship airship)
 
         CustomNotificationProvider notificationProvider = new CustomNotificationProvider(context, airship.getAirshipConfigOptions());
         pushManager.setNotificationProvider(notificationProvider);
-
-        LiveUpdateManager.shared().register(GpsLiveUpdateHandler.TYPE, new GpsLiveUpdateHandler());
     }
 }
diff --git a/android/app/src/main/java/com/expensify/chat/customairshipextender/GpsLiveUpdateHandler.kt b/android/app/src/main/java/com/expensify/chat/customairshipextender/GpsLiveUpdateHandler.kt
diff --git a/android/app/src/main/java/com/expensify/chat/customairshipextender/GpsTripService.kt b/android/app/src/main/java/com/expensify/chat/customairshipextender/GpsTripService.kt
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -135,7 +135,7 @@
     "expo-font": "14.0.8",
     "expo-image": "55.0.3",
     "expo-image-manipulator": "55.0.2",
-    "expo-location": "55.0.3",
+    "expo-location": "55.1.10",
     "expo-modules-core": "55.0.25",
     "expo-store-review": "~9.0.8",
     "expo-task-manager": "55.0.2",
diff --git a/src/components/GPSTripStateChecker/index.native.tsx b/src/components/GPSTripStateChecker/index.native.tsx
@@ -43,7 +43,6 @@ function GPSTripStateChecker() {
         }
 
         handleGpsTripInProgressOnAppRestart();
-        checkAndCleanGpsNotification();
 
         return () => {
             hasStartedLocationUpdatesAsync(BACKGROUND_LOCATION_TRACKING_TASK_NAME).then((isRunning) => {
diff --git a/src/pages/iou/request/step/IOURequestStepDistanceGPS/GPSNotifications/index.android.ts b/src/pages/iou/request/step/IOURequestStepDistanceGPS/GPSNotifications/index.android.ts
@@ -1,45 +1,24 @@
-import Airship from '@ua/react-native-airship';
+import {NativeModules} from 'react-native';
 import type {LocalizedTranslate} from '@components/LocaleContextProvider';
 import CONST from '@src/CONST';
 import ROUTES from '@src/ROUTES';
 import type {Unit} from '@src/types/onyx/Policy';
 
-const LIVE_UPDATE_NAME = 'gps_live_update';
-const LIVE_UPDATE_TYPE = 'gps_trip_notification';
-
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 function startGpsTripNotification(translate: LocalizedTranslate, reportID: string, unit: Unit, distanceInMeters?: number) {
     const title = translate('gps.notification.title');
     const body = translate('gps.notification.body');
     const deepLink = ROUTES.DISTANCE_REQUEST_CREATE_TAB_GPS.getRoute(CONST.IOU.ACTION.CREATE, CONST.IOU.TYPE.CREATE, CONST.IOU.OPTIMISTIC_TRANSACTION_ID, reportID);
 
-    Airship.android.liveUpdateManager
-        .start({
-            name: LIVE_UPDATE_NAME,
-            type: LIVE_UPDATE_TYPE,
-            content: {title, body, deepLink},
-        })
-        .catch((error: unknown) => console.error('[GPS Live Update] Failed to start', error));
+    NativeModules.GpsTripServiceModule.startService(title, body, deepLink);
 }
 
 function stopGpsTripNotification() {
-    Airship.android.liveUpdateManager.end({name: LIVE_UPDATE_NAME}).catch((error: unknown) => console.error('[GPS Live Update] Failed to end', error));
+    NativeModules.GpsTripServiceModule.stopService();
 }
 
-async function checkAndCleanGpsNotification() {
-    try {
-        const liveUpdates = await Airship.android.liveUpdateManager.listAll();
-
-        for (const liveUpdate of liveUpdates) {
-            if (liveUpdate.name !== LIVE_UPDATE_NAME) {
-                continue;
-            }
-
-            stopGpsTripNotification();
-        }
-    } catch (error) {
-        console.error('[GPS Live Update] Failed to check live updates', error);
-    }
+function checkAndCleanGpsNotification() {
+    NativeModules.GpsTripServiceModule.stopService();
 }
 
 function shouldUpdateGpsNotificationUnit() {
diff --git a/src/types/modules/react-native.d.ts b/src/types/modules/react-native.d.ts

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ public List<NativeModule> createNativeModules(`
`23`	`23`
`24`	`24`	`modules.add(new ShareActionHandlerModule(reactContext));`
`25`	`25`	`modules.add(new AppStateTrackerModule(reactContext));`
	`26`	`+ modules.add(new GpsTripServiceModule(reactContext));`
`26`	`27`
`27`	`28`	`return modules;`
`28`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,6 @@`
`5`	`5`	`import com.urbanairship.UAirship;`
`6`	`6`	`import com.urbanairship.push.NotificationListener;`
`7`	`7`	`import com.urbanairship.push.PushManager;`
`8`		`-import com.urbanairship.liveupdate.LiveUpdateManager;`
`9`	`8`	`import com.urbanairship.reactnative.AirshipExtender;`
`10`	`9`
`11`	`10`	`public class CustomAirshipExtender implements AirshipExtender {`
`@@ -15,7 +14,5 @@ public void onAirshipReady(@NonNull Context context, @NonNull UAirship airship)`
`15`	`14`
`16`	`15`	`CustomNotificationProvider notificationProvider = new CustomNotificationProvider(context, airship.getAirshipConfigOptions());`
`17`	`16`	`pushManager.setNotificationProvider(notificationProvider);`
`18`		`-`
`19`		`- LiveUpdateManager.shared().register(GpsLiveUpdateHandler.TYPE, new GpsLiveUpdateHandler());`
`20`	`17`	`}`
`21`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,6 @@ function GPSTripStateChecker() {`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`handleGpsTripInProgressOnAppRestart();`
`46`		`- checkAndCleanGpsNotification();`
`47`	`46`
`48`	`47`	`return () => {`
`49`	`48`	`hasStartedLocationUpdatesAsync(BACKGROUND_LOCATION_TRACKING_TASK_NAME).then((isRunning) => {`