Skip to content

Commit eb88081

Browse files
authored
Merge pull request #87893 from software-mansion-labs/jakubstec/fix-receipt-is-hidden-on-confirm-page-landscape
2 parents 65ad160 + 6a06c2e commit eb88081

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

src/components/MoneyRequestConfirmationList.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import type {OnyxEntry} from 'react-native-onyx';
55
import {useCurrencyListActions} from '@hooks/useCurrencyList';
66
import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails';
77
import useDebouncedState from '@hooks/useDebouncedState';
8+
import useIsInLandscapeMode from '@hooks/useIsInLandscapeMode';
89
import useLocalize from '@hooks/useLocalize';
910
import {MouseProvider} from '@hooks/useMouseContext';
1011
import useOnyx from '@hooks/useOnyx';
@@ -247,6 +248,7 @@ function MoneyRequestConfirmationList({
247248
const isNewManualExpenseFlowEnabled = isBetaEnabled(CONST.BETAS.NEW_MANUAL_EXPENSE_FLOW);
248249
const {isDelegateAccessRestricted} = useDelegateNoAccessState();
249250
const {showDelegateNoAccessModal} = useDelegateNoAccessActions();
251+
const isInLandscapeMode = useIsInLandscapeMode();
250252

251253
const isTestReceipt = useMemo(() => {
252254
return transaction?.receipt?.isTestReceipt ?? false;
@@ -1050,7 +1052,7 @@ function MoneyRequestConfirmationList({
10501052
isLoadingReceipt,
10511053
]);
10521054

1053-
const isCompactMode = useMemo(() => !showMoreFields && isScanRequest, [isScanRequest, showMoreFields]);
1055+
const isCompactMode = useMemo(() => !showMoreFields && isScanRequest && !isInLandscapeMode, [isScanRequest, showMoreFields, isInLandscapeMode]);
10541056
const selectionListStyle = useMemo(
10551057
() => ({
10561058
containerStyle: [styles.flexBasisAuto],

src/components/MoneyRequestConfirmationListFooter.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import {View} from 'react-native';
44
import type {LayoutChangeEvent} from 'react-native';
55
import type {OnyxEntry} from 'react-native-onyx';
66
import type {ValueOf} from 'type-fest';
7+
import useIsInLandscapeMode from '@hooks/useIsInLandscapeMode';
78
import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset';
89
import useLocalize from '@hooks/useLocalize';
910
import useLocalReceiptThumbnail from '@hooks/useLocalReceiptThumbnail';
@@ -278,6 +279,7 @@ function MoneyRequestConfirmationListFooter({
278279
const theme = useTheme();
279280
const {translate} = useLocalize();
280281
const {windowWidth} = useWindowDimensions();
282+
const isInLandscapeMode = useIsInLandscapeMode();
281283

282284
const {isBetaEnabled} = usePermissions();
283285
const isNewManualExpenseFlowEnabled = isBetaEnabled(CONST.BETAS.NEW_MANUAL_EXPENSE_FLOW);
@@ -627,7 +629,7 @@ function MoneyRequestConfirmationListFooter({
627629
];
628630

629631
// Compact mode / receipt logic
630-
const isCompactMode = !showMoreFields && isScan;
632+
const isCompactMode = !showMoreFields && isScan && !isInLandscapeMode;
631633
const [receiptAspectRatio, setReceiptAspectRatio] = useState<number | null>(null);
632634
const [compactReceiptContainerWidth, setCompactReceiptContainerWidth] = useState(0);
633635
const hasEndedReceiptLoadSpan = useRef(false);

0 commit comments

Comments
 (0)