Merge pull request #88359 from Expensify/vit-fix-domain-feed-predicate

Add useCardFeeds regression tests for empty linkedPolicyIDs

Author: nkuoch

tests/unit/hooks/useCardFeeds.test.ts

@@ -2,6 +2,7 @@
 import {renderHook, waitFor} from '@testing-library/react-native';
 import Onyx from 'react-native-onyx';
 import useCardFeeds from '@hooks/useCardFeeds';
+import {getCardFeedWithDomainID} from '@libs/CardUtils';
 import CONST from '@src/CONST';
 import ONYXKEYS from '@src/ONYXKEYS';
 import waitForBatchedUpdates from '../../utils/waitForBatchedUpdates';
@@ -109,4 +110,67 @@ describe('useCardFeeds', () => {
             });
         });
     });
+
+    describe('linkedPolicyIDs predicate filtering', () => {
+        const combinedFeedKey = getCardFeedWithDomainID(oauthFeed, domainID);
+
+        const setupDomainFeed = async (companyCardSettings: {preferredPolicy: string; linkedPolicyIDs?: string[]}) => {
+            await Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {workspaceAccountID: 0});
+            await Onyx.merge(`${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER}${domainID}`, {
+                settings: {
+                    companyCards: {
+                        [oauthFeed]: {...companyCardSettings, liabilityType: 'corporate'},
+                    },
+                    oAuthAccountDetails: {
+                        [oauthFeed]: {credentials: 'xxxx', expiration: 9999999999, accountList: ['Card 1']},
+                    },
+                },
+            });
+            await Onyx.merge(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${domainID}_${oauthFeed}`, {
+                '123': {cardID: 123, cardName: 'Card 1'},
+            });
+            await waitForBatchedUpdates();
+        };
+
+        it('includes domain feeds when linkedPolicyIDs contains only an empty string and preferredPolicy matches', async () => {
+            await setupDomainFeed({preferredPolicy: policyID, linkedPolicyIDs: ['']});
+
+            const {result} = renderHook(() => useCardFeeds(policyID));
+            await waitForBatchedUpdates();
+
+            // The combined feed key contains '.', so wrap it in an array to disable
+            // jest's nested-path interpretation in toHaveProperty.
+            await waitFor(() => expect(result.current[0]).toHaveProperty([combinedFeedKey]));
+        });
+
+        it('includes domain feeds when linkedPolicyIDs is an empty array and preferredPolicy matches', async () => {
+            await setupDomainFeed({preferredPolicy: policyID, linkedPolicyIDs: []});
+
+            const {result} = renderHook(() => useCardFeeds(policyID));
+            await waitForBatchedUpdates();
+
+            await waitFor(() => expect(result.current[0]).toHaveProperty([combinedFeedKey]));
+        });
+
+        it('excludes feeds when linkedPolicyIDs explicitly lists other policies and preferredPolicy does not match', async () => {
+            await setupDomainFeed({preferredPolicy: 'OTHER_POLICY', linkedPolicyIDs: ['OTHER_POLICY']});
+
+            const {result} = renderHook(() => useCardFeeds(policyID));
+            await waitForBatchedUpdates();
+
+            // Wait for the hook to finish loading before asserting absence, so the negative
+            // assertion can't pass vacuously while Onyx is still hydrating.
+            await waitFor(() => expect(result.current[1].status).toBe('loaded'));
+            expect(result.current[0]).not.toHaveProperty([combinedFeedKey]);
+        });
+
+        it('includes feeds when policyID is one of multiple meaningful entries in linkedPolicyIDs', async () => {
+            await setupDomainFeed({preferredPolicy: 'OTHER_POLICY', linkedPolicyIDs: ['OTHER_POLICY', policyID]});
+
+            const {result} = renderHook(() => useCardFeeds(policyID));
+            await waitForBatchedUpdates();
+
+            await waitFor(() => expect(result.current[0]).toHaveProperty([combinedFeedKey]));
+        });
+    });
 });