Skip to content

Commit fe9e63d

Browse files
committed
fix: move isAdminForPolicyByIDSelector tests to proper file
1 parent b55d566 commit fe9e63d

2 files changed

Lines changed: 33 additions & 35 deletions

File tree

tests/unit/DomainSelectorsTest.ts

Lines changed: 1 addition & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,9 @@ import {
1717
technicalContactSettingsSelector,
1818
vacationDelegateSelector,
1919
} from '@selectors/Domain';
20-
import {isAdminForPolicyByIDSelector} from '@selectors/Policy';
2120
import type {OnyxEntry} from 'react-native-onyx';
2221
import CONST from '@src/CONST';
23-
import ONYXKEYS from '@src/ONYXKEYS';
24-
import type {CardFeeds, Domain, DomainErrors, DomainPendingActions, DomainSecurityGroup, DomainSettings, Policy} from '@src/types/onyx';
22+
import type {CardFeeds, Domain, DomainErrors, DomainPendingActions, DomainSecurityGroup, DomainSettings} from '@src/types/onyx';
2523
import type {BaseVacationDelegate} from '@src/types/onyx/VacationDelegate';
2624

2725
describe('domainSelectors', () => {
@@ -865,34 +863,3 @@ describe('domainSelectors', () => {
865863
});
866864
});
867865
});
868-
869-
describe('isAdminForPolicyByIDSelector', () => {
870-
const P = ONYXKEYS.COLLECTION.POLICY;
871-
872-
it('returns true when policyID is undefined', () => {
873-
expect(isAdminForPolicyByIDSelector(undefined)(null)).toBe(true);
874-
});
875-
876-
it('returns true when policyID is empty string', () => {
877-
expect(isAdminForPolicyByIDSelector('')({[`${P}p1`]: {role: CONST.POLICY.ROLE.USER} as Policy})).toBe(true);
878-
});
879-
880-
it('returns false when policies is null and policyID is provided', () => {
881-
expect(isAdminForPolicyByIDSelector('p1')(null)).toBe(false);
882-
});
883-
884-
it('returns false when the policy is not found in the collection', () => {
885-
const policies = {[`${P}p2`]: {role: CONST.POLICY.ROLE.ADMIN} as Policy};
886-
expect(isAdminForPolicyByIDSelector('p1')(policies)).toBe(false);
887-
});
888-
889-
it('returns false when policy exists but role is not admin', () => {
890-
const policies = {[`${P}p1`]: {role: CONST.POLICY.ROLE.USER} as Policy};
891-
expect(isAdminForPolicyByIDSelector('p1')(policies)).toBe(false);
892-
});
893-
894-
it('returns true when policy exists and role is admin', () => {
895-
const policies = {[`${P}p1`]: {role: CONST.POLICY.ROLE.ADMIN} as Policy};
896-
expect(isAdminForPolicyByIDSelector('p1')(policies)).toBe(true);
897-
});
898-
});

tests/unit/PolicySelectorTest.ts

Lines changed: 32 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import CONST from '@src/CONST';
22
import IntlStore from '@src/languages/IntlStore';
33
import ONYXKEYS from '@src/ONYXKEYS';
4-
import {createAdminPoliciesSelector, lastWorkspaceNumberSelector, policyNameSelector} from '@src/selectors/Policy';
4+
import {createAdminPoliciesSelector, isAdminForPolicyByIDSelector, lastWorkspaceNumberSelector, policyNameSelector} from '@src/selectors/Policy';
55
import type {Policy} from '@src/types/onyx';
66

77
describe('lastWorkspaceNumberSelector', () => {
@@ -123,3 +123,34 @@ describe('createAdminPoliciesSelector', () => {
123123
expect(Object.keys(entry ?? {})).toEqual(['id', 'name', 'avatarURL', 'created']);
124124
});
125125
});
126+
127+
describe('isAdminForPolicyByIDSelector', () => {
128+
const P = ONYXKEYS.COLLECTION.POLICY;
129+
130+
it('returns true when policyID is undefined', () => {
131+
expect(isAdminForPolicyByIDSelector(undefined)(null)).toBe(true);
132+
});
133+
134+
it('returns true when policyID is empty string', () => {
135+
expect(isAdminForPolicyByIDSelector('')({[`${P}p1`]: {role: CONST.POLICY.ROLE.USER} as Policy})).toBe(true);
136+
});
137+
138+
it('returns false when policies is null and policyID is provided', () => {
139+
expect(isAdminForPolicyByIDSelector('p1')(null)).toBe(false);
140+
});
141+
142+
it('returns false when the policy is not found in the collection', () => {
143+
const policies = {[`${P}p2`]: {role: CONST.POLICY.ROLE.ADMIN} as Policy};
144+
expect(isAdminForPolicyByIDSelector('p1')(policies)).toBe(false);
145+
});
146+
147+
it('returns false when policy exists but role is not admin', () => {
148+
const policies = {[`${P}p1`]: {role: CONST.POLICY.ROLE.USER} as Policy};
149+
expect(isAdminForPolicyByIDSelector('p1')(policies)).toBe(false);
150+
});
151+
152+
it('returns true when policy exists and role is admin', () => {
153+
const policies = {[`${P}p1`]: {role: CONST.POLICY.ROLE.ADMIN} as Policy};
154+
expect(isAdminForPolicyByIDSelector('p1')(policies)).toBe(true);
155+
});
156+
});

0 commit comments

Comments
 (0)