[Due for payment 2025-07-28] [$250] Android - Chat - App crash when paste text or image that was copied from WPS Office

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.54-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: #61322
Issue reported by: Applause - Internal Team

Action Performed:

1. Create text and image as Word Document
2. Copy the text or image via WPS Office app
3. Open the Expensify app
4. Go to any chat and paste into composer

Expected Result:

App should not crash and modal showing just the image

Actual Result:

App crash when paste text or image that was copied from WPS Office
Note:

• Not reproducible when copy from Docs app

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6846807_1748626231831.Paste_via_WPT_Crash.mp4

log.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021932087279620596935
• Upwork Job ID: 1932087279620596935
• Last Price Increase: 2025-06-09
• Automatic offers:
• mkzie2 | Contributor | 107702798

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-30 22:00:49 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• App crash when paste text or image that was copied from WPS Office
• Cannot paste text from Google Docs too

What is the root cause of that problem?

Cannot paste text from Google Docs too

In this PR #60501, we delegated the handling of clipboard data that is an image to our own composer, instead of calling the default handler of react-native. Because that default handler will paste the image (rich text) as plain text.

App/patches/react-native+0.77.1+011+Add-onPaste-to-TextInput.patch

Lines 510 to 511 in 7083c03

	+ // Prevents default behavior to avoid inserting raw binary data into the text field
	+ return true;

To detect an image being copied, we checked if the clip item URI is not null:

App/patches/react-native+0.77.1+011+Add-onPaste-to-TextInput.patch

Line 503 in 7083c03

+ if (itemUri != null) {

That is not correct, because a non-null URI can also represent any kinds of data. For example, in this case, the URI of the copied text (or any other copied data) from Google Docs is content://com.google.android.apps.docs.editors.kix.editors.clipboard?uuid=....

Next, in pasteFile callback in Composer, we ignore if type is text/plain (which is correct in this case), because we assumed that the plain text should have been handled by react-native default handler as mentioned above.

App/src/components/Composer/implementation/index.native.tsx

Lines 113 to 114 in 9922bbd

	if (clipboardContent?.type === 'text/plain') {
	return;

So, we stopped react-native default handler because we misinterpreted the clip data as an image, and did not handle the pasted plain text in our own callback, causing this text cannot be pasted.

App crash when paste text or image that was copied from WPS Office

The clipped data type is evaluated using ContentResolver with WPS URI was content://cn.wps.moffice_eng.provider/copy:

App/patches/react-native+0.77.1+011+Add-onPaste-to-TextInput.patch

Line 505 in 7083c03

+ type = cr.getType(itemUri);

I don't know why, maybe WPS office has not implemented the ContentProvided with Google so that their URI can be recognized by ContentResolver above, so their URI here cannot be recognized and thus type is null.

And same with the Google Docs case, this is a plain text but misunderstood as an image, so the null type is passed straight to the onPaste callback.

Later inside pasteFile in Composer, mimeType here is empty string, same with originalFileExtension, because this is not a file URI, causing mimeDb[mimeType] to be undefined and leading to crash:

App/src/components/Composer/implementation/index.native.tsx

Lines 116 to 120 in 9922bbd

	const mimeType = clipboardContent?.type ?? '';
	const fileURI = clipboardContent?.data;
	const baseFileName = fileURI?.split('/').pop() ?? 'file';
	const {fileName: stem, fileExtension: originalFileExtension} = splitExtensionFromFileName(baseFileName);
	const fileExtension = originalFileExtension || (mimeDb[mimeType].extensions?.[0] ?? 'bin');

What changes do you think we should make in order to solve the problem?

We should skip the logic for image if the type resolved from the URI is not plain text:

App/patches/react-native+0.77.1+011+Add-onPaste-to-TextInput.patch

Lines 503 to 512 in 7083c03

	+ if (itemUri != null) {
	+ ContentResolver cr = getReactContext(this).getContentResolver();
	+ type = cr.getType(itemUri);
	+ data = itemUri.toString();
	+ if (mPasteWatcher != null) {
	+ mPasteWatcher.onPaste(type, data);
	+ }
	+ // Prevents default behavior to avoid inserting raw binary data into the text field
	+ return true;
	+ }

if (itemUri != null) {
    ContentResolver cr = getReactContext(this).getContentResolver(); 
    type = cr.getType(itemUri);
    if (type != null && !type.equals(ClipDescription.MIMETYPE_TEXT_PLAIN)) {
        data = itemUri.toString(); 
        // The rest

POC

Google Docs

Screen.Recording.2025-06-11.at.10.47.00.mov

Pasting image is intact:

Screen.Recording.2025-06-11.at.10.57.09.mov

WPS Office

Screen.Recording.2025-06-11.at.10.52.52.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

• Early return if clipboardContent?.type is null here.

• Add optional chaining to mimeDb[mimeType] here

App/src/components/Composer/implementation/index.native.tsx

Line 120 in 9922bbd

const fileExtension = originalFileExtension || (mimeDb[mimeType].extensions?.[0] ?? 'bin');

[mkzie2]

@johncschuster This bug is blocking copy pasting from Google Docs as well so we'd better fix it quick.

[yellowtailfan]

@mkzie2 Can you please describe your reproduction steps for the Google Docs case in more detail? I tested Google Docs on Android native with formatted text and did not see this issue (there is a screen recording on #61322). Also @lanitochka17’s report says that Google Docs was OK. Perhaps there is something specific about your test case?

[mkzie2]

@yellowtailfan No special reproduction steps, just copy any text from Google Docs and paste into composer. It said "New Expensify Dev pasted your clipboard" but does not paste anything. I think this is not a regression from your PR.

[yellowtailfan]

Thanks @mkzie2. I'm still interested as although my changes are not exercised on Android this is in a related area.

I tried to reproduce this with the 9.1.54-6-staging binary using Google Docs on a simulator running API 36 but it works fine for me. I tried some text with bold and plain formatting, and also a couple of paragraphs of plain text. Recipe I tried:

1. Type text into new document in Google Docs
2. (Optional) Apply bold formatting
3. Copy
4. Switch to Expensify and paste into chat
5. Plain text appears with no formatting

[melvin-bot]

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

[johncschuster]

Looks like this is being covered in #57241