Search - The chat filter is reset after clicking the message on the Search page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.56-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Device used: Mac 15.4.1 Web, Desktop, iPhone 13 iOS 18.4.1/ Safari, Hybrid
App Component: Search

Action Performed:

Precondition: The user has sent a message with an attachment or a link

1. Navigate to https://staging.new.expensify.com
2. Navigate to the Reports
   3.Click on Chats
   4.Click on the Status drop-down menu
3. Select Attachments
   6.Click on the message item (not over the attachment)

Expected Result:

The filter is non reset, the user can close RHP with the conversation and see the page with filter results.

Actual Result:

The chat filter is reset after clicking the message.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6849212_1748910505297.Recording__116.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Regression from Expensify/react-native-onyx@a2ba002. We merge the value directly then all report actions are merged from OpenReport API.

cc @FitseTLT @parasharrajat

[parasharrajat]

@FitseTLT do you have a solution to fix this, or should I revert?

[FitseTLT]

@FitseTLT do you have a solution to fix this, or should I revert?

@parasharrajat this has to be fixed from onyx repo so reverting the onyx bump is a must. Even CP-staging is better.

[parasharrajat]

But it is not a deploy blocker, so I don't think we need to revert the PR. You can directly work on fixing the Onyx unless we don't have a solution.

[FitseTLT]

But it is not a deploy blocker, so I don't think we need to revert the PR. You can directly work on fixing the Onyx unless we don't have a solution.

Yeah it has passed to production. Working on it thx

[CortneyOfstad]

Hey @FitseTLT! I am heading OoO this afternoon (6/3) to Monday (6/9). If any action is needed by BZ during that time, please reapply the label or reach out in Slack, otherwise I will review when I get back. Thanks!

[FitseTLT]

@luacmartins The changes in onyx we made here related to this issue has caused this issue. Previously we used to pick only existing keys in the snapshot to apply BE response to the snapshot key. We removed that picking recently but it caused this issue. On all other collections it works perfect but for reportActions_ collection key the report actions of a report id are inside the object with the reportActionIDs as the keys. So now when OpenReport addes report actions to reportActions_reportID as we don't pick only existing keys all the report actions returned by OpenReport will be pushed to the report actions collection for the report. And as our Search page filter mechanism wholly depends on the data available in the snapshot key it will display all report actions that should have been filtered out. So what option do you suggest I follow

1. Make an exception for reportActions_ collection and apply the picking
2. Apply the removal of picking for specific collection keys like transaction_

[luacmartins]

Hmm that's an interesting one. These exception would have to be made in Onyx, right? However, Onyx is it's own open source lib and shouldn't be aware of App specific logic which creates an issue with the approach you mentioned. We might want to:

1. Create a config in Onyx to pass a list of allowed "merge all" keys to snapshot
2. Use this list in Onyx to decide which collections should be merged in its entirety or picked
3. Pass this config from App

[FitseTLT]

Hmm that's an interesting one. These exception would have to be made in Onyx, right? However, Onyx is it's own open source lib and shouldn't be aware of App specific logic which creates an issue with the approach you mentioned. We might want to:

1. Create a config in Onyx to pass a list of allowed "merge all" keys to snapshot
2. Use this list in Onyx to decide which collections should be merged in its entirety or picked
3. Pass this config from App

Exactly the concern I had Thx will raise it and tag u for your 👀