[$250] Home - No expected banner shown after running a snippet

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.61-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to validate in Prod - Provide reasoning.
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/40579099/test-cases/88870317
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Ventura / Chrome
App Component: Other

Action Performed:

Precondition:

1. Login with a new account and create a Collect workspace.
2. Ensure no billing card is on file.
3. Navigate to Account > Subscription
4. Run the snippet to set nvp_private_firstDayFreeTrial to today's date (May require page refresh):
   Onyx.set('nvp_private_firstDayFreeTrial', '2026-04-21T09:00:00');

STR:

1. Navigate to the Home page
2. "Time sensitive" section appears at the top of the left column

Expected Result:

Verify the item displays a stopwatch icon
Verify the title is "50% off your first year"
Verify the supporting text shows a live countdown: "{HH}h {MM}m {SS}sec remaining"

Actual Result:

No expencted format banner.
Something like 'Trial: 30 days left!' only.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @abbasifaizan70

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022046615970624008812
• Upwork Job ID: 2046615970624008812
• Last Price Increase: 2026-04-28
• Automatic offers:
• thelullabyy | Reviewer | 111332017

[MelvinBot]

Proposal

What is the root cause of that problem?

The "50% off your first year" discount banner with the live countdown is intentionally suppressed for Collect (Team) workspace users with 2025 pricing by an explicit guard in shouldShowDiscountBanner:

if (hasTeam2025Pricing && subscriptionPlan === CONST.POLICY.TYPE.TEAM) {
    return false;
}

When a new user creates a Collect workspace in 2026:

1. useHasTeam2025Pricing returns true (user created after April 1, 2025 or has no firstPolicyDate)
2. useSubscriptionPlan returns TEAM (Collect = Team type, no Corporate workspace)
3. shouldShowDiscountBanner → false, so discountType becomes null in useFreeTrial

As a result, FreeTrialSection renders in fallback mode — showing "Free trial: N days left!" with "Don't wait! Add your payment card now." instead of the discount offer + countdown. The "Trial: 30 days left!" text the reporter sees is from the separate FreeTrial badge in the inbox header, which is unrelated to the Home page widget.

What changes do you think we should make in order to solve the problem?

Remove the Team 2025 pricing exclusion at SubscriptionUtils.ts:168-170 so the discount banner shows for all free trial users regardless of pricing tier, or update it to only suppress the discount for a specific scenario if there's a business reason for the exclusion.

Since this was caught by a regression test that explicitly expects the discount banner for Collect workspace users, removing the guard seems like the correct fix. The FreeTrialSection widget and countdown logic already work correctly — they're just being gated off.

What alternative solutions did you explore? (Optional)

An alternative would be to keep the exclusion but create a separate Team-2025-specific banner variant in FreeTrialSection. However, the simpler approach of removing the guard is preferable unless there's a deliberate business reason to suppress discounts for Team 2025 pricing users.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thelullabyy (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022046615970624008812

[MobileMage]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After running an Onyx snippet to set nvp_private_firstDayFreeTrial on an already-mounted Home page, the expected "50% off your first year" discount banner with a live countdown does not appear — instead the generic "Trial: 30 days left!" text is shown.

What is the root cause of that problem?

The useFreeTrial hook initializes discountInfo via a useState lazy initializer that only runs once on mount. When firstDayFreeTrial is set via the snippet after the component is already mounted, showDiscount becomes true and the useEffect re-runs. However, the effect's cleanup from the previous render fires setDiscountInfo(null) before the new interval is set up, and the new interval only populates discountInfo after a full 1-second tick. During that window — and on the very first render after the Onyx value is received — discountInfo is null, so getDiscountType returns null and the component falls through to the generic "add card" path.

The fundamental problem is that the effect never sets discountInfo immediately when it starts; it only updates on subsequent interval ticks. Combined with the cleanup unconditionally resetting discountInfo to null, there is always at least a 1-second gap where discountType is null.

App/src/pages/home/FreeTrialSection/useFreeTrial.ts

Lines 48 to 63 in 8a6f5bb

	const [discountInfo, setDiscountInfo] = useState<DiscountInfo | null>(() => (showDiscount ? getEarlyDiscountInfo(firstDayFreeTrial) : null));
	useEffect(() => {
	if (!showDiscount) {
	return;
	}
	const intervalID = setInterval(() => {
	setDiscountInfo(getEarlyDiscountInfo(firstDayFreeTrial));
	}, CONST.MILLISECONDS_PER_SECOND);
	return () => {
	clearInterval(intervalID);
	setDiscountInfo(null);
	};
	}, [firstDayFreeTrial, showDiscount]);

What changes do you think we should make in order to solve the problem?

Set discountInfo immediately at the start of the effect instead of waiting for the first interval tick, and remove the cleanup's setDiscountInfo(null) call so that the existing discount info is not wiped between re-renders.

App/src/pages/home/FreeTrialSection/useFreeTrial.ts

Lines 50 to 63 in 8a6f5bb

	useEffect(() => {
	if (!showDiscount) {
	return;
	}
	const intervalID = setInterval(() => {
	setDiscountInfo(getEarlyDiscountInfo(firstDayFreeTrial));
	}, CONST.MILLISECONDS_PER_SECOND);
	return () => {
	clearInterval(intervalID);
	setDiscountInfo(null);
	};
	}, [firstDayFreeTrial, showDiscount]);

     useEffect(() => {
         if (!showDiscount) {
+            setDiscountInfo(null);
             return;
         }

+        setDiscountInfo(getEarlyDiscountInfo(firstDayFreeTrial));
+
         const intervalID = setInterval(() => {
             setDiscountInfo(getEarlyDiscountInfo(firstDayFreeTrial));
         }, CONST.MILLISECONDS_PER_SECOND);

         return () => {
             clearInterval(intervalID);
-            setDiscountInfo(null);
         };
     }, [firstDayFreeTrial, showDiscount]);

The setDiscountInfo(null) is moved into the !showDiscount branch so it still clears when the discount is no longer applicable, while the immediate setDiscountInfo call ensures the correct discount info is available on the very first render after firstDayFreeTrial is set.

What alternative solutions did you explore? (Optional)

N/A

[alexanderxfgl-bit]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The home page is not displaying the expected "50% off your first year" banner after running a snippet to set the nvp_private_firstDayFreeTrial Onyx key. Instead, it's showing a generic "Trial: 30 days left!" banner.

What is the root cause of that problem?

The useTimeSensitiveBilling hook (src/pages/home/TimeSensitiveSection/hooks/useTimeSensitiveBilling.ts, line 13) is responsible for determining which banner to display. Currently, it only checks for billing errors and doesn't consider the nvp_private_firstDayFreeTrial key, which is used to trigger the free trial banner. This causes the component to fall back to the default trial banner.

What changes do you think we should make in order to solve the problem?

Modify the useTimeSensitiveBilling hook to check the nvp_private_firstDayFreeTrial Onyx key and return a boolean value indicating whether the free trial banner should be displayed. This will allow the component to correctly render the "50% off your first year" banner when the condition is met.

What alternative solutions did you explore? (Optional)

N/A

[alexanderxfgl-bit]

Contributor details
Your Expensify account email: alexanderxfgl@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~2021935202864784599

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[alexanderxfgl-bit]

Compare branch with the fix: https://github.com/Expensify/App/compare/main...alexanderxfgl-bit/App:fix/88447-ai?expand=1