[Due for payment 2026-05-20] [Due for payment 2026-05-18] Expense - Received payment option is shown when Payments are disabled in workflows settings

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.69-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #86174
Email or phone of affected tester (no customers): odijsdoojdiosjnodnjsio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Disable Payments in Workflow settings.
• Admin invites member to the workspace.

1. Go to staging.new.expensify.com
2. [Member] Go to workspace chat, submit an expense and click Submit on the expense preview.
3. [Admin] Open member's report and click Approve.
4. [Member] Open the report.
5. [Member] Click More > Received payment > Yes, I've received payment.

Expected Result:

Received payment option will not be present when Payments are disabled in workflows settings (the button is not shown on OD when Payments are disabled).

Actual Result:

Received payment option is shown when Payments are disabled in workflows settings.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Pujan92

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #86174

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #86174 - "Allow submitters to select 'Received reimbursement' option" by @nabi-ebrahimi (High confidence)
Related Issues: #83035

Recommendation: REVERT

The PR introduced a new "Received payment" menu option but the isReceivedPaymentAction visibility guard does not check whether Payments are disabled in the workspace Workflow settings. Reverting the PR removes the incorrectly shown option and unblocks the deploy.

Assigned: @nabi-ebrahimi (PR author), @Pujan92, @luacmartins (approving reviewers)
Labels: DeployBlockerCash kept (frontend App PR caused the issue). No label changes made.

Detailed Analysis

Evidence

• The issue reporter confirmed this is staging-only ("N/A - new feature, doesn't exist in prod"), meaning the cause is a PR newly merged to staging.
• melvin-bot already pointed to PR Allow submitters to select "Received reimbursement" option #86174 as the likely cause, and the StagingDeployCash checklist (issue Deploy Checklist: New Expensify 2026-05-08 #90006) confirms PR Allow submitters to select "Received reimbursement" option #86174 is part of the current 9.3.69-0 staging release.
• PR Allow submitters to select "Received reimbursement" option #86174 adds a new isReceivedPaymentAction function in src/libs/ReportSecondaryActionUtils.ts that controls when the "Received payment" option appears in the More menu. This function does NOT check policy.reimbursementChoice, so it shows the option even when the workspace has Payments disabled (i.e., reimbursementChoice === REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO).
• The existing pattern for disabling actions based on payment settings is already present at line 158 of ReportSecondaryActionUtils.ts: const arePaymentsDisabled = policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO; — but this check was not applied to the new isReceivedPaymentAction function.
• The PR was merged on 2026-05-07 and the issue was reported on 2026-05-08, consistent with the timeline.

Verification

• Affected file: src/libs/ReportSecondaryActionUtils.ts — specifically the isReceivedPaymentAction function added by PR Allow submitters to select "Received reimbursement" option #86174.
• PR Allow submitters to select "Received reimbursement" option #86174 directly adds isReceivedPaymentAction to src/libs/ReportSecondaryActionUtils.ts and wires it into getSecondaryReportActions, confirming this PR is the source of the change.

Root Cause

isReceivedPaymentAction checks that the user is a submitter, the report is in an approved/closed/settled state, and no bank payment action exists — but it never checks policy.reimbursementChoice. When an admin disables Payments in Workflow settings (reimbursementChoice === 'reimburseNo'), the function still returns true and the "Received payment" option is rendered in the More menu. The fix is to add a guard: if (policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO) return false; inside isReceivedPaymentAction, or revert the PR and reintroduce it with the guard in place.

[MelvinBot]

Proposal

What is the root cause of that problem?

PR #86174 added the isReceivedPaymentAction function in ReportSecondaryActionUtils.ts:442-466 to show the "Received payment" option for submitters on approved/closed/settled expense reports. However, this function never checks whether Payments are enabled in the workspace Workflow settings (policy.reimbursementChoice). Other functions in the same file — like isExportAction — correctly gate on arePaymentsEnabled(policy) before returning true, but isReceivedPaymentAction omits this check entirely.

What changes do you think we should make in order to solve the problem?

Add an early return in isReceivedPaymentAction that checks whether payments are disabled, using the existing arePaymentsEnabledUtils helper (already imported in the file). Specifically, after line 449, add:

if (!arePaymentsEnabledUtils(policy)) {
    return false;
}

This follows the same pattern used by isExportAction at line 493 and isMarkAsExportedAction, and uses the existing arePaymentsEnabled utility which checks policy.reimbursementChoice !== 'reimburseNo'.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.