[Due for payment 2026-05-26] [Due for payment 2026-05-26] [$250] Expense - Negative sign can be entered for IOU expense in IOU report

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.75-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89166
Email or phone of affected tester (no customers): soidjojodsjosjdosj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Open DM with any user.
3. Create two expenses in foreign currency.
4. Open the report.
5. Click Amount field.
6. Enter negative sign.
   BUG: Negative sign can be entered in IOU report.
7. Go to Spend > Expenses.
8. Click Amount field on the same expense from Step 5.
9. Enter negative sign.
   → Negative sign is blocked for IOU expenses on Spend > Expenses - Expected.

Expected Result:

In Step 6, negative sign should be blocked when inline editing in IOU report.

Actual Result:

In Step 6, negative sign can be entered when inline editing in IOU report, which is inconsistent with the inline editing on Spend > Expenses in Step 9 (negative sign is blocked for IOU expenses).

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7155471_1778881709821.13.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022055994264193608351
• Upwork Job ID: 2055994264193608351
• Last Price Increase: 2026-05-17

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #89166

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #89166 - "feat: Add inline editing for tables on desktop (V2)" by @mohammadjafarinejad (High confidence)
Related Issues: #82534, #88711

Recommendation: REVERT

PR #89166 introduced inline editing for the amount field in the IOU report transaction view, but the allowFlippingAmount logic in TotalCell.tsx does not correctly restrict negative input for IOU expenses, creating an inconsistency with the Spend > Expenses inline editing which correctly blocks the negative sign.

Assigned: @mohammadjafarinejad (PR author), @ahmedGaber93 (approving reviewer), @puneetlath (approving reviewer)
Labels: DeployBlockerCash kept (Frontend bug in App PR). DeployBlocker removed — fix requires changes to Expensify/App, not the backend.

Detailed Analysis

Evidence

• melvin-bot already identified PR feat: Add inline editing for tables on desktop (V2) #89166 as the causing PR in the first comment on the issue.
• PR feat: Add inline editing for tables on desktop (V2) #89166 is present in the StagingDeployCash checklist (item 53 chronologically, merged 2026-05-14).
• The bug is staging-only ("Reproducible in production? N/A - new feature, doesn't exist in prod").
• The issue is specifically about inline editing of the Amount field in the IOU report view — exactly what PR feat: Add inline editing for tables on desktop (V2) #89166 added.
• PR feat: Add inline editing for tables on desktop (V2) #89166 modifies src/components/TransactionItemRow/DataCells/TotalCell.tsx and src/components/MoneyRequestReportView/MoneyRequestReportTransactionItem.tsx, both directly involved in the reported behavior.

Verification

• Affected files confirmed in PR feat: Add inline editing for tables on desktop (V2) #89166:
  • src/components/TransactionItemRow/DataCells/TotalCell.tsx — new inline edit amount logic
  • src/components/MoneyRequestReportView/MoneyRequestReportTransactionItem.tsx — wires up inline edit callbacks including onEditAmount
  • src/components/MoneyRequestAmountInput.tsx — extended to support new inline edit props
  • src/hooks/useTransactionInlineEdit.ts — new hook driving edit permissions

Root Cause

In TotalCell.tsx (introduced by PR #89166), the allowNegative flag is computed as:

const allowNegative =
  isUnreportedExpense ||
  shouldEnableNegative(
    transactionItem.report,
    transactionItem.policy,
    iouType,
    transactionItem.participants,
  );

This flag is then passed as allowFlippingAmount={!isSplitBill && allowNegative} to MoneyRequestAmountInput. For a standard IOU expense created in a DM with another user (the exact reproduction steps), shouldEnableNegative can return true — for example, when isGroupPolicyType is true because the user belongs to a group policy — causing the negative toggle button and direct negative sign input to be available.

By contrast, the Spend > Expenses view (TransactionListItem in the Search table) uses a separate code path for its inline amount editing that does not apply the same allowFlippingAmount flag for IOU expenses, which is why it correctly blocks the negative sign. The inconsistency was introduced in PR #89166 because the new IOU report inline editing was implemented without matching the exact negative-input restriction logic that the Spend > Expenses path enforces.

The fix requires either reverting PR #89166 or, if rolling forward is preferred, auditing and tightening the allowNegative condition in TotalCell.tsx so it does not allow negative input for standard IOU (non-expense-report, non-self-DM) transactions.