Fix admin invite onboarding task#91950
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
KJ21-ENG
changed the title
melvin-bot
Bot
requested review from
cretadn22 and
heyjennahay
and removed request for
a team and
heyjennahay
|
@cretadn22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 35aa854888
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@cretadn22 Kind bump here. Thanks |
1 similar comment
|
@cretadn22 Kind bump here. Thanks |
|
As noted in this comment, let's place a hold on this PR for now |
|
Understood, Thanks! |
|
@cretadn22 The backend PR hit staging yesterday. I verified the frontend changes afterward, and everything is working as expected. Could you please complete the review of this PR? Thanks! 1780567467931013.mp4 |
|
@cretadn22 Kind ping here. Thanks! |
|
@KJ21-EN Let's remove this section since we have automated verification for it. |
@KJ21-ENG Done! |
|
@KJ21-ENG Please merge main |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58a5a0c7bb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@jasperhuangg Kind ping here. Thanks! |
jasperhuangg
left a comment
jasperhuangg
left a comment
There was a problem hiding this comment.
Looks good. Sorry for the delay. Let's fix those conflicts.
…n-invite-onboarding-v3 # Conflicts: # src/libs/actions/Report/index.ts
|
@jasperhuangg conflict solved |
|
@KJ21-ENG Mind checking the failing checks? |
…n-invite-onboarding-v3
|
@cretadn22 Failing tests are non related to this PR. Merging main here. Thanks! |
|
@jasperhuangg We are ready |
…n-invite-onboarding-v3 # Conflicts: # src/pages/inbox/ReportFetchHandler.tsx
|
FYI :- Failing Tests are not related to this PR. Thanks! |
|
@KJ21-ENG please merge main into this PR |
…n-invite-onboarding-v3
|
@jasperhuangg Done, merged main into this PR. Thanks! |
|
🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.4.29-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR against the help site articles under Why: This is a bug fix to internal onboarding logic — it corrects when the guided setup / invite onboarding flow queues the "Review your workspace settings" Concierge task for workspace admin invites (specifically for users who had already completed the regular guided setup). The change is entirely in The help site documents customer-facing product behavior (e.g. Managing Workspace Members, Create a company workspace). The internal Concierge guided-setup task-queueing flow this PR touches isn't described in any article, and the visible end-state (an invited admin seeing the guided setup steps) is the intended behavior being restored — so nothing documented becomes inaccurate as a result of this change. Since no docs changes are required, I did not create a draft PR. @KJ21-ENG, please confirm you agree no help site updates are needed here. If you believe a specific article should be updated (or a new one added), let me know which flow it covers and I'll draft it. |
|
🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.4.31-0 🚀
|
|
🤖 Help site review: no changes required. I reviewed the changes in this PR against Expensify's help site articles under Why: This PR is an internal bug fix to when the guided setup / invite onboarding tasks are queued in the Concierge chat — specifically allowing the pending workspace admin invite onboarding (the "Review your workspace settings" task) to run even when a user has already completed the regular guided setup flow. The changes are confined to logic and TypeScript type guards in There is:
A search of @KJ21-ENG, please confirm you agree that no help site changes are needed here. If you believe a customer-facing article should document this admin-invite onboarding experience, let me know and I'll draft one. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.31-0 🚀
Bundle Size Analysis (Sentry): |
5 participants
Explanation of Change
This PR fixes the invite onboarding flow for workspace admin invites when the invited user has already completed the regular guided setup flow.
Previously,
getGuidedSetupDataForOpenReportreturned early whenhasCompletedGuidedSetupFlowwas already true, so the pending admin invite onboarding task was not queued and the concierge chat did not show the Review your workspace settings step. The updated logic allows supported pending invite onboarding choices to run even when regular guided setup has already been completed, while still blocking completed invite onboarding and duplicate queued setup.This also waits for the corrected invite onboarding state before opening the report from the inbox route, so invite
choice/inviteTypevalues loaded during app startup can trigger the guided setup flow.Fixed Issues
$ #90933
PROPOSAL: #90933 (comment)
Tests
Offline tests
N/A - this change does not add new offline behavior or network handling. It only changes when pending invite onboarding is allowed to queue after app state loads.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.native.mov
Android: mWeb Chrome
android.mweb.mov
iOS: Native
ios.native.mov
iOS: mWeb Safari
ios.mweb.mov
MacOS: Chrome / Safari
1780567467931013.mp4