[$250] Agents-Cannot switch account from bottom drawer on visiting profile via Copilot acct

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.3.89-5
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exploratory around #91537
Email or phone of affected tester (no customers): applausetester+ck52826@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Iphone 16/18.7.1
App Component: User Settings

Action Performed:

Precondition: Owner has crated few agents

1. Launch Hybrid app & log in with Expensifail account
2. Go to Account >> Agents >> Select agent
3. Click "Copilot into account"
4. Tap back button on Profile page
5. User navigate to Home tab >> Tap Account menu
6. Tap account icon to open bottom switch account drawer
7. Select owner account
8. Observe account not switched to owner and still show agent's account
9. Tap on the account icon again & observe account get switched to owner account now
10. Repeat steps 5-9 switching accounts between agent owner & agent

Expected Result:

User able to switch accounts on selecting accounts from bottom drawer when switching between owner and agents after visiting agent's profile page via Copilot into account option

Actual Result:

Cannot switch accounts on selecting accounts from bottom drawer when switching between owner and agents after visiting agent's profile page via Copilot into account option
User ahs to click top account icon to see the switched account

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7166572_1780077554508.ScreenRecording_05-29-2026_13-37-01_1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7166572

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022061454516701719762
• Upwork Job ID: 2061454516701719762
• Last Price Increase: 2026-06-01

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/a363f0930dcbc6708ad7ed169b9b3d82243e4f0cb574326c2d5c6da696216ec4

[melvin-bot]

@NicolasBonet recently merged #91537, but they are OOO right now, so I'll auto-assign someone else.

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

⚠️ Medium confidence. Code path is verified, but this is iOS HybridApp-only and I can't reproduce it on web, so the exact mechanism below should be confirmed on a device before merging a code fix. Two findings are solid: (1) the stale display comes from useCurrentUserPersonalDetails, and (2) PR #91537 did not introduce the bug, only a new way to trigger it.

Problem

After copiloting into an agent via the new Copilot into account button, switching back to the owner from the account-switcher bottom drawer leaves the switcher displaying the agent's name/avatar. The account actually switches — tapping the switcher icon a second time (forcing a re-render) reveals the correct owner account. So this is a stale render of the displayed account, not a failed switch.

Root cause

The name/avatar shown in the switcher come from useCurrentUserPersonalDetails(). When you tap the owner, disconnect() updates SESSION, clears Onyx, then asynchronously repopulates PERSONAL_DETAILS_LIST via openApp(). The displayed identity does not reliably re-render when that async data lands — a subsequent unrelated re-render (the second tap) is what flushes it.

The strongest code-level suspect is the selector in CurrentUserPersonalDetailsProvider.tsx:19-28, which mutates the Onyx object in place and returns the same reference — a known pattern that can suppress useOnyx/context update notifications.

Important: PR #91537 only added the profile button — it did not modify the AccountSwitcher, the delegate connect/disconnect logic, or CurrentUserPersonalDetailsProvider. This is a pre-existing reactivity bug that the new entry point exposes, not a defect in the PR's own code.

Recommended changes

Because this is a DeployBlockerCash on a new feature that isn't in production, the lowest-risk immediate unblock is to revert PR #91537 (removes the new entry point and the regression), then fix the underlying stale-render separately.

The candidate code fix for the underlying bug is to stop mutating the selector result and return a fresh object:

const userAccountSelector = useCallback(
    (allPersonalDetails) => ({
        ...(allPersonalDetails?.[userAccountID] ?? {}),
        accountID: userAccountID,
        email: session?.email,
    }),
    [session?.email, userAccountID],
);

This must be verified on iOS HybridApp before merging, since CurrentUserPersonalDetailsProvider is used app-wide and the native HybridAppModule.switchAccount session-sync timing may also contribute.

Investigation details, alternatives considered, and open questions

Flow traced: profile button → useSwitchToDelegator → connect()/disconnect() in Delegate.ts. disconnect() sets SESSION, then clearOnyxForDelegateTransition() wipes PERSONAL_DETAILS_LIST, then openApp() repopulates it. There's a window where the selector returns an empty-shape object, and the re-render when the owner's details arrive isn't reliably triggered.

Alternative considered — "RHP modal not dismissed": the profile button calls switchToDelegator() without dismissing its host RHP. I ruled this out as the primary cause because the pre-existing CopilotPage, AgentsPage, and EditAgentPage all use the exact same direct-call pattern from within the RHP, so it isn't unique to this PR.

Ruled out as irrelevant: the new openAgentsPage() useEffect (Agent.ts) is just a data read, and callFunctionIfActionIsAllowed is a pass-through for non-anonymous users.

Open questions to confirm on device:

• Does useOnyx use reference equality on selector output? If so, the in-place mutation at lines 21-24 definitively suppresses the update.
• Is the staleness truly exclusive to the profile entry point, or does switching back also need a second tap after copiloting from CopilotPage? The report only exercised the profile flow.
• Does the native HybridAppModule.switchAccount step delay PERSONAL_DETAILS_LIST repopulation on iOS?

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/92158) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.