refactor: add dedicated TaskSearchView by BartekObudzinski · Pull Request #94820 · Expensify/App

BartekObudzinski · 2026-06-29T10:20:56Z

Explanation of Change

This adds a dedicated TaskSearchView for the task search type, composing the shared useSearchListViewState hook and SearchListViewLayout chrome over BaseSearchList (the same pattern as ExpenseFlatSearchView). The router now dispatches the task type to it instead of the legacy SearchList shell. Task rows use TaskListItem, have no column data and no exit animation, and long press is suppressed; the parent-report name still comes from the report-attributes selector inside TaskListItem, so there is no behavior change.

Fixed Issues

$ #95034

Tests

Open the Search tab and run a search that returns a task list (the Tasks type).
Verify the task rows render the same as before, including the parent-report name.
Click a row and verify it opens the task as before.
On a narrow layout, long press a row and verify it behaves the same as before (no selection menu for tasks).
Enter mobile selection mode and verify tapping a row toggles its selection instead of navigating.
Switch to another search type (expenses, reports) and back, and verify each list still renders correctly.

Verify that no errors appear in the JS console

Offline tests

Go offline.
Open the task search and verify the list still renders and rows remain tappable.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-07-01.at.12.24.03.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2026-07-01.at.12.25.00.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-01.at.12.22.55.mov

…-view # Conflicts: # src/components/Search/index.tsx

codecov · 2026-07-01T06:29:35Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Search/TaskSearchView.tsx	`100.00% <100.00%> (ø)`
src/components/Search/index.tsx	`0.72% <0.00%> (-0.01%)`	⬇️
... and 14 files with indirect coverage changes

BartekObudzinski · 2026-07-01T12:10:50Z

@codex review

melvin-bot · 2026-07-01T12:10:54Z

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-07-01T14:04:19Z

🤖 Verified on web (dev NewDot, branch perf/search-s6-task-view) — ✅ Pass

Task rows render: Ran a Tasks-type search; three task rows rendered (Take a test drive, Create your first report, Set up categories) with Date, Title, Description, From, Shared in, Assignee, and Action columns.
Parent-report name: The Shared in column shows the parent report name (Concierge) with its avatar on every row.
Clicking a row opens the task: Clicking Create your first report opened the task in the right-hand panel — title, From Concierge parent link, description, assignee, and action buttons all shown.
Console: No JS console errors observed.

Tasks search results

Opened task after clicking a row

daledah · 2026-07-01T18:05:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-02.at.01.04.21.mov

daledah

LGTM

BartekObudzinski · 2026-07-01T18:53:20Z

OOO until next week 👋 If anything comes up, I've asked the callstack team to keep an eye on things. Thanks!

github-actions · 2026-07-02T13:58:04Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-07-02T14:03:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-02T14:04:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94820.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-24509b1febc-78d7f86-90a8c9c08ba171682f417fae67db5761f0827732/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-24509b1-78d7f86-4993c0a032ed91df330562d1246b27d3fa52208b/index.html

Web 🕸️
https://94820.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-03T16:43:48Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.27-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-03T16:45:40Z

Help site review — no changes required

I reviewed the changes in this PR against the help site articles under App/docs/articles, and no documentation updates are needed.

Why: This is a purely internal refactor of the Search component. It adds a dedicated TaskSearchView that composes the shared useSearchListViewState hook and SearchListViewLayout over BaseSearchList (mirroring the existing ExpenseFlatSearchView pattern), and updates the router to dispatch the task search type to it instead of the legacy SearchList shell. As the PR description states, there is no behavior change — task rows render the same, navigation is unchanged, and selection/long-press behavior is preserved.

The changed files are all code and tests:

src/components/Search/TaskSearchView.tsx (new)
src/components/Search/index.tsx (router dispatch)
tests/unit/Search/TaskSearchViewTest.tsx (tests)

There are no new or changed feature names, tab names, settings labels, buttons, or user-facing flows, so nothing in the public help site (task search, Search, reports, etc.) becomes inaccurate as a result of this PR. No draft help site PR was created.

@BartekObudzinski, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

(Note: no help site PR was created because this refactor has no user-facing impact. If you believe a docs update is still warranted, let me know what behavior changed and I'll draft one.)

OSBotify · 2026-07-06T15:31:42Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

refactor: add dedicated TaskSearchView

f5f87e5

melvin-bot Bot assigned BartekObudzinski Jun 29, 2026

Merge remote-tracking branch 'upstream/main' into perf/search-s6-task…

82f189b

…-view # Conflicts: # src/components/Search/index.tsx

mountiny mentioned this pull request Jul 1, 2026

[Due for payment 2026-07-13] [$125] refactor: add dedicated TaskSearchView #95034

Open

BartekObudzinski marked this pull request as ready for review July 1, 2026 12:10

BartekObudzinski requested review from a team as code owners July 1, 2026 12:10

melvin-bot Bot requested review from daledah and heyjennahay and removed request for a team July 1, 2026 12:10

daledah approved these changes Jul 1, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny July 1, 2026 18:06

mountiny reviewed Jul 2, 2026

View reviewed changes

Comment thread src/components/Search/TaskSearchView.tsx Outdated

VickyStash added 3 commits July 2, 2026 15:14

Merge branch 'main' into perf/search-s6-task-view

cc66c2a

Remove duplicated code

cf18fab

Clean up

1f36af6

mountiny approved these changes Jul 2, 2026

View reviewed changes

mountiny merged commit 24509b1 into Expensify:main Jul 2, 2026
35 checks passed

OSBotify mentioned this pull request Jul 3, 2026

Deploy Checklist: New Expensify 2026-07-03 #95291

Closed

98 tasks

applause-bot Bot mentioned this pull request Jul 6, 2026

[Exploratory] Spend - User is redirected to "Inbox" after deleting a task from tasks list. #95371

Open

7 tasks

Uh oh!

Conversation

BartekObudzinski commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

BartekObudzinski commented Jul 1, 2026

Uh oh!

melvin-bot Bot commented Jul 1, 2026

Uh oh!

MelvinBot commented Jul 1, 2026

Uh oh!

daledah commented Jul 1, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

daledah left a comment

Choose a reason for hiding this comment

Uh oh!

BartekObudzinski commented Jul 1, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

OSBotify commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

OSBotify commented Jul 3, 2026

Uh oh!

MelvinBot commented Jul 3, 2026

Help site review — no changes required

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

BartekObudzinski commented Jun 29, 2026 •

edited

Loading

codecov Bot commented Jul 1, 2026 •

edited by github-actions Bot

Loading