[No QA] Growl: add action button and loading variant by borys3kk · Pull Request #94865 · Expensify/App

borys3kk · 2026-06-29T15:06:59Z

Explanation of Change

Adds dormant capability to the Growl notification with no behavior change: show/success accept an optional action button and supporting CONST.GROWL durations, styles, and a reversed theme color. UI is extracted into GrowlNotificationContent so the shell only mounts content while visible. Groundwork for an upcoming "Expense added" growl with a "View" deep link.

Fixed Issues

$ #91408
PROPOSAL:

Tests

N/A - we do not use the growls anywhere else in the app (NO QA)

Verify that no errors appear in the JS console

Offline tests

N/A — this change only modifies the in-app notification component; it adds no API calls or Onyx operations. Existing growls behave identically offline and online.

QA Steps

Same as tests.

// TODO: These must be filled out, or the issue title must include "[No QA]." — this PR is [No QA] (no user-facing change).

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

JakubKorytko

nice one but some comments

…NACTIVE_OFFSET

codecov · 2026-06-30T15:45:54Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`93.33% <ø> (ø)`
src/styles/index.ts	`60.30% <ø> (-0.41%)`	⬇️
src/styles/theme/themes/dark.ts	`100.00% <ø> (ø)`
src/styles/theme/themes/light.ts	`100.00% <ø> (ø)`
src/styles/variables.ts	`100.00% <ø> (ø)`
...cation/GrowlNotificationContainer/index.native.tsx	`0.00% <0.00%> (-100.00%)`	⬇️
src/components/GrowlNotification/index.tsx	`66.66% <66.66%> (-33.34%)`	⬇️
...lNotification/GrowlNotificationContainer/index.tsx	`0.00% <0.00%> (ø)`
src/libs/Growl.ts	`35.29% <0.00%> (-2.21%)`	⬇️
...nts/GrowlNotification/GrowlNotificationContent.tsx	`7.31% <7.31%> (ø)`
... and 11 files with indirect coverage changes

…ce-growls-pr1

JakubKorytko

second round my man, nothing serious though

…zation

…sitions

…ce-growls-pr1

JakubKorytko

tbh this reads much cleaner. A few lifecycle and interaction edge cases stood out that are worth sanity-checking before the follow-up PR wires the action growl for real - approving since these are NAB's, good job!

melvin-bot · 2026-07-03T10:03:10Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c877a7ed30

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

situchan · 2026-07-03T10:10:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

JmillsExpensify

No product review required.

situchan

NIT: The PR body advertises a loading() indefinite variant, but no loading function is added to src/libs/Growl.ts in this diff.

borys3kk · 2026-07-03T11:17:56Z

NIT: The PR body advertises a loading() indefinite variant, but no loading function is added to src/libs/Growl.ts in this diff.

removed it from the pr body as it's no longer implemented

MelvinBot · 2026-07-03T11:19:23Z

🤖 Code review

Solid, well-commented refactor. Splitting the visible UI into GrowlNotificationContent so the shell no longer subscribes to theme/responsive/navigation contexts is a genuine improvement — the shell won't re-render on every screen/focus change, and the growl DOM is fully unmounted between shows. The nonce-guarded dismissal correctly handles the stale slide-out race (a replacement growl remounts with its own shared value, and the parent ignores dismissals whose nonce no longer matches). No behavior change for the existing (action-less) growls, which matches the PR's "dormant groundwork" intent.

A few things worth addressing before this lands:

1. Native container ignores useBottomPosition → latent bug for action growls on wide native layouts (iPad).
GrowlNotificationContent.tsx:66 derives useBottomPosition = !!action && !shouldUseNarrowLayout and, when true, sets inactiveY to the positive (bottom) offset. But the native container GrowlNotificationContainer/index.native.tsx:10 dropped the useBottomPosition param and always renders the top-anchored container. On a wide native layout (e.g. iPad, where shouldUseNarrowLayout can be false), an action growl would get inactiveY = +255 while being top-anchored — so the "hidden" state translates downward into the screen instead of off the top, and the fling direction would be DOWN against a top anchor. No current impact (nothing passes action yet), but this will bite the moment the "Expense added" action growl ships on native. Either make the native container honor useBottomPosition too, or explicitly force useBottomPosition = false on native.

2. PR description mentions a loading() variant that isn't in the diff.
The description says it adds "a new loading() indefinite variant," but Growl.ts only exports show / error / success. Either the description is stale or the code is missing — please reconcile so reviewers aren't looking for something that isn't there.

3. Author checklist vs. tests. The checklist has "I added unit tests" checked, but no tests are included and Codecov flags a coverage drop. The nonce-guard / stale-dismissal logic is the subtlest part of this change and is exactly what a small unit test would protect. "N/A – dormant groundwork" is a defensible call, but then that checkbox shouldn't be checked.

Minor / non-blocking

useImperativeHandle(ref, () => ({show}), [show]) in index.tsx — show is no longer memoized (was useCallback before), so the handle is recreated every render. Harmless (functional setContent updater), just noting the behavior change.
CONST.GROWL.OFFSCREEN_OFFSET = 255 is a magic offscreen distance; the comment acknowledges it only needs to exceed growl height + margins, so fine.
linkReversed / buttonHoveredBGReversed map to existing palette colors in both themes — verified they resolve.

I reviewed this at the code level against the PR head; I did not runtime-verify the slide animation on each platform, so please confirm the visual behavior (especially the bottom-right action layout on wide web) during QA.

Reply with @MelvinBot <feedback> to refine this review.

situchan

Above review comments are not blockers but let's make sure to test tablet landscape in implementation PR

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c877a7ed30

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

borys3kk · 2026-07-03T11:36:44Z

🤖 Code review

Solid, well-commented refactor. Splitting the visible UI into GrowlNotificationContent so the shell no longer subscribes to theme/responsive/navigation contexts is a genuine improvement — the shell won't re-render on every screen/focus change, and the growl DOM is fully unmounted between shows. The nonce-guarded dismissal correctly handles the stale slide-out race (a replacement growl remounts with its own shared value, and the parent ignores dismissals whose nonce no longer matches). No behavior change for the existing (action-less) growls, which matches the PR's "dormant groundwork" intent.

A few things worth addressing before this lands:

1. Native container ignores useBottomPosition → latent bug for action growls on wide native layouts (iPad). GrowlNotificationContent.tsx:66 derives useBottomPosition = !!action && !shouldUseNarrowLayout and, when true, sets inactiveY to the positive (bottom) offset. But the native container GrowlNotificationContainer/index.native.tsx:10 dropped the useBottomPosition param and always renders the top-anchored container. On a wide native layout (e.g. iPad, where shouldUseNarrowLayout can be false), an action growl would get inactiveY = +255 while being top-anchored — so the "hidden" state translates downward into the screen instead of off the top, and the fling direction would be DOWN against a top anchor. No current impact (nothing passes action yet), but this will bite the moment the "Expense added" action growl ships on native. Either make the native container honor useBottomPosition too, or explicitly force useBottomPosition = false on native.

2. PR description mentions a loading() variant that isn't in the diff. The description says it adds "a new loading() indefinite variant," but Growl.ts only exports show / error / success. Either the description is stale or the code is missing — please reconcile so reviewers aren't looking for something that isn't there.

3. Author checklist vs. tests. The checklist has "I added unit tests" checked, but no tests are included and Codecov flags a coverage drop. The nonce-guard / stale-dismissal logic is the subtlest part of this change and is exactly what a small unit test would protect. "N/A – dormant groundwork" is a defensible call, but then that checkbox shouldn't be checked.

Minor / non-blocking

useImperativeHandle(ref, () => ({show}), [show]) in index.tsx — show is no longer memoized (was useCallback before), so the handle is recreated every render. Harmless (functional setContent updater), just noting the behavior change.

CONST.GROWL.OFFSCREEN_OFFSET = 255 is a magic offscreen distance; the comment acknowledges it only needs to exceed growl height + margins, so fine.

linkReversed / buttonHoveredBGReversed map to existing palette colors in both themes — verified they resolve.

I reviewed this at the code level against the PR head; I did not runtime-verify the slide animation on each platform, so please confirm the visual behavior (especially the bottom-right action layout on wide web) during QA.

Reply with @MelvinBot <feedback> to refine this review.

Replied in the comment thread
Removed it from the pr body
In the tests sectioned described that we cant test it until the second pr comes

borys3kk · 2026-07-03T11:46:06Z

all comments resolved so it's good to go

mountiny

Thank you! All comments are NAB

mountiny · 2026-07-03T15:48:21Z

+type GrowlNotificationContentProps = {
+    bodyText: string;
+    type: GrowlType;
+    duration: number;
+    action?: GrowlAction;
+
+    /** Identifies this growl instance; passed back through onDismissed so the parent can ignore stale dismissals. */
+    nonce: number;
+    onDismissed: (dismissedNonce: number) => void;
+};


lets add docs to all type props

mountiny · 2026-07-03T15:48:27Z

+        icon: React.FC<SvgProps> | IconAsset;
+        iconColor: string;


mountiny · 2026-07-03T15:48:43Z

+type GrowlContent = {
+    bodyText: string;
+    type: GrowlType;
+    duration: number;
+    action?: GrowlAction;



mountiny · 2026-07-03T15:49:01Z

+    label: string;
+    onPress: () => void;


OSBotify · 2026-07-03T15:56:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-03T16:06:56Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-03T16:13:05Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94865.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-214f9e6b637-d075f5f-18b483f72e07b899a607beaa280bffd4260d335d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-214f9e6-d075f5f-dd5ffb1c27f82ea17fbd8caa317943730af73837/index.html

Web 🕸️
https://94865.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-03T16:44:00Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.27-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-03T16:45:30Z

🤖 Help site review: no documentation changes required.

This PR adds dormant capability to the in-app Growl notification component (an optional action button, a loading() variant, and supporting CONST.GROWL durations/styles/theme colors). Per the PR description and the Tests/QA sections, there is no user-facing behavior change — the growls aren't wired to any new user flow yet, and existing growls behave identically. It's groundwork for a future "Expense added" growl.

Because of that:

No feature, tab, setting, or button visible to customers is added or changed by this PR.
The help site (App/docs/articles) contains zero references to growls/toasts, so there is nothing to update or keep in sync.

I did not create a docs draft PR, since there's no customer-facing behavior to document and there's no linked help-site PR to review. When the follow-up PR actually surfaces the "Expense added" growl with a "View" deep link to users, that's the point at which a help-site update may be warranted (if that flow is documented) — feel free to re-run @MelvinBot on that PR.

borys3kk, if you disagree and there's a specific customer-facing flow you'd like documented, reply with the details and I'll draft the help-site PR.

OSBotify · 2026-07-06T15:32:04Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

[No QA] Growl: add action button and loading variant

ab770c0

melvin-bot Bot assigned borys3kk Jun 29, 2026

JakubKorytko reviewed Jun 30, 2026

View reviewed changes

borys3kk added 3 commits June 30, 2026 15:25

add explanatory comment

b0d860f

add withSpring instead of fixed timeout, add comment explaining the I…

e77e084

…NACTIVE_OFFSET

remove useCallbacks

bc957c8

borys3kk added 6 commits June 30, 2026 17:47

remove array wrappers

5d12eaf

remove useCallbacks

4c36043

make the api symmetric for error growls, add duration resolving

f9f500f

resolve remaining review comments

ed1f236

Merge branch 'main' of github.com:Expensify/App into borys3kk-introdu…

c6a3422

…ce-growls-pr1

resolve remaining review comments

36cb579

JakubKorytko reviewed Jul 1, 2026

View reviewed changes

borys3kk added 4 commits July 2, 2026 13:57

remove loading variant (unused in the final pr), removed manual memoi…

bec756a

…zation

make growlNotificationInset shared const for growls top and bottom po…

85bc577

…sitions

fix spellcheck

bacfb7c

Merge branch 'main' of github.com:Expensify/App into borys3kk-introdu…

90c585d

…ce-growls-pr1

JakubKorytko approved these changes Jul 2, 2026

View reviewed changes

borys3kk added 3 commits July 3, 2026 11:38

fix last review comments

4b2a06c

merge main

46171be

fix fmt

c877a7e

borys3kk marked this pull request as ready for review July 3, 2026 10:03

borys3kk requested review from a team as code owners July 3, 2026 10:03

melvin-bot Bot requested review from JmillsExpensify and situchan and removed request for a team July 3, 2026 10:03

melvin-bot Bot removed the request for review from a team July 3, 2026 10:03

chatgpt-codex-connector Bot reviewed Jul 3, 2026

View reviewed changes

Comment thread src/components/GrowlNotification/index.tsx Outdated

JmillsExpensify reviewed Jul 3, 2026

View reviewed changes

situchan reviewed Jul 3, 2026

View reviewed changes

Comment thread src/components/GrowlNotification/GrowlNotificationContainer/index.native.tsx

Comment thread src/styles/index.ts

fix codex review comment

d9bb03d

situchan approved these changes Jul 3, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny July 3, 2026 11:19

chatgpt-codex-connector Bot reviewed Jul 3, 2026

View reviewed changes

Comment thread src/components/GrowlNotification/index.tsx Outdated

mountiny approved these changes Jul 3, 2026

View reviewed changes

mountiny merged commit 214f9e6 into Expensify:main Jul 3, 2026
41 of 42 checks passed

OSBotify mentioned this pull request Jul 3, 2026

Deploy Checklist: New Expensify 2026-07-03 #95291

Closed

98 tasks

melvin-bot Bot mentioned this pull request Jul 6, 2026

[Due for payment 2026-07-13] Confirm new expenses with a “View” toast on Spend instead of scrolling to and highlighting the row #91408

Open

borys3kk mentioned this pull request Jul 7, 2026

Confirm new expenses with a “View” toast on Spend instead of scrolling to and highlighting the row #91214

Closed

52 tasks

Uh oh!

Conversation

borys3kk commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

JakubKorytko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jun 30, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JakubKorytko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JakubKorytko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

melvin-bot Bot commented Jul 3, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

situchan commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

borys3kk commented Jul 3, 2026

Uh oh!

MelvinBot commented Jul 3, 2026

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

borys3kk commented Jul 3, 2026

borys3kk commented Jun 29, 2026 •

edited

Loading

codecov Bot commented Jun 30, 2026 •

edited by github-actions Bot

Loading

situchan commented Jul 3, 2026 •

edited

Loading