Revert "Migrate InteractionManager - (Newly added usages) batch 1"#95201
Revert "Migrate InteractionManager - (Newly added usages) batch 1"#95201marcochavezf wants to merge 5 commits into
Conversation
Resolve the Search bulk actions conflict by keeping the bulk-delete modal dismiss deferral from main while restoring the remaining selection-clear deferrals from the revert.
Combine the chat and grouped-expense Search render paths after merging main so the component declares searchListContent only once.
melvin-bot
Bot
requested review from
blimpich and
heyjennahay
and removed request for
a team
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8ed9c0055f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| useEffect(() => { | ||
| if (hasDeniedContactImportPrompt) { |
There was a problem hiding this comment.
When the native participant picker mounts, HAS_DENIED_CONTACT_IMPORT_PROMPT can still be loading. This one-shot effect treats the initial undefined as not denied and starts the permission check; for users who previously tapped “No thanks” while OS contacts permission is still DENIED, the soft prompt can be shown again before the persisted opt-out arrives, or the opt-out can arrive first and the effect will never rerun to call onFocusTextInput, leaving the input with autofocus disabled. Please wait for the Onyx metadata to load or rerun the flow when the loaded value changes.
Useful? React with 👍 / 👎.
Resolve the Search render conflict by keeping the latest dedicated view branches from main while preserving the InteractionManager revert changes. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep the InteractionManager revert scoped by removing the accidental Search render diff from the merge resolution. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@marcochavezf is this a straight revert? If not can you please point out what had to change to fix conflicts, and also please update the PR description with more context on why this was reverted. A link to a slack conversation perhaps? |
|
Ah, please ignore this PR, I created it to see if it was feasible to create a straight revert of an offending PR, but the deploy blocker is already handled. More details here https://expensify.slack.com/archives/C01GTK53T8Q/p1782968322508229 |
2 participants
Reverts #94171