Sub-issue of #94595.
Source plan: fabioh8010 comment.
Goal
Remove the deprecated 3rd dependencies argument from low-risk shared data hooks (PURE-DROP only).
Scope (13 files, all PURE-DROP)
hooks/useActiveAdminPolicies
hooks/useDefaultFundID
hooks/useExpensifyCardFeeds
hooks/useHasPerDiemTransactions
hooks/useOnboardingTaskInformation
hooks/usePaginatedReportActions
hooks/useParentReportAction
hooks/usePaymentOptions
hooks/usePolicyData/index
hooks/usePolicyForTransaction
hooks/useSplitEffectivePolicy
hooks/useDistanceRateOriginalPolicy
hooks/useTransactionThread
Change types
PURE-DROP — delete the , [deps] arg only; selector already stable.
Risk
Low — behavior-preserving.
Dependencies
Blocked by PR 1 (ESLint guard) merged.
Tests / QA
Open a workspace/expense report and a chat; confirm policies, payment options, per-diem, paginated report actions, and transactions all load. Emphasize npm run test + typecheck (pure no-ops).
Acceptance criteria
npm run fmt on changed files
npm run lint-changed — seatbelt count for rulesdir/no-useonyx-dependencies-arg must drop (never increase)
npm run typecheck stays green
npm run react-compiler-compliance-check check <files> — USECALLBACK/bailout files must not gain new failures vs main
- Relevant
npm run test for touched areas
- Manual smoke test per batch QA steps — no stale data, infinite re-renders, or JS console errors
Issue Owner
Current Issue Owner: @hoangzinh
Sub-issue of #94595.
Source plan: fabioh8010 comment.
Goal
Remove the deprecated 3rd
dependenciesargument from low-risk shared data hooks (PURE-DROP only).Scope (13 files, all PURE-DROP)
hooks/useActiveAdminPolicieshooks/useDefaultFundIDhooks/useExpensifyCardFeedshooks/useHasPerDiemTransactionshooks/useOnboardingTaskInformationhooks/usePaginatedReportActionshooks/useParentReportActionhooks/usePaymentOptionshooks/usePolicyData/indexhooks/usePolicyForTransactionhooks/useSplitEffectivePolicyhooks/useDistanceRateOriginalPolicyhooks/useTransactionThreadChange types
PURE-DROP — delete the
, [deps]arg only; selector already stable.Risk
Low — behavior-preserving.
Dependencies
Blocked by PR 1 (ESLint guard) merged.
Tests / QA
Open a workspace/expense report and a chat; confirm policies, payment options, per-diem, paginated report actions, and transactions all load. Emphasize
npm run test+ typecheck (pure no-ops).Acceptance criteria
npm run fmton changed filesnpm run lint-changed— seatbelt count forrulesdir/no-useonyx-dependencies-argmust drop (never increase)npm run typecheckstays greennpm run react-compiler-compliance-check check <files>— USECALLBACK/bailout files must not gain new failures vsmainnpm run testfor touched areasIssue Owner
Current Issue Owner: @hoangzinh