Skip to content

[Split #94595] Batch A - Remove useOnyx deps from low-risk shared hooks #95574

Description

@mountiny

Sub-issue of #94595.
Source plan: fabioh8010 comment.

Goal

Remove the deprecated 3rd dependencies argument from low-risk shared data hooks (PURE-DROP only).

Scope (13 files, all PURE-DROP)

  • hooks/useActiveAdminPolicies
  • hooks/useDefaultFundID
  • hooks/useExpensifyCardFeeds
  • hooks/useHasPerDiemTransactions
  • hooks/useOnboardingTaskInformation
  • hooks/usePaginatedReportActions
  • hooks/useParentReportAction
  • hooks/usePaymentOptions
  • hooks/usePolicyData/index
  • hooks/usePolicyForTransaction
  • hooks/useSplitEffectivePolicy
  • hooks/useDistanceRateOriginalPolicy
  • hooks/useTransactionThread

Change types

PURE-DROP — delete the , [deps] arg only; selector already stable.

Risk

Low — behavior-preserving.

Dependencies

Blocked by PR 1 (ESLint guard) merged.

Tests / QA

Open a workspace/expense report and a chat; confirm policies, payment options, per-diem, paginated report actions, and transactions all load. Emphasize npm run test + typecheck (pure no-ops).

Acceptance criteria

  1. npm run fmt on changed files
  2. npm run lint-changed — seatbelt count for rulesdir/no-useonyx-dependencies-arg must drop (never increase)
  3. npm run typecheck stays green
  4. npm run react-compiler-compliance-check check <files> — USECALLBACK/bailout files must not gain new failures vs main
  5. Relevant npm run test for touched areas
  6. Manual smoke test per batch QA steps — no stale data, infinite re-renders, or JS console errors
Issue OwnerCurrent Issue Owner: @hoangzinh

Metadata

Metadata

Type

No type

Fields

No fields configured for issues without a type.

Projects

Status
SUBISSUE

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions