Sub-issue of #94595.
Source plan: fabioh8010 comment.
Goal
Remove the deprecated 3rd dependencies argument from transaction/report/policy shared hooks.
Scope (12 files)
hooks/useReportTransactions
hooks/useTransactionsByID
hooks/useTransactionViolation
hooks/useTransactionViolationOfWorkspace
hooks/useTripTransactions
hooks/useResetBankAccountModal
hooks/useReportPrimaryAction
hooks/useSelectionModeReportActions
hooks/useShouldShowEmptyReportConfirmation
hooks/useShowNotFoundPageInIOUStep
hooks/useParticipantsPolicies (RESTRUCTURE)
hooks/useParticipantsPolicyTags (RESTRUCTURE)
Change types
INLINE + 2 RESTRUCTURE files (useParticipantsPolicies, useParticipantsPolicyTags — factory signature participants → policyIDs).
Risk
Medium — review the 2 RESTRUCTURE files closely.
Dependencies
Blocked by PR 1 (ESLint guard) merged.
Tests / QA
Open an expense report with transactions & violations; open a Trip room (trip transactions); reject/submit flows; participant-policy pickers — verify correct policies/tags resolve.
Acceptance criteria
npm run fmt on changed files
npm run lint-changed — seatbelt count for rulesdir/no-useonyx-dependencies-arg must drop (never increase)
npm run typecheck stays green
npm run react-compiler-compliance-check check <files> — USECALLBACK/bailout files must not gain new failures vs main
- Relevant
npm run test for touched areas
- Manual smoke test per batch QA steps — no stale data, infinite re-renders, or JS console errors
Issue Owner
Current Issue Owner: @hoangzinh
Sub-issue of #94595.
Source plan: fabioh8010 comment.
Goal
Remove the deprecated 3rd
dependenciesargument from transaction/report/policy shared hooks.Scope (12 files)
hooks/useReportTransactionshooks/useTransactionsByIDhooks/useTransactionViolationhooks/useTransactionViolationOfWorkspacehooks/useTripTransactionshooks/useResetBankAccountModalhooks/useReportPrimaryActionhooks/useSelectionModeReportActionshooks/useShouldShowEmptyReportConfirmationhooks/useShowNotFoundPageInIOUStephooks/useParticipantsPolicies(RESTRUCTURE)hooks/useParticipantsPolicyTags(RESTRUCTURE)Change types
INLINE + 2 RESTRUCTURE files (
useParticipantsPolicies,useParticipantsPolicyTags— factory signatureparticipants → policyIDs).Risk
Medium — review the 2 RESTRUCTURE files closely.
Dependencies
Blocked by PR 1 (ESLint guard) merged.
Tests / QA
Open an expense report with transactions & violations; open a Trip room (trip transactions); reject/submit flows; participant-policy pickers — verify correct policies/tags resolve.
Acceptance criteria
npm run fmton changed filesnpm run lint-changed— seatbelt count forrulesdir/no-useonyx-dependencies-argmust drop (never increase)npm run typecheckstays greennpm run react-compiler-compliance-check check <files>— USECALLBACK/bailout files must not gain new failures vsmainnpm run testfor touched areasIssue Owner
Current Issue Owner: @hoangzinh