recalculate only changed options in OptionListContextProvider by TMisiukiewicz · Pull Request #60264 · Expensify/App

TMisiukiewicz · 2025-04-15T10:39:43Z

Explanation of Change

Currently all options are recomputed each time any report in a collection changes. This solution updates only changed reports, saving time and resources.

Fixed Issues

$ #59825
PROPOSAL:

Tests

Go to Reports tab
Press autocomplete input
Go to the report from the top of the list
Send message
Go to Reports tab
Press autocomplete input
Verify the message you sent is visible as a subtitle of the item

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-web.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

…anged-options

melvin-bot · 2025-04-16T14:11:36Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2025-04-16T18:04:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Unable to build android

Android: mWeb Chrome

Screen.Recording.2025-04-18.at.11.44.20.PM.mov

iOS: Native

Screen.Recording.2025-04-19.at.12.03.07.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-04-18.at.11.37.46.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-04-18.at.11.19.34.PM.mov

MacOS: Desktop

Screen.Recording.2025-04-18.at.11.35.11.PM.mov

mountiny · 2025-04-17T19:38:41Z

@allroundexperts Can you prioritise this one please? thanks!

allroundexperts · 2025-04-18T12:18:28Z

On it today

allroundexperts · 2025-04-18T18:23:33Z

The report autocomplete shows thread as the subtitle.

Screen.Recording.2025-04-18.at.11.20.50.PM.mov

Is this expected?

allroundexperts · 2025-04-18T18:32:00Z

Screen.Recording.2025-04-18.at.11.26.57.PM.mov

Two bugs here.

After I delete the message, it shows a new entry called deleted message after I refresh.
The workspace which appeared at position 3 no longer is there after deleting the message.

mountiny · 2025-04-19T15:38:59Z

Is this expected?

Do you see this in main? I am not sure about this one so if its in main that its probably fine, if not, its probs a bug

allroundexperts · 2025-04-22T00:18:12Z

Confirmed on main. I was not able to see any of the above. @TMisiukiewicz Can you please verify?

TMisiukiewicz · 2025-04-22T10:04:04Z

yeah I'll check it out

TMisiukiewicz · 2025-04-22T13:32:28Z

All the reported things are reproducible on main

mountiny · 2025-04-22T13:36:17Z

@allroundexperts can you please verify again?

allroundexperts · 2025-04-23T00:06:04Z

@TMisiukiewicz Please resolve the conflicts. Also, the perf tests are failing?

…anged-options

TMisiukiewicz · 2025-04-23T13:37:00Z

@allroundexperts should be good now

allroundexperts

Works good!

mountiny · 2025-04-24T20:36:50Z

@TMisiukiewicz can you please resolve the conflicts?

…anged-options

TMisiukiewicz · 2025-04-25T06:44:59Z

@mountiny done ✅

mountiny

Changes look good to me, @dangrous do you want to review too?

@TMisiukiewicz @allroundexperts maybe a dumb question but is there a risk if this context is created for signed in user to see any weird issues once this is deployed and we change how the context is behaving? It is not clear to me from the code if there could be some issues or not, but wanted to raise this

TMisiukiewicz · 2025-04-25T15:33:44Z

@mountiny If i understand your concern correctly, it should not affect anyone. These context values are not stored in any persistent way. They are generated from scratch each time user opens/refreshes the app and additionally has to visit any Search page to initialize this. I think we should be safe then

mountiny · 2025-04-25T19:31:49Z

Sounds good, thanks for confirming. I was not sure if the context was already initialized and we do this update on web in the background, if any issue could occur.

dangrous

minor typo, looks good otherwise!

dangrous · 2025-04-25T19:37:37Z


    /**
-     * This effect is used to update the options list when reports change.
+     * This effect is responsible for generating the options list when there data is not yet initialized


Suggested change

* This effect is responsible for generating the options list when there data is not yet initialized

* This effect is responsible for generating the options list when their data is not yet initialized

thanks, fixed ✅

…ged-options

…anged-options

dangrous

Great, thanks! @mountiny do you want a last look?

dangrous · 2025-04-28T15:40:37Z

oh wait we've got some more canBeMissing updates needed, sigh

…anged-options

TMisiukiewicz · 2025-04-29T06:15:35Z

@dangrous should be good now

dangrous · 2025-04-29T15:41:46Z

Gonna go ahead and merge this one!

OSBotify · 2025-04-29T15:50:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-04-30T01:05:56Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.1.38-0 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-05-01T19:35:55Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.38-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

dukenv0307 · 2025-12-15T15:36:09Z

+                return prevOptions;
+            }
+
+            const updatedReportsMap = new Map(prevOptions.reports.map((report) => [report.reportID, report]));


Coming from #74230, the report can be undefined, so we need to add the safeguard here

TMisiukiewicz added 3 commits April 14, 2025 14:35

recalculate only changed options in option context provider

010fde6

fix processing changed options

ea2c3d8

Merge remote-tracking branch 'upstream/main' into perf/recalculate-ch…

dd1e057

…anged-options

This was referenced Apr 15, 2025

[Due for payment 2025-05-30] [CRITICAL] Investigate performance issues when deleting expenses from Reports page #59825

Closed

expose sourceValue in useOnyx hook Expensify/react-native-onyx#627

Merged

TMisiukiewicz added 4 commits April 15, 2025 14:56

Merge branch 'main' into perf/recalculate-changed-options

7fa608c

Merge branch 'main' into perf/recalculate-changed-options

f30027e

Merge branch 'main' into perf/recalculate-changed-options

a77ca6c

update canBeMissing

1a6c0b9

TMisiukiewicz force-pushed the perf/recalculate-changed-options branch from 399f03b to 1a6c0b9 Compare April 16, 2025 09:55

TMisiukiewicz added 2 commits April 16, 2025 13:58

unify usage of creating options

aa62626

recreate options after report attributes are regenerated

cd599df

TMisiukiewicz marked this pull request as ready for review April 16, 2025 14:11

TMisiukiewicz requested a review from a team as a code owner April 16, 2025 14:11

melvin-bot Bot requested review from allroundexperts and removed request for a team April 16, 2025 14:11

mountiny assigned TMisiukiewicz Apr 17, 2025

Merge branch 'main' into perf/recalculate-changed-options

e0c8858

Merge branch 'main' into perf/recalculate-changed-options

d83b803

Merge remote-tracking branch 'upstream/main' into perf/recalculate-ch…

bc2ad1b

…anged-options

allroundexperts approved these changes Apr 23, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny April 23, 2025 20:45

Merge remote-tracking branch 'upstream/main' into perf/recalculate-ch…

4b7a275

…anged-options

mountiny requested a review from dangrous April 25, 2025 14:33

mountiny previously approved these changes Apr 25, 2025

View reviewed changes

dangrous requested changes Apr 25, 2025

View reviewed changes

TMisiukiewicz added 3 commits April 28, 2025 08:00

Merge remote-tracking branch 'origin/main' into perf/recalculate-chan…

a208f34

…ged-options

Merge remote-tracking branch 'upstream/main' into perf/recalculate-ch…

dfad5d1

…anged-options

fix typo

4fa7376

TMisiukiewicz dismissed mountiny’s stale review via 4fa7376 April 28, 2025 06:06

TMisiukiewicz requested a review from dangrous April 28, 2025 06:06

dangrous approved these changes Apr 28, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/main' into perf/recalculate-ch…

9d61b4a

…anged-options

dangrous merged commit 53d9bc4 into Expensify:main Apr 29, 2025
15 checks passed

github-actions Bot mentioned this pull request Apr 30, 2025

Deploy Checklist: New Expensify 2025-04-30 #61122

Closed

50 tasks

brunovjk mentioned this pull request May 5, 2025

[Due for payment 2025-05-22] [$250] Group - After leaving the group, it remains in the search. #61291

Closed

8 tasks

dukenv0307 reviewed Dec 15, 2025

View reviewed changes

	* This effect is responsible for generating the options list when there data is not yet initialized
	* This effect is responsible for generating the options list when their data is not yet initialized

Conversation

TMisiukiewicz commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Apr 16, 2025

Uh oh!

allroundexperts commented Apr 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny commented Apr 17, 2025

Uh oh!

allroundexperts commented Apr 18, 2025

Uh oh!

allroundexperts commented Apr 18, 2025

Uh oh!

allroundexperts commented Apr 18, 2025

Uh oh!

mountiny commented Apr 19, 2025

Uh oh!

allroundexperts commented Apr 22, 2025

Uh oh!

TMisiukiewicz commented Apr 22, 2025

Uh oh!

TMisiukiewicz commented Apr 22, 2025

Uh oh!

mountiny commented Apr 22, 2025

Uh oh!

allroundexperts commented Apr 23, 2025

Uh oh!

TMisiukiewicz commented Apr 23, 2025

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny commented Apr 24, 2025

Uh oh!

TMisiukiewicz commented Apr 25, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz commented Apr 25, 2025

Uh oh!

mountiny commented Apr 25, 2025

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

dangrous Apr 25, 2025

Choose a reason for hiding this comment

Uh oh!

TMisiukiewicz Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

dangrous left a comment

Choose a reason for hiding this comment

Uh oh!

dangrous commented Apr 28, 2025

Uh oh!

TMisiukiewicz commented Apr 29, 2025

Uh oh!

dangrous commented Apr 29, 2025

Uh oh!

Uh oh!

OSBotify commented Apr 29, 2025

Uh oh!

github-actions Bot commented Apr 30, 2025

Uh oh!

github-actions Bot commented May 1, 2025

Uh oh!

dukenv0307 Dec 15, 2025

TMisiukiewicz commented Apr 15, 2025 •

edited

Loading

allroundexperts commented Apr 16, 2025 •

edited

Loading