chore: bump react-native-onyx version to 2.0.102#60837
chore: bump react-native-onyx version to 2.0.102#60837roryabraham merged 1 commit intoExpensify:mainfrom
Conversation
|
|
fabioh8010
left a comment
There was a problem hiding this comment.
@Swor71 Since you are bumping from 2.0.100 to 2.0.102, we have two versions here. Could you check the diff between the versions and assert it's safe to just bump in this PR?
the previous version was due to onyx reassure phase 1, which is exclusive to onyx in regards to testing, shouldn't be a problem to do the bump |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2025-04-29.at.1.24.10.PM.movAndroid: mWeb ChromeScreen.Recording.2025-04-29.at.1.20.13.PM.moviOS: NativeiOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-04-29.at.13.17.12.mp4MacOS: Chrome / SafariScreen.Recording.2025-04-29.at.1.10.49.PM.movMacOS: DesktopScreen.Recording.2025-04-29.at.1.18.15.PM.mov |
rayane-d
left a comment
There was a problem hiding this comment.
I conducted some smoke tests to ensure that the app opens, the main functionalities work well, and the PR tests successfully. 👍
Note: This PR includes changes from PR Expensify/react-native-onyx#630 and Expensify/react-native-onyx#631
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.1.38-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.1.38-4 🚀
|
Explanation of Change
This PR bumps version of
react-native-onyxto2.0.102which includes recent refactor of for loops to for..of loops as per this issueFixed Issues
$ #60726
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop