feat: Gather KYB documents when verification fails for USD BA's by MrMuzyk · Pull Request #76033 · Expensify/App

MrMuzyk · 2025-11-25T14:53:23Z

Explanation of Change

Added a new step to USD VBBA flow that is conditionally showed if user failed automated verification

Fixed Issues

$ #75707
PROPOSAL:

Tests

Same as QA steps

Verify that no errors appear in the JS console

Testing this requires to have an account that was manually set to a certain state, ie: #75707 (comment)

We will make sure that current functionality works without any issues, ship the new step and look out for regressions - https://expensify.slack.com/archives/C01GTK53T8Q/p1778070528787499?thread_ts=1763989665.580719&cid=C01GTK53T8Q

Offline tests

QA Steps

Verify you can connect USD bank account to USD workspace without any issue

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios-native.mp4

iOS: mWeb Safari

ios.web.mp4

MacOS: Chrome / Safari

web.mp4

melvin-bot · 2025-11-25T14:53:29Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2025-11-25T15:01:51Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.30% <ø> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
.../ReimbursementAccount/ReimbursementAccountPage.tsx	`0.00% <ø> (ø)`
...mentAccount/USD/USDVerifiedBankAccountFlowPage.tsx	`0.00% <ø> (ø)`
src/types/form/ReimbursementAccountForm.ts	`100.00% <ø> (ø)`
src/libs/actions/BankAccounts.ts	`9.96% <0.00%> (-0.08%)`	⬇️
...unt/USD/utils/isUserAddressVerificationRequired.ts	`0.00% <0.00%> (ø)`
...Account/USD/utils/isUserDOBVerificationRequired.ts	`0.00% <0.00%> (ø)`
...es/ReimbursementAccount/USD/KYBDocuments/index.tsx	`0.00% <0.00%> (ø)`
... and 30 files with indirect coverage changes

…07-usd-flow-kyb-files

melvin-bot · 2026-05-08T11:55:06Z

@gijoe0295 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec512c7955

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-08T12:01:37Z

+        );
+
+    const defaultValues = {
+        companyTaxID: reimbursementAccountDraft?.companyTaxID ?? [],


Avoid reusing companyTaxID form key for KYB file uploads

This uses the same key as the business Tax ID text field (companyTaxID) but treats it as FileObject[] on this page. When a draft contains a prior Tax ID string (e.g., from editing), uploadedFiles.companyTaxID is initialized with that string and later spread/serialized as files, which can send invalid payload data (first character of the string) instead of an uploaded file. Use a distinct upload field key and map it explicitly to the API parameter to avoid cross-step type collisions.

Useful? React with 👍 / 👎.

MrMuzyk · 2026-05-08T12:05:33Z

Requested confirmation of translations

trjExpensify · 2026-05-11T12:51:39Z

I think @joekaufmanexpensify is best suited for the product review of this one. Looks okay to me though!

This reverts commit 2a6276e.

joekaufmanexpensify · 2026-05-12T12:48:01Z

Nice, I'll take a look!

gijoe0295

Haven't been able to test this because site is down

gijoe0295 · 2026-05-12T18:19:02Z

+        userAddressVerificationDescription: dedent(`
+            Please upload one of the following files:
+            • Voter Registration Card
+            • Drivers License


Suggested change

• Drivers License

• Driver's License

gijoe0295 · 2026-05-12T18:22:44Z

+    /** Statuses of additional checks hinting at missing documents user still needs to upload */
+    verifications?: {
+        /** points towards one of external providers */
+        externalApiResponse?: {


Mismatch with backend screenshot here #75707 (comment)

Suggested change

externalApiResponse?: {

externalApiResponses?: {

gijoe0295 · 2026-05-12T18:25:42Z

+          }>
+        | undefined,
+): boolean {
+    return status !== 'pass' && !!CONST.BANK_ACCOUNT.KYB_REQUESTOR_IDENTITY_ERROR.DOB.find((error) => qualifiers?.map((qualifier) => qualifier.key).includes(error));


Please create a constant for 'pass' in CONST/index.ts.

Also why don't we check exact match === here?

We agreed that anything else than 'pass' status is enough to require a document from user

gijoe0295 · 2026-05-12T18:37:12Z

                [CONST.BANK_ACCOUNT.STEP.COMPANY]: CONST.BANK_ACCOUNT.PAGE_NAMES.COMPANY,
                [CONST.BANK_ACCOUNT.STEP.BENEFICIAL_OWNERS]: CONST.BANK_ACCOUNT.PAGE_NAMES.BENEFICIAL_OWNERS,
                [CONST.BANK_ACCOUNT.STEP.ACH_CONTRACT]: CONST.BANK_ACCOUNT.PAGE_NAMES.ACH_CONTRACT,
+                [CONST.BANK_ACCOUNT.STEP.KYB_DOCS]: CONST.BANK_ACCOUNT.PAGE_NAMES.KYB_DOCS,


I can't see we navigate to this step any where in App. Is it controlled by the backend?

The step is set by BE, yes - https://expensify.slack.com/archives/C01GTK53T8Q/p1764762713169849?thread_ts=1763989665.580719&cid=C01GTK53T8Q

gijoe0295 · 2026-05-12T18:47:03Z

+    const [betas] = useOnyx(ONYXKEYS.BETAS);
+    const [isSelfTourViewed] = useOnyx(ONYXKEYS.NVP_ONBOARDING, {selector: hasSeenTourSelector});
+    const {accountID: currentUserAccountID} = useCurrentUserPersonalDetails();
+    const reimbursementAccountData = reimbursementAccount?.achData?.verifications?.externalApiResponse;


Suggested change

const reimbursementAccountData = reimbursementAccount?.achData?.verifications?.externalApiResponse;

const reimbursementAccountVerificationData = reimbursementAccount?.achData?.verifications?.externalApiResponse;

gijoe0295 · 2026-05-12T18:48:41Z

Can we move these functions to BankAccountUtils? I believe there could be more similar ones in the future.

gijoe0295 · 2026-05-12T18:51:30Z

+    const validate = (values: FormOnyxValues<typeof ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM>): FormInputErrors<typeof ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM> => {
+        const errors: FormInputErrors<typeof ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM> = {};
+
+        for (const document of DOCUMENTS_CONFIG.filter((documentItem) => documentItem.required)) {


Suggested change

for (const document of DOCUMENTS_CONFIG.filter((documentItem) => documentItem.required)) {

for (const document of requiredDocuments) {

joekaufmanexpensify · 2026-05-12T20:45:56Z

This is just for Tincheck/LexisNexis/IDology, yeah ? I see the mocks in the GH issue mention GIACT, but then there is no mention of that in the detailed description.

MrMuzyk · 2026-05-13T06:49:45Z

Hey, the PR that this was held on was reverted so we need to wait a bit here before moving forward - Im currently fixing the issues that caused the revert - after that I'll get back to it.

This is just for Tincheck/LexisNexis/IDology, yeah ? I see the mocks in the GH issue mention GIACT, but then there is no mention of that in the detailed description.

Maybe @madmax330 can answer that - I was just told the fields to look out for 😅 If I remember correctly GIACT error is appearing in response already but we're not acting on the error in any way.

…pensify-App into feat/75707-usd-flow-kyb-files

MrMuzyk · 2026-05-18T10:49:49Z

@gijoe0295

I've applied or responded to all of the comments, thank you. The PR that its is being held on right now is still in review. Hopefully we will be able to proceed here soon.

Let me know if you have any more comments regarding the code itself here. This was developed over spans of many months as various BE adjustments were needed. This thread might be helpful for you to get whole context

MrMuzyk · 2026-05-25T14:30:15Z

The PR its held on is still being tested atm -> #90302 (comment)

MrMuzyk added 2 commits November 25, 2025 08:14

feat: 75707 gather KYB files for USD flow

995b846

feat: step v1

b9d72c4

melvin-bot Bot assigned MrMuzyk Nov 25, 2025

MrMuzyk added 25 commits November 26, 2025 16:17

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

a13dd26

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

6e9db69

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

f6c2536

…07-usd-flow-kyb-files

feat: new step

3f2f902

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

005850b

…07-usd-flow-kyb-files

feat: file types

d5bac0c

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

8fd1cf9

…07-usd-flow-kyb-files

feat: pause

76926e7

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

c8a0677

…07-usd-flow-kyb-files

feat: types

88ab4a4

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

e96c832

…07-usd-flow-kyb-files

feat: submit

f0f4304

fix: checks

6faea26

fix: add kyb param

840da4f

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

208d831

…07-usd-flow-kyb-files

feat: param name

3a4d54d

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

6832d65

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

1f95a69

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

d3d828b

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

d6d6cda

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

e47fa57

…07-usd-flow-kyb-files

fix: can be missing

5b0aaa7

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

f340a97

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

cada552

…07-usd-flow-kyb-files

Merge branch 'main' of https://github.com/Expensify/App into feat/757…

bf5afa5

…07-usd-flow-kyb-files

MrMuzyk requested review from a team as code owners May 8, 2026 11:55

melvin-bot Bot requested review from a team, gijoe0295 and trjExpensify and removed request for a team May 8, 2026 11:55

melvin-bot Bot requested review from JmillsExpensify and removed request for a team May 8, 2026 11:55

chatgpt-codex-connector Bot reviewed May 8, 2026

View reviewed changes

fix: false positive

8c9d9f0

trjExpensify requested review from joekaufmanexpensify and removed request for JmillsExpensify and trjExpensify May 11, 2026 12:51

MrMuzyk added 3 commits May 12, 2026 08:43

Reapply "feat: 79048 restore reverted usd flow"

5c1bbf7

This reverts commit 2a6276e.

fix: update details

9b1d68f

fix: hide date picker on navigating forward via hardware button

f7fecec

gijoe0295 suggested changes May 12, 2026

View reviewed changes

MrMuzyk added 4 commits May 14, 2026 11:18

fix: allow resubmitting after going back

6428b30

fix: reseting freshly connected acc

b6d3e94

Merge branch 'feat/79048-restore' of github.com:callstack-internal/Ex…

d3f9951

…pensify-App into feat/75707-usd-flow-kyb-files

fix: code review improvements

7a2356f

	const reimbursementAccountData = reimbursementAccount?.achData?.verifications?.externalApiResponse;
	const reimbursementAccountVerificationData = reimbursementAccount?.achData?.verifications?.externalApiResponse;

	for (const document of DOCUMENTS_CONFIG.filter((documentItem) => documentItem.required)) {
	for (const document of requiredDocuments) {

Conversation

MrMuzyk commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Nov 25, 2025

Uh oh!

codecov Bot commented Nov 25, 2025 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot May 8, 2026

Choose a reason for hiding this comment

Uh oh!

MrMuzyk commented May 8, 2026

Uh oh!

trjExpensify commented May 11, 2026

Uh oh!

joekaufmanexpensify commented May 12, 2026

Uh oh!

gijoe0295 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify commented May 12, 2026

Uh oh!

MrMuzyk commented May 13, 2026

Uh oh!

MrMuzyk commented May 18, 2026

Uh oh!

MrMuzyk commented May 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

MrMuzyk commented Nov 25, 2025 •

edited

Loading

codecov Bot commented Nov 25, 2025 •

edited by github-actions Bot

Loading