[Part 2] Onyx.connect() removal for ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS in ReportUtils.ts by ShridharGoel · Pull Request #79832 · Expensify/App

ShridharGoel · 2026-01-18T11:49:18Z

Explanation of Change

Here, we are passing archived‑report info into IOU/report selection and edit logic, and into search selection, so archived chats are consistently filtered and edit actions don’t target archived reports. We also remove the old Onyx.connect call since now all callers use the new hook‑based data.

Fixed Issues

$ #66422
PROPOSAL:

Tests

Create a workspace.
Go to #admins chat.
Send a few messages.
Go to workspace settings.
Delete the workspace.
Go to inbox.
Go to the archived admins chat (might need to search for it).
Ensure the chat shows as archived.
There should be no chat input box.

Create a new account.
In the onboarding flow, select "Manage my team's expenses"
Then, select 11-50 employees.
Select "None" in accounting software.
Select a few extra features in the next step (like tags).
Complete the flow.
Should be redirected to #admins and the tasks should show.

Archive atleast one report.
Go to any expense's details.
Click on the report row to edit the report.
Ensure it only shows non-archived report options.

Go to search.
Select any movable expense.
Go to dropdown.
Select "Move expenses".
Ensure only non-archived reports show.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Sanity testing should be enough. Everything should work as before.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-02-21.at.3.20.08.PM.mov

codecov · 2026-01-18T12:03:06Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...eyRequestConfirmationList/sections/ReportField.tsx	`85.10% <100.00%> (ø)`
src/hooks/useArchivedReportsIDSet.ts	`100.00% <100.00%> (ø)`
src/hooks/useAutoCreateTrackWorkspace.ts	`40.00% <100.00%> (ø)`
src/hooks/useOutstandingReports.ts	`93.75% <100.00%> (ø)`
src/hooks/useSearchSections.ts	`100.00% <100.00%> (ø)`
src/hooks/useSelectedTransactionsActions.ts	`76.44% <100.00%> (+0.09%)`	⬆️
.../AppNavigator/Navigators/ReportsSplitNavigator.tsx	`92.59% <100.00%> (ø)`
src/libs/ReportSecondaryActionUtils.ts	`94.63% <100.00%> (ø)`
src/libs/actions/Report/MarkAllMessageAsRead.tsx	`90.00% <100.00%> (ø)`
src/libs/navigateAfterOnboarding.ts	`79.16% <100.00%> (ø)`
... and 13 more
... and 5 files with indirect coverage changes

…ect2.2

melvin-bot · 2026-02-22T06:44:21Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…ect2.2 # Conflicts: # src/components/Search/index.tsx # src/hooks/useDeleteTransactions.ts # src/pages/OnboardingPersonalDetails/BaseOnboardingPersonalDetails.tsx # src/pages/OnboardingWorkspaces/BaseOnboardingWorkspaces.tsx

DylanDylann · 2026-05-26T12:04:20Z

Kindly bump on #79832 (comment)

…ect2.2 # Conflicts: # src/components/Search/index.tsx

ShridharGoel · 2026-05-26T20:01:54Z

Updated

…ect2.2 # Conflicts: # src/components/MoneyRequestHeaderSecondaryActions.tsx # src/components/Search/index.tsx # src/hooks/useDeleteTransactions.ts # src/libs/ReportSecondaryActionUtils.ts # tests/unit/ReportSecondaryActionUtilsTest.ts

…ect2.2

DylanDylann · 2026-05-28T04:43:29Z

                    selectedTransactions,
                    email ?? '',
                    accountID,
+                    archivedReportsIDSet,


Why do we need to pass archivedReportsIDSet here?

It is used downstream by mapTransactionItemToSelectedEntry when calculating canChangeReport. That calls canEditFieldOfMoneyRequest, which needs archivedReportsIDSet to exclude archived reports from outstanding report checks without using Onyx.connect.

DylanDylann · 2026-05-28T04:44:38Z

@ShridharGoel Could you review the change again before requesting review?

ShridharGoel · 2026-05-28T06:48:01Z

@DylanDylann It's ready for review

DylanDylann · 2026-05-28T08:25:12Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f17391f966

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-28T08:29:52Z


    // Unreported transaction from OldDot can have the reportID as an empty string
    const isUnreportedExpense = !transaction?.reportID || transaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID;
+    const archivedReportIDs = archivedReportsIDSet ?? buildArchivedReportsIDSet(allReportNameValuePair);


Avoid rebuilding archived sets for unrelated edits

When archivedReportsIDSet is omitted, this scans the entire report-name-value-pairs collection before knowing whether archive status is needed. Callers such as canEditMultipleTransactions() still invoke canEditFieldOfMoneyRequest() without the set while checking AMOUNT/MERCHANT/etc., so bulk-selecting many expenses can now do an O(number of selected transactions × number of reports) rebuild even though those fields never use archivedReportIDs. Move this fallback into the REPORT branch (or pass a prebuilt set from the caller) so non-report edit checks keep their previous constant-time behavior.

Useful? React with 👍 / 👎.

@MelvinBot Are we necessary to pass the full archivedReportsIDSet in the canEditFieldOfMoneyRequest function?

@ShridharGoel Could you check this codex's comment?

MelvinBot · 2026-05-28T08:35:11Z

Yes, the full archivedReportsIDSet is needed here. The function doesn't just check the current report — it also iterates across policies to count outstanding reports (lines 5044–5052), calling getOutstandingReportsForUser and isReportOutstanding for potentially many different reports. Each of those calls checks whether a given report is archived via isReportArchivedByID(archivedReportsIDSet, reportID), so a single report's archived status wouldn't be sufficient.

DylanDylann · 2026-05-28T08:37:28Z

@MelvinBot Could you also review this PR?

MelvinBot · 2026-05-28T08:40:14Z

Here's my review of the PR:

Overall: The migration from Onyx.connect() to hook-based archivedReportsIDSet is well-structured, and the naming fix (Id → ID) is a good consistency improvement. A few concerns:

1. Missing `useMemo` in `useArchivedReportsIDSet` — potential perf issue

useArchivedReportsIDSet calls buildArchivedReportsIDSet() on every render, creating a new Set reference each time. This means every component consuming this hook gets a fresh object, which breaks memoization in downstream useMemo/useCallback dependency arrays.

This is especially concerning in Search/index.tsx where archivedReportsIDSet is added to multiple useCallback deps — those callbacks will be recreated on every render.

Suggestion: Wrap the return in useMemo:

return useMemo(() => buildArchivedReportsIDSet(reportNameValuePairs), [reportNameValuePairs]);

2. Optional `archivedReportsIDSet` params + fallback pattern

The ? on canEditFieldOfMoneyRequest, isReportOutstanding, and getOutstandingReportsForUser with a fallback to buildArchivedReportsIDSet(allReportNameValuePair) means callers that forget to pass the set silently rebuild it from the module-level Onyx connection — which is the old pattern this PR is trying to remove.

The "temporarily optional" comments with the issue link are good. I'd echo DylanDylann's feedback: making these required now (where callers already have the set) prevents regressions where someone adds a new call site without passing it.

3. `getOutstandingReportsForUser` — parameter reorder is risky

The signature changed from (policyID, ownerAccountID, reports, reportNameValuePairs, allowSubmitted) to (policyID, ownerAccountID, archivedReportsIDSet?, reports, allowSubmitted). Since archivedReportsIDSet is optional and reports has a default value, a caller passing positional args in the old order would silently compile but pass the wrong values. Any callers outside this PR would break silently.

4. Inconsistent required vs optional

getSecondaryTransactionThreadActions has archivedReportsIDSet as required, while getSecondaryReportActions has it as optional. If both are being migrated in this PR, they should ideally be consistent.

5. Tests look good

The test updates correctly pass new Set<string>() for the new parameter, and the hook test renames are clean.

Summary: The main actionable item is adding useMemo to the hook to avoid unnecessary re-renders across the many components that consume it. The rest aligns with DylanDylann's existing feedback about making params required and using the hook directly rather than prop-drilling.

DylanDylann · 2026-05-28T08:58:52Z

@ShridharGoel Kindly bump on #79832 (comment)

ShridharGoel · 2026-05-28T13:29:34Z

Kindly bump on #79832 (comment)

@DylanDylann Which comment is that? No comment is getting highlighted on clicking the link

DylanDylann · 2026-06-01T06:50:00Z

 function getOutstandingReportsForUser(
    policyID: string | undefined,
    reportOwnerAccountID: number | undefined,
+    archivedReportsIDSet?: ArchivedReportsIDSet,


@ShridharGoel if this is temporary, please comment that it should be removed in the next PRs (also note the link to the issue)

The ref link didn't work 😄 I commented gain

DylanDylann · 2026-06-01T06:50:57Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 35524bf13f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-01T06:55:00Z

+function useArchivedReportsIDSet(): ArchivedReportsIDSet {
+    const [reportNameValuePairs] = useOnyx(ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS);
+
+    return buildArchivedReportsIDSet(reportNameValuePairs);


Avoid treating unloaded archive data as empty

When useOnyx has not delivered REPORT_NAME_VALUE_PAIRS yet, this returns an empty Set instead of an unloaded/undefined value. New callers pass that set into isReportOutstanding, whose fallback to the module-scoped allReportNameValuePair only runs when the set argument is omitted, so archived expense reports can be treated as outstanding in initial renders such as the report picker or move-expense eligibility until this hook catches up.

Useful? React with 👍 / 👎.

ShridharGoel added 6 commits January 18, 2026 17:09

Update outstanding report filters

c2de4e4

Thread archived checks through edit gating

df6513b

Use archived report checks in search selection

cf65086

Refactor ReportUtils archive checks

4fefcb9

Prettier fixes

63f4056

Fix a duplicate declaration

b3a1b98

melvin-bot Bot assigned ShridharGoel Jan 18, 2026

ShridharGoel added 11 commits February 21, 2026 11:38

Updates

1d3bfbb

Merge main

d8d79fb

Change Id to ID

11d888a

Change Id to ID

e3e932f

Change useArchivedReportsIdSet to useArchivedReportsIDSet

4564e7a

Merge main

75c47f3

Fix

335ad6a

Lint and prettier fixes

a0465bf

Update more usages to pass the ID-set

fe0a427

Update

9806560

Merge branch 'main' of https://github.com/Expensify/App into onyxConn…

b8c565d

…ect2.2

ShridharGoel marked this pull request as ready for review February 22, 2026 06:44

ShridharGoel requested review from a team as code owners February 22, 2026 06:44

melvin-bot Bot requested review from a team, DylanDylann and JmillsExpensify and removed request for a team February 22, 2026 06:44

melvin-bot Bot requested review from heyjennahay and removed request for a team February 22, 2026 06:44

ShridharGoel requested a review from DylanDylann May 15, 2026 08:57

DylanDylann reviewed May 18, 2026

View reviewed changes

Comment thread src/libs/ReportUtils.ts Outdated

Comment thread src/libs/ReportUtils.ts Outdated

Comment thread src/libs/ReportSecondaryActionUtils.ts

ShridharGoel added 4 commits May 22, 2026 04:56

Pass archived report set to transaction actions

cfdf13b

Fix transaction action test call signature

21d18ae

Remove unused onboarding beta subscriptions

bbbe870

ShridharGoel requested a review from DylanDylann May 22, 2026 07:10

ShridharGoel added 3 commits May 27, 2026 00:06

Clarify outstanding reports archived check

c474187

Merge branch 'main' of https://github.com/Expensify/App into onyxConn…

c152cd4

…ect2.2 # Conflicts: # src/components/Search/index.tsx

Fix archived reports hook import

6252bdc

DylanDylann reviewed May 27, 2026

View reviewed changes

ShridharGoel added 3 commits May 27, 2026 18:02

Address archived reports review feedback

e4695b1

Merge branch 'main' of https://github.com/Expensify/App into onyxConn…

24ef926

…ect2.2

DylanDylann reviewed May 28, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

Avoid unnecessary archived report set rebuilds

35524bf

DylanDylann reviewed Jun 1, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jun 1, 2026

View reviewed changes

Conversation

ShridharGoel commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jan 18, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Feb 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann commented May 26, 2026

Uh oh!

ShridharGoel commented May 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DylanDylann May 28, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel May 28, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented May 28, 2026

Uh oh!

ShridharGoel commented May 28, 2026

Uh oh!

DylanDylann commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann May 28, 2026

Choose a reason for hiding this comment

Uh oh!

DylanDylann May 28, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel May 28, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented May 28, 2026

Uh oh!

DylanDylann commented May 28, 2026

Uh oh!

MelvinBot commented May 28, 2026

1. Missing useMemo in useArchivedReportsIDSet — potential perf issue

2. Optional archivedReportsIDSet params + fallback pattern

3. getOutstandingReportsForUser — parameter reorder is risky

4. Inconsistent required vs optional

5. Tests look good

Uh oh!

DylanDylann commented May 28, 2026

Uh oh!

ShridharGoel commented May 28, 2026

Uh oh!

DylanDylann Jun 1, 2026

Choose a reason for hiding this comment

Uh oh!

ShridharGoel commented Jan 18, 2026 •

edited

Loading

codecov Bot commented Jan 18, 2026 •

edited by github-actions Bot

Loading

1. Missing `useMemo` in `useArchivedReportsIDSet` — potential perf issue

2. Optional `archivedReportsIDSet` params + fallback pattern

3. `getOutstandingReportsForUser` — parameter reorder is risky