Add personal card steps#84042
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
# Conflicts: # src/ROUTES.ts # src/SCREENS.ts # src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx # src/libs/Navigation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts # src/libs/Navigation/linkingConfig/config.ts # src/libs/Navigation/types.ts
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
# Conflicts: # src/libs/Navigation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts
|
@joekaufmanexpensify @amyevans - i think we could also start reviewing this one. Generally @amyevans could also test on new API for plaid. And @joekaufmanexpensify on direct bank account setup. I was able to test with Mock bank - was able to get successfully cards. |
|
@codex review |
|
🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
melvin-bot
Bot
requested review from
ShridharGoel and
heyjennahay
and removed request for
a team
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Android app keeps crashing on the plaid screen, anyone able to repro? Screen.Recording.2026-03-26.at.1.32.05.AM.mov |
amyevans
left a comment
amyevans
left a comment
There was a problem hiding this comment.
A couple things to note but overall looking great!
|
Hey, I'm working on avoiding the infinite spinner when re-importing an existing card. |
|
@heekinho let's do it in a separate PR since this one is ready to go and I don't want to hold it up more, even if the changes are small 😄 I'm doing a final pass now and then will merge! |
|
🚧 @amyevans has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.3.50-0 🚀
Bundle Size Analysis (Sentry): |
|
I have failed to help you. I let you down and for that I am sorry. Please try again later. This may be due to a Claude outage (check here). Failure details: https://github.com/Expensify/Expensify/actions/runs/23647037372 |
|
Deploy Blocker #86537 was identified to be related to this PR. |
There was a problem hiding this comment.
|
This PR failing because of the issue #86600 |
|
Deploy Blocker #86600 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.3.50-8 🚀
|
10 participants
Explanation of Change
Add personal card with Plaid or direct bank US/non US
Fixed Issues
$ #78392, #78392, #78396, #84779
PROPOSAL:
Tests
Add personal card:
Check error during connection:
Offline tests
Feature is not available offline
QA Steps
Add personal card:
Check error during connection:
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Details
web.mov