Skip to content

[HOLD https://github.com/Expensify/App/pull/84517 to staging] Bump Onyx to 3.0.66#86885

Open
fabioh8010 wants to merge 12 commits intoExpensify:mainfrom
callstack-internal:feature/structural-sharing-cache-pr-3
Open

[HOLD https://github.com/Expensify/App/pull/84517 to staging] Bump Onyx to 3.0.66#86885
fabioh8010 wants to merge 12 commits intoExpensify:mainfrom
callstack-internal:feature/structural-sharing-cache-pr-3

Conversation

@fabioh8010
Copy link
Copy Markdown
Contributor

@fabioh8010 fabioh8010 commented Apr 1, 2026 •
edited
Loading

Explanation of Change

This PR bumps Onyx from 3.0.63 to 3.0.66 (diff), which includes the following changes:

Only Expensify/react-native-onyx#768 needs testing here.

Fixed Issues

$ #86181
PROPOSAL:

Tests

General testing over the app

  • Login with an account.
  • Go to Inbox tab, scroll the chat list a bit.
  • Select a chat and send a message.
  • React to that message and create a thread.
  • Create a task and complete it.
  • Create an expense via FAB, go to the expense details.
  • Go to Spend tab and check if expense is there. Go to its details.
  • Go to Workspaces tab, scroll the list a bit.
  • Go to Settings and logout.

Offline tests

N/A

QA Steps

Same as Tests.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A, app is very slow and crashing after few interactions, but I tested on main and I'm having the same issue – not related to this PR.

Android: mWeb Chrome
Screen.Recording.2026-04-24.at.13.52.36.mov
iOS: Native
Screen.Recording.2026-04-24.at.13.59.38.mov
iOS: mWeb Safari
Screen.Recording.2026-04-24.at.14.02.47.mov
MacOS: Chrome / Safari
Screen.Recording.2026-04-24.at.14.04.55.mov
Screen.Recording.2026-04-24.at.14.06.29.mov

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2026

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@fabioh8010 fabioh8010 mentioned this pull request Apr 1, 2026
Merged
41 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #86885.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1e1093b-c326921-b3cd19d49ff6951c8b203fef6e7162ccd03a580b/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1e1093b-c326921-58c1254b7aaabcc0d4520d6e25167d636c54281f/index.html
Android iOS
Web 🕸️
https://86885.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@fabioh8010
Copy link
Copy Markdown
Contributor Author

fabioh8010 commented Apr 13, 2026 •
edited
Loading

The tests are failing here because react-native-onyx is pointing to my latest Onyx PR changes (Expensify/react-native-onyx@17fd83c) and it includes three other Onyx PRs already merged -> Expensify/react-native-onyx#756, Expensify/react-native-onyx#767 and Expensify/react-native-onyx#760.

In this case the unit tests are failing because of Expensify/react-native-onyx#760 and they are being fixed in the respective bump -> #85919

@fabioh8010
Copy link
Copy Markdown
Contributor Author

fabioh8010 commented Apr 13, 2026

Reassure test failure is due to Julian's Onyx PR -> #87738

@lanitochka17
Copy link
Copy Markdown

lanitochka17 commented Apr 13, 2026

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Chat Preview– Unable to see the second expense until refreshing or navigating again

Version Number: 9.3.52-0 PR:86885
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13176675/test-cases/41237191
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to https://86885.pr-testing.expensify.com/
  2. Create new account and new Workspace
  3. Create an expense
  4. Before submitting create another expense

Expected Result:

The two expenses appear in a single report preview immediately

Actual Result:

The second expense is not displayed in the workspace chat until the page is refreshed or you navigate to another chat and return

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug7129013_1776108148414.bandicam_2026-04-13_22-13-48-275.mp4

@lanitochka17
Copy link
Copy Markdown

lanitochka17 commented Apr 13, 2026

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Bank account - Infinite spinner on Bank info tab

Version Number: 9.3.52-0 PR:86885
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13176890/test-cases/41237377
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: new account with workspace. Workflows disabled. Expensify card enabled.

  1. Go to worksapce > Expensify card
  2. Click Issue new card
  3. Click on Log into your bank

Expected Result:

Plad flow started

Actual Result:

Infinite spinner displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug7129020_1776108759811.Screen_Recording_2026-04-13_at_22.26.13.mp4

@lanitochka17
Copy link
Copy Markdown

lanitochka17 commented Apr 13, 2026

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Chat - Line breaks are added after each line to the text pasted from a code editor

Version Number: 9.3.52-0 PR:86885
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to https://86885.pr-testing.expensify.com/
  2. Create three or more IOUs in the workspace to generate the expense preview
  3. Navigate to the last expense using the arrow
  4. Click the right arrow (notice that it is disabled)
  5. (Optional) Repeat the same step to disable the left arrow

Expected Result:

After navigating to the last expense, clicking the disabled right arrow should do nothing

Actual Result:

Clicking the disabled arrow opens the expense detail page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug7129037_1776109869559.bandicam_2026-04-13_22-39-48-354.mp4

@lanitochka17
Copy link
Copy Markdown

lanitochka17 commented Apr 13, 2026 •
edited by IuliiaHerets
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Expense- Background is jumpy when trying to edit category

Version Number: 9.3.52-0 PR:86885
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to https://86885.pr-testing.expensify.com/
  2. Create an expense with category
  3. Open the expense
  4. click category

Expected Result:

The background should not be jumpy when opening category list

Actual Result:

The background is jumpy when opening category list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug7129094_1776113675049.bandicam_2026-04-13_23-54-11-655.mp4

@lanitochka17
Copy link
Copy Markdown

lanitochka17 commented Apr 13, 2026 •
edited
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Expensify Card - Issue card button is unresponsive when attempting to issue a second card

Version Number: 9.3.52-0 PR:86885
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Preconditions:
BA setup in the Workspace and the Expensify card enabled

  1. Go to staging.new.expensify.com
  2. Go to the Expensify Card page
  3. Issue a virtual Expensify Card for yourself
  4. Click the Issue card button again to issue another card

Expected Result:

Issue card button should be responsive and allow issuing a second card

Actual Result:

Issue card button is unresponsive on the second attempt

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug7129111_1776114286056.1.mp4

@lanitochka17
Copy link
Copy Markdown

lanitochka17 commented Apr 14, 2026

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Onboaring - Test drive hyperlink opens broken page

Version Number: 9.3.52-0 PR:86885
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Create a new user with a new email with a '+' in it.
  2. Select the option "Manage my team's expenses"
  3. Select the option of "1-10 employees" and click continue
  4. Select the QBD option
  5. Open Concierge chat
  6. Click on Test drive hyperlink

Expected Result:

Test drive demo page opens with content

Actual Result:

Test drive demo page opens with message:
This content is blocked. Contact the site owner to fix the issue.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug7129740_1776181883230.Screen_Recording_2026-04-14_at_18.44.20.mp4

@IuliiaHerets
Copy link
Copy Markdown

IuliiaHerets commented Apr 14, 2026

Regression is completed

6 issues were logged:

  1. Chat Preview– Unable to see the second expense until refreshing or navigating again
  2. Bank account - Infinite spinner on Bank info tab
  3. Chat - Line breaks are added after each line to the text pasted from a code editor
  4. Expense- Background is jumpy when trying to edit category
  5. Expensify Card - Issue card button is unresponsive when attempting to issue a second card
  6. Onboaring - Test drive hyperlink opens broken page

@Julesssss Julesssss mentioned this pull request Apr 14, 2026
Open
@fabioh8010
Copy link
Copy Markdown
Contributor Author

fabioh8010 commented Apr 15, 2026 •
edited
Loading

Regression is completed

6 issues were logged:

  1. Chat Preview– Unable to see the second expense until refreshing or navigating again
  2. Bank account - Infinite spinner on Bank info tab
  3. Chat - Line breaks are added after each line to the text pasted from a code editor
  4. Expense- Background is jumpy when trying to edit category
  5. Expensify Card - Issue card button is unresponsive when attempting to issue a second card
  6. Onboaring - Test drive hyperlink opens broken page

Tested all scenarios with this PR updated with main:

  1. Chat Preview– Unable to see the second expense until refreshing or navigating again
    1. Not reproducible ✅
Evidence
Screen.Recording.2026-04-15.at.08.14.40-compressed.mov
  1. Bank account - Infinite spinner on Bank info tab
    1. Not reproducible ✅
Evidence
Screen.Recording.2026-04-15.at.08.28.34-compressed.mov
  1. Chat - Line breaks are added after each line to the text pasted from a code editor
    1. Not reproducible ✅
Evidence
Screen.Recording.2026-04-15.at.08.32.05-compressed.mov
  1. Expense- Background is jumpy when trying to edit category
    1. Not reproducible ✅
Evidence
Screen.Recording.2026-04-15.at.08.32.52-compressed.mov
  1. Expensify Card - Issue card button is unresponsive when attempting to issue a second card
    1. Not reproducible ✅
Evidence
Screen.Recording.2026-04-15.at.08.54.05-compressed.mov
  1. Onboaring - Test drive hyperlink opens broken page
    1. Not reproducible ✅
Evidence
Screen.Recording.2026-04-15.at.08.57.53-compressed.mov

@Julesssss
Copy link
Copy Markdown
Contributor

Julesssss commented Apr 15, 2026 •
edited
Loading

Hi @IuliiaHerets, are you able to double check the reported issues

@IuliiaHerets IuliiaHerets mentioned this pull request Apr 16, 2026
Closed
@Julesssss
Copy link
Copy Markdown
Contributor

Julesssss commented Apr 17, 2026

@fabioh8010 could you update this PR, so we can retest

@fabioh8010
Copy link
Copy Markdown
Contributor Author

fabioh8010 commented Apr 17, 2026

@Julesssss Done, but I think we should wait on #84517 to get merged so I can use my Onyx release here.

@fabioh8010 fabioh8010 changed the title [WIP][Structural Sharing] PR 3: Frozen collection snapshots with lazy rebuild and per-key merge [WIP] Bump Onyx to 3.0.66 Apr 21, 2026
@fabioh8010 fabioh8010 changed the title [WIP] Bump Onyx to 3.0.66 [HOLD https://github.com/Expensify/App/pull/84517] Bump Onyx to 3.0.66 Apr 24, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026 •
edited by github-actions Bot
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 12 files with indirect coverage changes

@mountiny mountiny self-requested a review April 24, 2026 12:11
@fabioh8010 fabioh8010 changed the title [HOLD https://github.com/Expensify/App/pull/84517] Bump Onyx to 3.0.66 [HOLD https://github.com/Expensify/App/pull/84517 to staging] Bump Onyx to 3.0.66 Apr 24, 2026
@fabioh8010 fabioh8010 marked this pull request as ready for review April 24, 2026 13:09
@fabioh8010 fabioh8010 requested a review from a team as a code owner April 24, 2026 13:09
@melvin-bot melvin-bot Bot requested review from mkhutornyi and removed request for a team April 24, 2026 13:10
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented Apr 24, 2026

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@fabioh8010
Copy link
Copy Markdown
Contributor Author

fabioh8010 commented Apr 24, 2026

@Julesssss ready for testing now

@mountiny
Copy link
Copy Markdown
Contributor

mountiny commented Apr 24, 2026

@mkhutornyi can you prioritize this PR please?

@fabioh8010
Copy link
Copy Markdown
Contributor Author

fabioh8010 commented Apr 24, 2026

I will be OOO next week and will return on May 4th, @elirangoshen will watch over this PR meanwhile.

@fabioh8010 fabioh8010 mentioned this pull request Apr 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mountiny mountiny Awaiting requested review from mountiny

@mkhutornyi mkhutornyi Awaiting requested review from mkhutornyi

At least 1 approving review is required to merge this pull request.

Assignees

@fabioh8010 fabioh8010

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fabioh8010 @lanitochka17 @IuliiaHerets @Julesssss @mountiny