Bump Onyx to 3.0.58 [v2] by fabioh8010 · Pull Request #87484 · Expensify/App

fabioh8010 · 2026-04-09T11:04:12Z

Explanation of Change

This PR bumps Onyx to 3.0.58, which includes the following changes:

[Structural Sharing] PR 2: Reference-stable fastMerge and removeNestedNullValues react-native-onyx#765

Additionally we are fixing several cases where we were mutating Onyx data in Onyx Derived files. This should never be allowed and the bugs only surfaced now because of the Onyx PR above. These were the deploy blockers associated:

Expense - Infinite loading after adding an expense to report #87209
[Due for payment 2026-04-23] Expense - Second expense does not auto appear in expense preview #87201
[Due for payment 2026-04-23] [$250] DEV: Report Preview Not Updating After Adding Expense Until Manual Refresh #87179
[Due for payment 2026-04-23] Expense - Deleted expense appears as skeleton loader in the expense preview #87200
[Due for payment 2026-04-23] Expense - Expense preview is blank after splitting expense #87197
[Due for payment 2026-04-23] Expense - Not here page opens after deleting expenses #87199

Fixed Issues

$ #86181
$ #87209
$ #87201
$ #87179
$ #87200
$ #87197
$ #87199
PROPOSAL:

Tests

#87209 - Expense report loads infinitely after creating expense

Steps:

Go to workspace expense chat
Click + > Create report (empty report created)
Open the report via "View details"
Click "Add expense" > Create expense > Manual
Enter amount (€1,050), fill merchant, confirm

Expected: Expense report shows expense details after creation

#87201 - Second expense doesn't auto-appear in preview

Steps:

Go back to workspace expense chat (already had 1 expense from previous test)
Click + > Create expense > Manual
Enter amount (€500), fill merchant ("Second Merchant"), confirm
Observe the expense preview in the workspace chat

Expected: Second expense auto-appears in expense preview immediately

#87179 - Report preview doesn't update after adding expense

Steps:

Same as above — observed the report preview after creating the second expense
Checked that preview reflected updated total and expense count

Expected: Report preview updates in real-time (updated total, newly added expense)

#87200 - Deleted expense appears as skeleton loader

Steps:

Open expense report via "View details"
Click on "Second Merchant" expense
Click More > Delete > confirm Delete
Go back to workspace chat

Expected: Deleted expense does not appear in the expense preview

#87197 - Expense preview blank after splitting expense

Steps:

Open expense report (1 expense remaining from previous test)
Click More > Split > Save (splits €1,050 into 2 × €525)
Close the report RHP, return to workspace chat

Expected: Expense preview shows two expense previews after splitting

#87199 - "Not here" page after bulk deleting expenses

Steps:

Open expense report with 2 expenses (from split)
Click "Select all transactions" checkbox
Click "2 selected" dropdown > Delete > confirm Delete

Expected: "Not here" page does not open after deleting expenses

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-04-09.at.11.23.12-compressed.mov

Android: mWeb Chrome

N/A, emulator always crashing for me

iOS: Native

Screen.Recording.2026-04-09.at.11.40.22-compressed.mov

iOS: mWeb Safari

Screen.Recording.2026-04-09.at.11.44.42-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2026-04-09.at.11.50.27-compressed.mov

Screen.Recording.2026-04-09.at.11.52.48-compressed.mov

github-actions · 2026-04-09T11:04:33Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

melvin-bot · 2026-04-09T11:57:33Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-04-09T12:02:21Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...Derived/configs/reportTransactionsAndViolations.ts	`100.00% <100.00%> (ø)`
...ctions/OnyxDerived/configs/visibleReportActions.ts	`91.56% <100.00%> (+0.54%)`	⬆️
...bs/actions/OnyxDerived/configs/reportAttributes.ts	`96.79% <94.11%> (ø)`
... and 11 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2bbafd0757

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

FitseTLT · 2026-04-09T12:35:04Z

@fabioh8010 should I review this?

…ation

fabioh8010 · 2026-04-09T12:44:52Z

@fabioh8010 should I review this?

Not sure how it works but @DylanDylann was assigned in the previous PR that was reverted.

cc @Julesssss for review too.

trjExpensify · 2026-04-09T13:47:17Z

PR doesn’t have any new product considerations. Unassigning and unsubscribing myself.

Julesssss · 2026-04-09T23:18:15Z

Not sure how it works but @DylanDylann was assigned in the previous PR that was reverted.

Hey @DylanDylann could you review this one please as a follow up to the original reverted PR. Thanks

github-actions · 2026-04-09T23:19:26Z

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

fabioh8010 · 2026-04-10T19:10:51Z

@DylanDylann bump

github-actions · 2026-04-10T22:15:26Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-10T22:22:40Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87484.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-bf00062-a1cc16f-04451a178139ff3470d2e24b3c6115cdb2a6aebe/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-bf00062-a1cc16f-7c6757ece950e8745dbae1187a38b7eb84d79bf7/index.html

Web 🕸️
https://87484.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mkhutornyi · 2026-04-10T22:29:27Z

Can we revert #87394? It causes bad regression

Screen.Recording.2026-04-10.at.11.26.19.pm.mov

mkhutornyi · 2026-04-10T22:37:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-04-10.at.11.40.14.pm.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

87179.mov

87197.mov

87199.mov

87200.mov

87201.mov

87209.mov

mkhutornyi · 2026-04-10T22:38:31Z

Regression tests

87179.mov

87197.mov

87199.mov

87200.mov

87201.mov

87209.mov

mkhutornyi · 2026-04-10T22:51:49Z

More regression tests:

Report - Expense information is still visible on preview after being unreported. #87206
Report - "Remove Hold" button is not displayed after holding an expense. #87219
Android - Report - App freezes after splitting an expense and selecting one of the splits. #87220

87206.mov

87219.mov

87220.mov

MelvinBot · 2026-04-11T01:29:27Z

PR Review

Overall: This looks correct and well-structured. The mutation fixes follow a consistent clone-on-write pattern across all three derived config files.

What the PR does

Bumps react-native-onyx to 3.0.58 (structural sharing / caching)
Fixes Onyx data mutation in three OnyxDerived config files that surfaced as deploy blockers

Review of the mutation fixes

All three files follow the same pattern: shallow-clone the top-level object from currentValue, then use a clonedReportIDs set to lazily clone nested entries before mutating them. This is the right approach — it avoids unnecessary deep clones while guaranteeing no cached references are mutated.

reportAttributes.ts — The reduce accumulator now uses {...currentValue.reports} instead of the raw reference. The error propagation loop correctly spreads individual entries before overwriting brickRoadStatus/actionBadge. Since the reduce body always assigns a fresh object to acc[report.reportID], only entries carried over from currentValue (not recomputed in this run) need explicit cloning — and the error propagation loop handles exactly that case.

reportTransactionsAndViolations.ts — ensureCloned correctly deep-clones one level (both transactions and violations sub-objects) before any delete or property assignment. The clonedReportIDs.add(reportID) call when creating a brand-new entry is a nice touch — it skips the redundant clone for freshly created objects.

visibleReportActions.ts — getOrCreateReportVisibilityRecord now takes the clonedReportIDs set and clones existing entries before returning them for mutation. The full-recompute path (session/network changes) starts from {} so cloning isn't needed there — correctly handled.

No issues found.

mkhutornyi · 2026-04-11T01:29:50Z

@@ -347,8 +350,13 @@ export default createOnyxDerivedValueConfig({
                continue;
            }

-            reportAttributes[chatReportID].brickRoadStatus = CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR;
-            reportAttributes[chatReportID].actionBadge = CONST.REPORT.ACTION_BADGE.FIX;
+            // Clone the entry before mutating — it may be a reference carried over from
+            // currentValue.reports that wasn't recomputed in this incremental run.
+            reportAttributes[chatReportID] = {
+                ...reportAttributes[chatReportID],
+                brickRoadStatus: CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR,
+                actionBadge: CONST.REPORT.ACTION_BADGE.FIX,


For easy code review, these are only the changes in this file.
Others are prettier diff.

chatgpt-codex-connector · 2026-04-11T01:35:51Z

Codex Review: Didn't find any major issues. Swish!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mountiny

Thanks for the review, I will move this ahead as we have bunch of onyx changes to try to push through so dont want to waste any time

github-actions · 2026-04-12T23:32:55Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-04-12T23:39:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #87484.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f7367da-08ff3fc-04451a178139ff3470d2e24b3c6115cdb2a6aebe/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f7367da-08ff3fc-7d1a95eb7751d7cae4988e2d4baeac7a1bbd45f3/index.html

Web 🕸️
https://87484.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-04-12T23:41:03Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-04-13T20:33:59Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.59-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android

MelvinBot · 2026-04-13T20:35:15Z

No help site changes are required.

This PR is purely technical — it bumps the Onyx dependency to 3.0.58 and fixes internal data mutation bugs in three Onyx Derived config files. There are no user-facing feature changes, UI changes, renamed settings, or workflow changes that would affect help site documentation.

OSBotify · 2026-04-16T03:30:38Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.3.59-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fabioh8010 added 2 commits April 9, 2026 08:56

Bump Onyx to 3.0.58

cf7e26e

Avoid mutations in Onyx Derived files

484b7f5

melvin-bot Bot assigned fabioh8010 Apr 9, 2026

Fix prettier

2bbafd0

fabioh8010 marked this pull request as ready for review April 9, 2026 11:57

fabioh8010 requested review from a team as code owners April 9, 2026 11:57

melvin-bot Bot requested review from FitseTLT and trjExpensify and removed request for a team April 9, 2026 11:57

chatgpt-codex-connector Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread src/libs/actions/OnyxDerived/configs/reportAttributes.ts

fix: clone report attribute entry before mutating during error propag…

c4b3e92

…ation

fabioh8010 mentioned this pull request Apr 9, 2026

Add structural sharing to Onyx’s cache #86181

Open

trjExpensify removed their request for review April 9, 2026 13:47

Julesssss removed the request for review from FitseTLT April 9, 2026 23:17

This comment has been minimized.

Sign in to view

JKobrynski mentioned this pull request Apr 10, 2026

[Due for payment 2026-04-28] [$250] [Onyx Audit] Fix useOnyx state not resetting on key change in getSnapshot() #85416

Open

Merge branch 'main' into feature/structural-sharing-cache-pr-2-v2

bf00062

fabioh8010 mentioned this pull request Apr 10, 2026

[Tracking] Onyx Improvements #80355

Open

mountiny requested a review from mkhutornyi April 10, 2026 22:14

mkhutornyi reviewed Apr 11, 2026

View reviewed changes

mkhutornyi approved these changes Apr 11, 2026

View reviewed changes

melvin-bot Bot requested a review from rlinoz April 11, 2026 01:30

mountiny approved these changes Apr 12, 2026

View reviewed changes

mountiny merged commit f7367da into Expensify:main Apr 12, 2026
41 checks passed

VickyStash mentioned this pull request Apr 13, 2026

Bump onyx to 3.0.59 #87738

Merged

52 tasks

OSBotify mentioned this pull request Apr 13, 2026

Deploy Checklist: New Expensify 2026-04-13 #87792

Closed

89 tasks

Conversation

fabioh8010 commented Apr 9, 2026

Explanation of Change

Fixed Issues

Tests

#87209 - Expense report loads infinitely after creating expense

#87201 - Second expense doesn't auto-appear in preview

#87179 - Report preview doesn't update after adding expense

#87200 - Deleted expense appears as skeleton loader

#87197 - Expense preview blank after splitting expense

#87199 - "Not here" page after bulk deleting expenses

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

melvin-bot Bot commented Apr 9, 2026

Uh oh!

codecov Bot commented Apr 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

FitseTLT commented Apr 9, 2026

Uh oh!

fabioh8010 commented Apr 9, 2026

Uh oh!

trjExpensify commented Apr 9, 2026

Uh oh!

Julesssss commented Apr 9, 2026

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

This comment has been minimized.

fabioh8010 commented Apr 10, 2026

Uh oh!

github-actions Bot commented Apr 10, 2026

Uh oh!

github-actions Bot commented Apr 10, 2026

Uh oh!

mkhutornyi commented Apr 10, 2026

Uh oh!

mkhutornyi commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mkhutornyi commented Apr 10, 2026

Regression tests

Uh oh!

mkhutornyi commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented Apr 11, 2026

PR Review

What the PR does

Review of the mutation fixes

Uh oh!

mkhutornyi Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Apr 11, 2026

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 12, 2026

Uh oh!

github-actions Bot commented Apr 12, 2026

Uh oh!

OSBotify commented Apr 12, 2026

Uh oh!

OSBotify commented Apr 13, 2026

codecov Bot commented Apr 9, 2026 •

edited by github-actions Bot

Loading

mkhutornyi commented Apr 10, 2026 •

edited

Loading

mkhutornyi commented Apr 10, 2026 •

edited

Loading