Properly display CSV feeds before we load the cards#88136
Open
Properly display CSV feeds before we load the cards#88136
Conversation
|
@bernhardoj Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Before, we did not display CSV feeds with no cards in Onyx. However, unassigned cards are not loaded until the feed is selected (which we couldn't do because we were not displaying it). We will now display the feed.
This likely also caused part of the issue by which we did not properly display the feed after a first import
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/623387
$ #86814
PROPOSAL:
Tests
Go to Workspace -> Company Cards
Click Add cards.
Select United States > Next.
Select Direct feed > Next.
Select Import transactions from file > Next.
Enter Company card layout name and save it.
Click Next.
Upload a valid CSV file like this one:
uploads_1594908368712-Best+Example+CSV+for+Domains.csv
Map Account number to Card number.
Click Import.
Confirm the cards import properly
Go to OldDot -> Domains and select a Newdot Workspace
Click CSV Import.
Follow the process to import cards. You can use this file:
uploads_1594908368712-Best+Example+CSV+for+Domains.csv
Go to newdot and confirm the new feed displays in Workspace -> Company Cards
Offline tests
None
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari