feat: edit agent functionality#89802
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🚧 @NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here. |
55807b2 to
cf413a1
Compare
|
🚧 @NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b128db9b3d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
That feels a bit inconsistent with row buttons from Spend though, right? I don't feel strongly but I do wonder if the smaller size buttons would look nicer. |
|
Yeah fair point. Alright go with small. I'll update Figma to match |
…n name and prompt error displays
…nameErrors and promptErrors with a single hasUpdateErrors flag
…t function. Removed unused variables and improved form submission validation logic.
…ed error handling
…sed on badgeText presence
…te deleteAgent function accordingly
…ID for consistency
325ca63 to
bd7bd27
Compare
yuwenmemon
left a comment
There was a problem hiding this comment.
We can always address comments in a follow up @NicolasBonet
|
🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.74-7 🚀
Bundle Size Analysis (Sentry): |
|
Yes, help site changes are needed. There is no existing article covering the custom agents feature (create, edit, delete), so I created one. Draft PR: #90812 The new article (
All UI labels ( |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀
|
|
Deploy Blocker #90872 was identified to be related to this PR. |

Explanation of Change
Introduces the edit agent view (including edit name and prompt routes) and also a way to delete agents
Fixed Issues
$ #89355
PROPOSAL:https://expensify.enterprise.slack.com/docs/T03SC9DTT/F0AKV1FPD41
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps./** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)Screenshots/Videos
Android: Native
screen-20260511-165822-1778536657018.mp4
Android: mWeb Chrome
screen-20260513-120003-1778691546311.mp4
iOS: Native
ScreenRecording_05-13-2026.11-47-59_1.MP4
iOS: mWeb Safari
ScreenRecording_05-11-2026.16-48-21_1.MP4
MacOS: Chrome / Safari
Screen.Recording.2026-05-11.at.4.49.54.PM.mov