Skip to content

feat: edit agent functionality#89802

Merged
yuwenmemon merged 38 commits into
mainfrom
feat/89355-edit-agent
May 14, 2026
Merged

feat: edit agent functionality#89802
yuwenmemon merged 38 commits into
mainfrom
feat/89355-edit-agent

Conversation

@NicolasBonet

@NicolasBonet NicolasBonet commented May 6, 2026

Copy link
Copy Markdown
Contributor
  • Introduced new forms for editing agent name and prompt.
  • Added routes and screens for editing agent details.
  • Implemented actions to update agent name and prompt.
  • Created a delete agent feature with confirmation modal.
  • Updated translations for new agent editing features in multiple languages.
  • Enhanced navigation to support new agent editing flows.

Explanation of Change

Introduces the edit agent view (including edit name and prompt routes) and also a way to delete agents

Fixed Issues

$ #89355
PROPOSAL:https://expensify.enterprise.slack.com/docs/T03SC9DTT/F0AKV1FPD41

Tests

  1. From the Agents page, click the Edit button on an existing agent
  2. Verify you are navigated to the Edit Agent page for the correct agent
  3. Verify the page shows two option items: Agent name and Write custom instructions
  4. Click Agent name and verify it navigates to the Edit Name screen
  5. Edit the name and hit Save and verify UpdateAgentName API is called in the Network tab
  6. Go back and click Write custom instructions and verify it navigates to the Edit Prompt screen
  7. Edit the prompt and hit Save and verify UpdateAgentPrompt API is called in the Network tab
  8. Verify a delete agent button is displayed
  9. Click the delete agent button and verify a confirmation modal is displayed
  10. Confirm the delete and verify DeleteAgent API is called in the Network tab
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I verified that similar component doesn't exist in the codebase
  • I verified that all props are defined accurately and each prop has a /** comment above it */
  • I verified that each file is named correctly
  • I verified that each component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • I verified that the only data being stored in component state is data necessary for rendering and nothing else
  • In component if we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • I verified that component internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • I verified that all JSX used for rendering exists in the render method
  • I verified that each component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

Screenshots/Videos

Android: Native
screen-20260511-165822-1778536657018.mp4
Android: mWeb Chrome
screen-20260513-120003-1778691546311.mp4
iOS: Native
ScreenRecording_05-13-2026.11-47-59_1.MP4
iOS: mWeb Safari
ScreenRecording_05-11-2026.16-48-21_1.MP4
MacOS: Chrome / Safari
Screen.Recording.2026-05-11.at.4.49.54.PM.mov

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@OSBotify

This comment has been minimized.

@codecov

codecov Bot commented May 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/SCREENS.ts 100.00% <ø> (ø)
...mponents/FocusTrap/WIDE_LAYOUT_INACTIVE_SCREENS.ts 0.00% <ø> (ø)
src/libs/API/types.ts 100.00% <ø> (ø)
...igation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts 100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts 76.92% <ø> (ø)
src/pages/settings/Agents/AddAgentPage.tsx 88.37% <100.00%> (+0.27%) ⬆️
src/pages/settings/Agents/AgentInfoRow.tsx 100.00% <100.00%> (ø)
src/pages/settings/Agents/AgentsListRow.tsx 100.00% <100.00%> (ø)
src/types/form/EditAgentNameForm.ts 100.00% <100.00%> (ø)
... and 10 more
... and 182 files with indirect coverage changes

@NicolasBonet NicolasBonet requested review from a team May 6, 2026 19:48
@Expensify Expensify deleted a comment from github-actions Bot May 6, 2026
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

🚧 @NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

@Expensify Expensify deleted a comment from github-actions Bot May 6, 2026
@NicolasBonet NicolasBonet force-pushed the feat/89355-edit-agent branch from 55807b2 to cf413a1 Compare May 6, 2026 21:37
@Expensify Expensify deleted a comment from github-actions Bot May 6, 2026
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

🚧 @NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@OSBotify

This comment has been minimized.

@NicolasBonet NicolasBonet marked this pull request as ready for review May 6, 2026 22:23
@NicolasBonet NicolasBonet requested a review from a team as a code owner May 6, 2026 22:23
@melvin-bot melvin-bot Bot requested review from JmillsExpensify and ShridharGoel and removed request for a team and JmillsExpensify May 6, 2026 22:23
@melvin-bot

melvin-bot Bot commented May 6, 2026

Copy link
Copy Markdown

@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@NicolasBonet NicolasBonet requested review from puneetlath, s77rt and yuwenmemon and removed request for ShridharGoel May 6, 2026 22:23

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b128db9b3d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/libs/actions/Agent.ts
@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

The edit button should be our regular button size not small which it is now. Mock:

image

Otherwise it's looking good

@shawnborton

Copy link
Copy Markdown
Contributor

That feels a bit inconsistent with row buttons from Spend though, right? I don't feel strongly but I do wonder if the smaller size buttons would look nicer.

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Yeah fair point. Alright go with small. I'll update Figma to match

@NicolasBonet NicolasBonet force-pushed the feat/89355-edit-agent branch from 325ca63 to bd7bd27 Compare May 14, 2026 14:47
Comment thread src/pages/settings/Agents/AgentInfoRow.tsx
Comment thread src/pages/settings/Agents/AgentsListRow.tsx
Comment thread src/pages/settings/Agents/Fields/EditPromptPage.tsx

@yuwenmemon yuwenmemon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always address comments in a follow up @NicolasBonet

Comment thread src/pages/settings/Agents/Fields/EditPromptPage.tsx
Comment thread src/pages/settings/Agents/AgentInfoRow.tsx
Comment thread src/pages/settings/Agents/AgentsPage.tsx
@yuwenmemon yuwenmemon merged commit 5b98546 into main May 14, 2026
44 checks passed
@yuwenmemon yuwenmemon deleted the feat/89355-edit-agent branch May 14, 2026 16:20
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.3.74-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

Yes, help site changes are needed. There is no existing article covering the custom agents feature (create, edit, delete), so I created one.

Draft PR: #90812

The new article (docs/articles/new-expensify/concierge-ai/Custom-Agents.md) covers:

  • How to create a custom agent
  • How to edit an agent's name and custom instructions
  • How to delete a custom agent
  • FAQ on instruction types and multiple agents

All UI labels (Agent name, Write custom instructions, Delete agent, etc.) match the product strings from the PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.74-7 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #90872 was identified to be related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.