Gets the personal details data with useOnyx - #1 by bernhardoj · Pull Request #90000 · Expensify/App

bernhardoj · 2026-05-08T13:03:11Z

Explanation of Change

Fixed Issues

$ #66391
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite:

have a workspace, group chat, and a room with some members

Open any chat
Add a reaction to any message
Hover over the reaction (Web only) and verify it shows your name as "You"
Right-click or long-press the reaction
Verify the reaction list shows your name as "You"
Open a group chat member page
Select one user and select the delete option
Verify the delete confirmation shows the selected user's display name
Open a room member page
Repeat steps 7-8
Open the workspace list page
Verify the owner's details are shown correctly
Open the workspace member page
Repeat steps 7-8

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Kapture.2026-05-08.at.20.56.18.mp4

melvin-bot · 2026-05-08T13:03:19Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-05-08T13:03:25Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…-useonyx-1

bernhardoj · 2026-05-08T13:13:04Z

Wow, PR 90000.

Btw, I think @shubham1206agra will review this.

mountiny · 2026-05-08T13:23:22Z

@DylanDylann @shubham1206agra who can review this one?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e76cecc096

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-08T13:24:03Z

+            memberName: formatPhoneNumber(newGetPersonalDetailsByIDs({accountIDs: [firstSelectedEmployeeAccountID], personalDetails}).at(0)?.displayName ?? ''),
        });
    }, [selectedEmployees, policyMemberEmailsToAccountIDs, translate, policy, formatPhoneNumber, currentUserAccountID]);


Include personalDetails in confirmModalPrompt memo deps

confirmModalPrompt now reads from personalDetails via newGetPersonalDetailsByIDs(...), but personalDetails is missing from the useMemo dependency list. If personal details hydrate or change after the initial render (common with Onyx async updates), the remove-members modal can show a stale or empty member name until another listed dependency changes, which regresses the confirmation copy accuracy.

Useful? React with 👍 / 👎.

codecov · 2026-05-08T13:30:29Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/PersonalDetailsUtils.ts	`85.39% <100.00%> (+1.05%)`	⬆️
.../inbox/report/ReactionList/PopoverReactionList.tsx	`86.95% <100.00%> (+3.62%)`	⬆️
src/pages/workspace/WorkspaceMembersPage.tsx	`60.77% <100.00%> (-0.10%)`	⬇️
src/pages/workspace/WorkspacesListRow.tsx	`93.67% <100.00%> (ø)`
src/selectors/PersonalDetails.ts	`78.57% <100.00%> (+11.90%)`	⬆️
src/pages/domain/Members/DomainAddMemberPage.tsx	`0.00% <0.00%> (ø)`
src/pages/ReportParticipantsPage.tsx	`0.00% <0.00%> (ø)`
src/pages/RoomMembersPage.tsx	`0.00% <0.00%> (ø)`
...rc/components/Reactions/ReactionTooltipContent.tsx	`5.88% <0.00%> (-1.27%)`	⬇️
... and 8 files with indirect coverage changes

shubham1206agra · 2026-05-08T13:58:31Z

@mountiny I will review here.

@bernhardoj Please fix ESLint

shubham1206agra · 2026-05-08T14:01:16Z

 import {View} from 'react-native';
 import Text from '@components/Text';
 import useLocalize from '@hooks/useLocalize';
+import useOnyx from '@hooks/useOnyx';


bernhardoj · 2026-05-08T14:27:14Z

Fixed

trjExpensify · 2026-05-08T15:50:17Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

…-useonyx-1

mountiny · 2026-05-10T13:36:50Z

@shubham1206agra do you have an eta?

bernhardoj · 2026-05-11T16:39:27Z

Unrelated lint

…-useonyx-1

shubham1206agra · 2026-05-12T12:46:12Z

    const {emojiCodes = [], reactionCount = 0, hasUserReacted = false, userAccountIDs = []} = selectedReaction ? getEmojiReactionDetails(emojiName, selectedReaction, accountID) : {};
-    const users = isReady ? getPersonalDetailsByIDs({accountIDs: userAccountIDs, currentUserAccountID: accountID, shouldChangeUserDisplayName: true}) : [];
+
+    const [users = getEmptyArray<PersonalDetails>()] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {


@bernhardoj This selector has a dependency of translate. Please provide this as arg in this hook.

…-useonyx-1

gets the personal details data with useOnyx

e76cecc

bernhardoj requested review from a team as code owners May 8, 2026 13:03

melvin-bot Bot assigned bernhardoj May 8, 2026

melvin-bot Bot requested review from DylanDylann and trjExpensify and removed request for a team May 8, 2026 13:03

melvin-bot Bot requested review from a team and mountiny and removed request for a team May 8, 2026 13:03

Merge branch 'main' into chore/66391-refactor-personal-details-to-use…

3a56653

…-useonyx-1

bernhardoj added 2 commits May 8, 2026 21:17

lint

3ec8277

add tests

4b0b7ae

chatgpt-codex-connector Bot reviewed May 8, 2026

View reviewed changes

shubham1206agra reviewed May 8, 2026

View reviewed changes

lint

82124b2

mountiny removed the request for review from DylanDylann May 8, 2026 14:36

trjExpensify removed their request for review May 8, 2026 15:50

bernhardoj added 2 commits May 10, 2026 18:24

Merge branch 'main' into chore/66391-refactor-personal-details-to-use…

4196186

…-useonyx-1

lint

91a8b0c

shubham1206agra reviewed May 11, 2026

View reviewed changes

Comment thread src/pages/workspace/WorkspaceMembersPage.tsx Outdated

remove unused var

2c131c3

Merge branch 'main' into chore/66391-refactor-personal-details-to-use…

4c44ce2

…-useonyx-1

shubham1206agra reviewed May 12, 2026

View reviewed changes

bernhardoj added 3 commits May 13, 2026 11:10

Merge branch 'main' into chore/66391-refactor-personal-details-to-use…

c2f5d53

…-useonyx-1

add useonyx deps

ce8d339

prettier

d1d315f

Conversation

bernhardoj commented May 8, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 8, 2026

Uh oh!

melvin-bot Bot commented May 8, 2026

Uh oh!

bernhardoj commented May 8, 2026

Uh oh!

mountiny commented May 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 8, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shubham1206agra commented May 8, 2026

Uh oh!

shubham1206agra May 8, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented May 8, 2026

Uh oh!

trjExpensify commented May 8, 2026

Uh oh!

mountiny commented May 10, 2026

Uh oh!

Uh oh!

bernhardoj commented May 11, 2026

Uh oh!

shubham1206agra May 12, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj May 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov Bot commented May 8, 2026 •

edited by github-actions Bot

Loading