Skip to content

[Payment due @DylanDylann] [Odometer] Fix race condition#90445

Open
jakubkalinski0 wants to merge 27 commits into
Expensify:mainfrom
software-mansion-labs:jakubkalinski0/Odometer_fix_race_condition
Open

[Payment due @DylanDylann] [Odometer] Fix race condition#90445
jakubkalinski0 wants to merge 27 commits into
Expensify:mainfrom
software-mansion-labs:jakubkalinski0/Odometer_fix_race_condition

Conversation

@jakubkalinski0
Copy link
Copy Markdown
Contributor

@jakubkalinski0 jakubkalinski0 commented May 13, 2026

@DylanDylann

Explanation of Change

Refactor of the odometer receipt subsystem that supersedes the original bandaid fix. Previously, useOdometerDraftHydrator, OdometerReceiptStitcher, and ReceiptFileValidator could collide on transaction.receipt: the validator finishing its check against an old source right after the stitcher wrote a new one would clear the fresh receipt. The earlier fix added self-healing refs (lastWrittenReceiptSource, stale-detection in the validator). This PR replaces that entanglement with composition:

  • New useOdometerReceiptStitcher hook composes the existing useRestartOnOdometerImagesFailure internally and owns only the stitch derivation as a small FSM (idle | stitching | ready | error). Verification + recovery logic is not duplicated - it stays in useRestartOnOdometerImagesFailure.
  • <ReceiptFileValidator /> gains a flow-agnostic isReceiptReady prop and skips the initial row while an upstream writer is mid-derivation. The bandaid isOdometerInitial && hasLiveOdometerImage branch is removed, and so are the validator's earlier self-healing ref + staleness check - the standard React ignore guard handles the stale-async case directly.
  • The <OdometerReceiptStitcher /> component is deleted - its responsibilities live inside the new hook.
  • Two pure utilities extracted: deriveOdometerReceipt (empty/single/stitch decision) and stitchTask (AbortController-cancellable canvas op with balanced telemetry span).
  • The new hook is wired only on the confirmation step. The edit step, capture step, and attachment-modal route keep calling useRestartOnOdometerImagesFailure directly - they need verification + recovery without receipt writes.

Architecturally the two useRestart* hooks are now siblings (useRestartOnReceiptFailure for generic scan flows, useRestartOnOdometerImagesFailure for odometer). Each receipt-derivation responsibility has a single owner.

Diff overview

13 files changed · +946 / −151 - breakdown per cea8f39 commit

Tests vs. non-test source

Category Insertions %
Test files (3 new files) 595 63%
Non-test source 351 37%
Total insertions 946 100%

So more than half of the diff is tests (35 new unit tests with descriptive setup helpers and §N matrix mocking).

Inside the 351 non-test insertions

File Insertions Comment-only lines Actual code
useOdometerReceiptStitcher/index.ts (NEW) 147 20 107 (+20 blank)
useOdometerReceiptStitcher/types.ts (NEW) 59 26 20 (+13 blank)
stitchTask.ts (NEW) 59 11 43 (+5 blank)
deriveOdometerReceipt.ts (NEW) 37 9 23 (+5 blank)
OdometerReceipt/index.ts (NEW barrel) 7 0 6 (+1 blank)
ReceiptFileValidator.tsx (modified) 25 9 15 (+1 blank)
IOURequestStepConfirmation.tsx (modified) 14 0 14
useRestartOnOdometerImagesFailure/index.ts (modified) 1 1 0 (pure comment edit)
useOdometerDraftHydrator.ts (modified) 2 2 0 (comment touch-up)
Subtotals 351 78 228 (+45 blank)

The hook is a single cross-platform file - no .native.ts variant. Platform differences are pushed down into the libs it composes: useRestartOnOdometerImagesFailure has its own native stub that short-circuits blob verification (no blob: URLs on native), and stitchOdometerImages already has a Skia-based .native.ts implementation. Adding an entry-point platform split here would have re-broken stitching on iOS/Android.

Summary

Category Lines % of insertions
Tests 595 63%
Comments / JSDoc in source 78 8%
Blank lines in source 45 5%
Actual non-comment, non-blank source code 228 24%
Total insertions 946 100%

Deletions (151 lines)

File Deletions
OdometerReceiptStitcher.tsx (DELETED) 124
ReceiptFileValidator.tsx (bandaid branch + staleness check) 6
IOURequestStepConfirmation.tsx (component JSX + locals + useState) 16
useRestartOnOdometerImagesFailure/index.ts 1 (old comment)
useOdometerDraftHydrator.ts 4 (comment trim)

Bottom line: real new logic added ~228 lines; real logic removed ~151 lines. Net new "real" logic: roughly +77 lines - mostly the FSM reducer + composition glue inside useOdometerReceiptStitcher. The rest is testing + JSDoc infrastructure.

Fixed Issues

$ #90819
PROPOSAL: N/A

Tests

  1. Start a new expense and open the Distance request flow.
  2. Switch to the Odometer tab.
  3. Enter a start reading.
  4. Enter an end reading.
  5. Attach a start odometer image.
  6. Attach an end odometer image.
  7. Tap Next to proceed to the confirmation step.
  8. Verify the stitched odometer receipt renders on the confirmation page.
  9. Verify the receipt does not flicker or briefly disappear.
  10. Verify you are not redirected back to the start of the flow.
  11. On the confirmation step, tap the Distance field to enter edit mode.
  12. Remove both of the odometer images.
  13. Tap Save to return to the confirmation step.
  14. Verify the confirmation step shows the updated receipt.
  15. Verify the receipt does not flicker after saving.
  16. Verify you are not redirected back to the start of the flow.
Regression tests (optional)
Draft expense
  • Click the + global create button
  • Verify that the Track Distance option displays
  • Click the Track Distance option
  • Verify that Map, Manual, GPS, and Odometer tabs display
  • Click the Odometer tab to create an Odometer distance expense
  • Enter start and end readings
  • Click an image button to take a start odometer reading
  • Take a photo
  • Click Save for later
  • Verify that the page closes
  • Reopen the Distance Request page
  • Navigate to the Odometer page
  • Verify that the reading and image data are displayed correctly
  • Repeat but this time kill the app / close the site tab
  • Verify that the reading and image data are displayed correctly
  • Click Next and create the expense
  • Verify that the expense is created
  • Verify that we display the attached merged receipt
Photo replacement
  • Click the + global create button
  • Verify that the Track Distance option displays
  • Click the Track Distance option
  • Verify that Map, Manual, GPS, and Odometer tabs display
  • Click the Odometer tab to create an Odometer distance expense
  • Enter start and end readings
  • Click an image button to take a start odometer reading
  • Take a photo
  • [Mobile only] Tap the back navigation button
  • [Mobile only] Verify you are shown the discard changes modal
  • [Mobile only] Tap Cancel
  • Click Save for later
  • Reopen the Distance Request page
  • Navigate to the Odometer page
  • Click the image button to take an end odometer reading
  • At the confirm page, the images should be merged into one and displayed
  • Tap Distance, replace either the start or end image
  • Replace it with a new photo
  • Change the start or end distance reading
  • Tap the Save button
  • Verify the combined image has updated
  • Verify the distance calculation has updated
  • Tap the back button to exit the confirmation page
  • Verify that the reading and image data are displayed correctly
  • Click Create expense
  • Verify that the expense is created
  • Verify that we display the attached merged receipt
Clear draft data
  • Click the + global create button
  • Verify that the Track Distance option displays
  • Click the Track Distance option
  • Verify that Map, Manual, GPS, and Odometer tabs display
  • Click the Odometer tab to create an Odometer distance expense
  • Do not enter any readings
  • Click Save for later
  • Verify that the page closes
  • Reopen the Distance Request page
  • Navigate to the Odometer page
  • Verify that no reading data is displayed
  • Enter a start or end reading
  • Tap Save for later
  • Reopen the Distance Request page
  • Navigate to the Odometer page
  • Verify the start/end reading you added is shown
  • Delete the start/end reading
  • Tap Save for later
  • Reopen the Distance Request page
  • Navigate to the Odometer page
  • Verify the start/end reading fields remain empty
Browser refresh on confirmation (web only - Race A scenario)
  • Complete the odometer happy path (start/end reading + start/end image) and land on the confirmation step
  • Verify the stitched receipt is visible
  • Hit browser refresh (Ctrl/Cmd+R)
  • Verify after reload you stay on the confirmation step with the receipt restored (recovered from ODOMETER_DRAFT), or - if no draft exists - that you are navigated back to the start of the odometer flow exactly once with no console errors
Multi-receipt split with mixed odometer + manual rows (Race B scenario)
  • Create an odometer expense (happy path) and land on the confirmation step
  • From the same workspace, add a second receipt via the Manual flow (scan a regular receipt image)
  • With both pending, navigate to the confirmation step that shows both rows
  • Verify the odometer row shows its stitched receipt
  • Verify the manual scan row shows its scanned receipt
  • If the manual scan's blob is dead (simulate via browser refresh and then continue), verify the validator routes back to the manual scan step - the odometer row's recovery path does NOT mask the non-initial manual-row failure

Offline tests

Same as Tests

QA Steps

Same as Tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
input.webm
Android: mWeb Chrome
input1.webm
iOS: Native
iOS: mWeb Safari
output.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-05-21.at.22.37.38.mov

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/components/MoneyRequestConfirmationList.tsx 92.42% <ø> (ø)
.../components/MoneyRequestConfirmationListFooter.tsx 100.00% <100.00%> (ø)
src/hooks/useOdometerDraftHydrator.ts 52.17% <ø> (ø)
...c/hooks/useRestartOnOdometerImagesFailure/index.ts 0.00% <ø> (ø)
src/libs/OdometerReceipt/deriveOdometerReceipt.ts 100.00% <100.00%> (ø)
src/libs/OdometerReceipt/stitchTask.ts 100.00% <100.00%> (ø)
...es/iou/request/step/IOURequestStepConfirmation.tsx 66.13% <100.00%> (-0.43%) ⬇️
...request/step/confirmation/ReceiptFileValidator.tsx 60.00% <75.00%> (-0.53%) ⬇️
src/hooks/useOdometerReceiptStitcher/index.ts 94.11% <94.11%> (ø)
... and 49 files with indirect coverage changes

@jakubkalinski0 jakubkalinski0 marked this pull request as ready for review May 13, 2026 10:54
@jakubkalinski0 jakubkalinski0 requested review from a team as code owners May 13, 2026 10:54
@melvin-bot melvin-bot Bot requested review from carlosmiceli and trjExpensify and removed request for a team May 13, 2026 10:54
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 13, 2026

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@jakubkalinski0
Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@jakubkalinski0
Copy link
Copy Markdown
Contributor Author

@carlosmiceli Sorry, @DylanDylann will take care of review here

@github-actions
Copy link
Copy Markdown
Contributor

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

Comment thread src/libs/stitchOdometerImages/constants.ts Outdated
Comment thread src/pages/iou/request/step/confirmation/OdometerReceiptStitcher.tsx Outdated
trjExpensify
trjExpensify previously approved these changes May 13, 2026
Copy link
Copy Markdown
Contributor

@trjExpensify trjExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WN project PR. 👍

Comment thread src/pages/iou/request/step/confirmation/OdometerReceiptStitcher.tsx Outdated
@DylanDylann
Copy link
Copy Markdown
Contributor

@jakubkalinski0 Please add issue link too

Comment thread src/hooks/useOdometerReceiptStitcher/index.ts Outdated
Comment thread src/pages/iou/request/step/confirmation/ReceiptFileValidator.tsx Outdated
Comment thread src/pages/iou/request/step/IOURequestStepConfirmation.tsx Outdated
Comment thread src/pages/iou/request/step/confirmation/ReceiptFileValidator.tsx Outdated
trjExpensify
trjExpensify previously approved these changes May 22, 2026
Copy link
Copy Markdown
Contributor

@trjExpensify trjExpensify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving from product. 👍

Copy link
Copy Markdown
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice progress, generating a build for testing while the last review comments are resolved

@github-actions
Copy link
Copy Markdown
Contributor

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

Comment thread src/pages/iou/request/step/confirmation/ReceiptFileValidator.tsx Outdated
Comment thread src/pages/iou/request/step/confirmation/ReceiptFileValidator.tsx Outdated
Comment thread src/pages/iou/request/step/confirmation/ReceiptFileValidator.tsx
@DylanDylann
Copy link
Copy Markdown
Contributor

@jakubkalinski0 Could you also adjust the position and style of the stitching error? I think it should be below the receipt

Screenshot 2026-05-25 at 10 32 29

@DylanDylann
Copy link
Copy Markdown
Contributor

DylanDylann commented May 25, 2026

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-05-25.at.11.23.06.mov
Android: mWeb Chrome
Screen.Recording.2026-05-25.at.11.31.08.mov
iOS: HybridApp
Screen.Recording.2026-05-25.at.11.31.54.mov
iOS: mWeb Safari
Screen.Recording.2026-05-25.at.11.33.28.mov
MacOS: Chrome / Safari
Screen.Recording.2026-05-25.at.11.18.22.mov

@jakubkalinski0
Copy link
Copy Markdown
Contributor Author

@jakubkalinski0 Could you also adjust the position and style of the stitching error? I think it should be below the receipt

Good catch!

Comment thread src/pages/iou/request/step/confirmation/ReceiptFileValidator.tsx
@melvin-bot melvin-bot Bot changed the title [Odometer] Fix race condition [Payment due @DylanDylann] [Odometer] Fix race condition May 26, 2026
@melvin-bot
Copy link
Copy Markdown

melvin-bot Bot commented May 26, 2026

🎯 @DylanDylann, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

Comment thread src/pages/iou/request/step/confirmation/ReceiptFileValidator.tsx Outdated
Julesssss
Julesssss previously approved these changes May 26, 2026
Copy link
Copy Markdown
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment for reveiw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants